From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 197B8C433DB for ; Thu, 4 Feb 2021 13:56:18 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 589D464DAE for ; Thu, 4 Feb 2021 13:56:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 589D464DAE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A339516D6; Thu, 4 Feb 2021 14:55:25 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A339516D6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1612446975; bh=xh+EVf8QpMJDaeU2TB+OKcujphlWcmbC4P2bZkaa50w=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=eXpnWsRiA3yPdy9aRAQimpofE9ny8vQn+oEslF8CxhWL0qbTrxf+bJ9JKACtw+/VU PfVvnFsqmsyH6go5IYeU738/sTDDcHBQ+e/rLATtwjW31dXR58WWys/UNoyhXT09ov M9TmHRnjgcgztHZSw2EknVlMN0VW4LG+WRMjH4uM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1A70CF80152; Thu, 4 Feb 2021 14:55:25 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 42672F80171; Thu, 4 Feb 2021 14:55:23 +0100 (CET) Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 61F52F80152 for ; Thu, 4 Feb 2021 14:55:16 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 61F52F80152 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HDJME6Og" Received: by mail-wr1-x42c.google.com with SMTP id p15so3567341wrq.8 for ; Thu, 04 Feb 2021 05:55:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Hzfyw7cGPV/6uJGFEu+jTS7JZCswuKZE6330B5/rJRw=; b=HDJME6Og8gQPqE8NM81cSx+88PddfmG5gPVNemmtSq3Y8X8suM8zbGaTP9KZzoBKEM hRhB0B9ZL1ycoNLqPCiyb3kxYAewRT3Zq5kPQgOx2VQBidV7D8zZKbwvn4eXQYgE+YDY cvuHGM8Z9TPcylYKpwXnkfl9+Zu8Y4f/Q1T3aZC/pj2i6+R2T0ZYs2mh4zF/B+dPtN6O m7VrYgcxl3IA2oXP9JPvpq3FWQXG0VFueDmfqymKV7wuw+8083nvNMAL9JafODYTdfB3 iRjYWt0m7/F8hiH9t/dlPsrbhaY4db1+rnd0tZOTNxlY5G8ERYfp8K25YHmHAZViut4v 0mtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Hzfyw7cGPV/6uJGFEu+jTS7JZCswuKZE6330B5/rJRw=; b=Fl1wNF1xTmcBR/93diWMoUjQOWp2cDfeq14xwHmJ5zyLR8sp1K5qZZrtGY07T8JXBZ A2W5FsnkWrmJq3Kld0PT4wbsBujg3xKJfpY34y97Gyk+fLAMpIJpwfTBFCwkgILJLnT9 Q4tXNU9J1UigpzaHvGhB6jN33dUEMGEX5XMqsgIrJO/MSpRFX44VartqtX4azCd81AaF 0KRmci+/BOobJ7L4rUVDAN3TD2ss2jrBYblKPBymBZ6onAEeZY+6Au7etBaBVYyrL2sM Zdl/64SJtaVcOo/TWetDx74h9iVQ2hKQ5pldMglJ2dplc1nSCX/LYV1QWnBUefiPrtMG Shdw== X-Gm-Message-State: AOAM530hZEes7UaOgkCzmKXkffY9PaDn5itDPwjYT4LeVCkss2DWfJ7u Yj62zZfM/K2fowITOSk1QkMkjQ== X-Google-Smtp-Source: ABdhPJwVtEgqFoIpPqm9mOUpNe597hHfgmhLCj7nzFG8QdQDBA4AccFnlrQRCr4Ieq2ypY5AazLUsA== X-Received: by 2002:a5d:53c3:: with SMTP id a3mr9212935wrw.43.1612446915658; Thu, 04 Feb 2021 05:55:15 -0800 (PST) Received: from dell ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id x82sm856894wmg.31.2021.02.04.05.55.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 05:55:15 -0800 (PST) Date: Thu, 4 Feb 2021 13:55:13 +0000 From: Lee Jones To: Hans de Goede Subject: Re: [PATCH v4 2/5] mfd: arizona: Replace arizona_of_get_type() with device_get_match_data() Message-ID: <20210204135513.GI2789116@dell> References: <20210120214957.140232-1-hdegoede@redhat.com> <20210120214957.140232-3-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210120214957.140232-3-hdegoede@redhat.com> Cc: Cezary Rojewski , Charles Keepax , alsa-devel@alsa-project.org, patches@opensource.cirrus.com, Jie Yang , Pierre-Louis Bossart , linux-kernel@vger.kernel.org, Liam Girdwood , Andy Shevchenko , Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 20 Jan 2021, Hans de Goede wrote: > Replace the custom arizona_of_get_type() function with the generic > device_get_match_data() helper. Besides being a nice cleanup this > also makes it easier to add support for binding to ACPI enumerated > devices. > > While at it also fix a possible NULL pointer deref of the id > argument to the probe functions (this could happen on e.g. manual > driver binding through sysfs). > > Suggested-by: Andy Shevchenko > Reviewed-by: Andy Shevchenko > Acked-by: Charles Keepax > Signed-off-by: Hans de Goede > --- > Changes in v2: > - New patch in v2 of this patchset > --- > drivers/mfd/arizona-core.c | 11 ----------- > drivers/mfd/arizona-i2c.c | 10 ++++++---- > drivers/mfd/arizona-spi.c | 10 ++++++---- > drivers/mfd/arizona.h | 9 --------- > 4 files changed, 12 insertions(+), 28 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14089C433DB for ; Thu, 4 Feb 2021 13:58:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C760764E3F for ; Thu, 4 Feb 2021 13:58:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236430AbhBDN5y (ORCPT ); Thu, 4 Feb 2021 08:57:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236273AbhBDN40 (ORCPT ); Thu, 4 Feb 2021 08:56:26 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42691C061788 for ; Thu, 4 Feb 2021 05:55:17 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id m13so3556195wro.12 for ; Thu, 04 Feb 2021 05:55:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Hzfyw7cGPV/6uJGFEu+jTS7JZCswuKZE6330B5/rJRw=; b=HDJME6Og8gQPqE8NM81cSx+88PddfmG5gPVNemmtSq3Y8X8suM8zbGaTP9KZzoBKEM hRhB0B9ZL1ycoNLqPCiyb3kxYAewRT3Zq5kPQgOx2VQBidV7D8zZKbwvn4eXQYgE+YDY cvuHGM8Z9TPcylYKpwXnkfl9+Zu8Y4f/Q1T3aZC/pj2i6+R2T0ZYs2mh4zF/B+dPtN6O m7VrYgcxl3IA2oXP9JPvpq3FWQXG0VFueDmfqymKV7wuw+8083nvNMAL9JafODYTdfB3 iRjYWt0m7/F8hiH9t/dlPsrbhaY4db1+rnd0tZOTNxlY5G8ERYfp8K25YHmHAZViut4v 0mtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Hzfyw7cGPV/6uJGFEu+jTS7JZCswuKZE6330B5/rJRw=; b=ZNJccqGxKcsc0Oa5gdkmqNZOc/+peGWmkdBBkU3ylcC4AioBtcBrh4UKPb1DUXSdvH oHngm5lbOimhftEFvxsZ8B+5C9wAE4XQhkMrqy6mG+Qg93hBlmIqLq6a9fLkS87xw0/Q 6KaRge+kiHAP03E50HHDE7EAc2gji1VDJqo2sQ3xM+TgWpXYHui02tvgXcD5AmRT953Q jRxzhaTGUZPhNCnLEAXwIKTcP//s8Mk3tHekETPG9n+ZzrIiPhWVqjM3J/7bs5n0sVA4 5+239JnHeF35pidziAd5KFWYgKu3XKOihE9lGE9qjBeOYY4JQeXza4aP0UXVYTtm3zgD iWzA== X-Gm-Message-State: AOAM530zJ8G1gC97nckapqi5C5TZtMZtHMZOysDM+fxTGELZ6TO0N9OJ tXZ90Vzaa5TUZ/9SWTdci2ZUYg== X-Google-Smtp-Source: ABdhPJwVtEgqFoIpPqm9mOUpNe597hHfgmhLCj7nzFG8QdQDBA4AccFnlrQRCr4Ieq2ypY5AazLUsA== X-Received: by 2002:a5d:53c3:: with SMTP id a3mr9212935wrw.43.1612446915658; Thu, 04 Feb 2021 05:55:15 -0800 (PST) Received: from dell ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id x82sm856894wmg.31.2021.02.04.05.55.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 05:55:15 -0800 (PST) Date: Thu, 4 Feb 2021 13:55:13 +0000 From: Lee Jones To: Hans de Goede Cc: Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Jie Yang , Mark Brown , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, Andy Shevchenko , Charles Keepax , alsa-devel@alsa-project.org Subject: Re: [PATCH v4 2/5] mfd: arizona: Replace arizona_of_get_type() with device_get_match_data() Message-ID: <20210204135513.GI2789116@dell> References: <20210120214957.140232-1-hdegoede@redhat.com> <20210120214957.140232-3-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210120214957.140232-3-hdegoede@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 Jan 2021, Hans de Goede wrote: > Replace the custom arizona_of_get_type() function with the generic > device_get_match_data() helper. Besides being a nice cleanup this > also makes it easier to add support for binding to ACPI enumerated > devices. > > While at it also fix a possible NULL pointer deref of the id > argument to the probe functions (this could happen on e.g. manual > driver binding through sysfs). > > Suggested-by: Andy Shevchenko > Reviewed-by: Andy Shevchenko > Acked-by: Charles Keepax > Signed-off-by: Hans de Goede > --- > Changes in v2: > - New patch in v2 of this patchset > --- > drivers/mfd/arizona-core.c | 11 ----------- > drivers/mfd/arizona-i2c.c | 10 ++++++---- > drivers/mfd/arizona-spi.c | 10 ++++++---- > drivers/mfd/arizona.h | 9 --------- > 4 files changed, 12 insertions(+), 28 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog