From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF5E0C433DB for ; Thu, 4 Feb 2021 16:19:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B57C264F10 for ; Thu, 4 Feb 2021 16:19:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237954AbhBDQTC (ORCPT ); Thu, 4 Feb 2021 11:19:02 -0500 Received: from mga14.intel.com ([192.55.52.115]:38900 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237934AbhBDQSt (ORCPT ); Thu, 4 Feb 2021 11:18:49 -0500 IronPort-SDR: /w8vbgSSYIWoSY5MGqTjOUcd0gE1QCvdlXUMTMrq+CoJDdspGVJpIdfUJrCmKOf7nTmT6Fnx0u TxFgQJxkYDJA== X-IronPort-AV: E=McAfee;i="6000,8403,9885"; a="180497898" X-IronPort-AV: E=Sophos;i="5.79,401,1602572400"; d="scan'208";a="180497898" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 08:16:59 -0800 IronPort-SDR: bzAzRLBD3+Ma5y2W74poWfZ7PPWgzQMrm8qKMrz/Axywk0bSiBkqyY8tOLS9ucZwXjTMDVbbx8 Sq3C33R6PRUA== X-IronPort-AV: E=Sophos;i="5.79,401,1602572400"; d="scan'208";a="356576704" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 08:16:57 -0800 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 8915D206DC; Thu, 4 Feb 2021 18:16:54 +0200 (EET) Date: Thu, 4 Feb 2021 18:16:54 +0200 From: Sakari Ailus To: Rob Herring Cc: Martina Krasteva , robh+dt@kernel.org, gjorgjix.rosikopulos@linux.intel.com, devicetree@vger.kernel.org, daniele.alessandrelli@linux.intel.com, mchehab@kernel.org, linux-media@vger.kernel.org, paul.j.murphy@linux.intel.com Subject: Re: [PATCH v7 1/2] dt-bindings: media: Add bindings for imx334 Message-ID: <20210204161654.GC32460@paasikivi.fi.intel.com> References: <20210203135441.136-1-martinax.krasteva@linux.intel.com> <20210203135441.136-2-martinax.krasteva@linux.intel.com> <1612452057.710530.452037.nullmailer@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1612452057.710530.452037.nullmailer@robh.at.kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob, On Thu, Feb 04, 2021 at 09:20:57AM -0600, Rob Herring wrote: > On Wed, 03 Feb 2021 13:54:40 +0000, Martina Krasteva wrote: > > From: Martina Krasteva > > > > - Add dt-bindings documentation for Sony imx334 sensor driver. > > - Add MAINTAINERS entry for Sony imx334 binding documentation. > > > > Signed-off-by: Martina Krasteva > > Reviewed-by: Gjorgji Rosikopulos > > Acked-by: Daniele Alessandrelli > > Acked-by: Paul J. Murphy > > Reviewed-by: Rob Herring > > --- > > .../devicetree/bindings/media/i2c/sony,imx334.yaml | 90 ++++++++++++++++++++++ > > MAINTAINERS | 8 ++ > > 2 files changed, 98 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Error: Documentation/devicetree/bindings/media/i2c/sony,imx334.example.dts:28.17-18 syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:344: Documentation/devicetree/bindings/media/i2c/sony,imx334.example.dt.yaml] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [Makefile:1370: dt_binding_check] Error 2 > > See https://patchwork.ozlabs.org/patch/1435383 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. Thanks for reporting this. The example was apparently missing the assigned-clock-parents property. I'll squash the following change to the patch: diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml index 3145e94d043e7..4217fbea0735a 100644 --- a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml @@ -76,6 +76,7 @@ examples: clocks = <&imx334_clk> assigned-clocks = <&imx334_clk>; + assigned-clock-parents = <&imx334_clk_parent>; assigned-clock-rates = <24000000>; port { -- Kind regards, Sakari Ailus