All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Camelia Groza <camelia.groza@nxp.com>
Cc: kuba@kernel.org, davem@davemloft.net, madalin.bucur@oss.nxp.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH net v2 0/3] dpaa_eth: A050385 erratum workaround fixes under XDP
Date: Thu, 4 Feb 2021 19:54:03 +0100	[thread overview]
Message-ID: <20210204185403.GD2580@ranger.igk.intel.com> (raw)
In-Reply-To: <cover.1612456902.git.camelia.groza@nxp.com>

On Thu, Feb 04, 2021 at 06:49:25PM +0200, Camelia Groza wrote:
> This series addresses issue with the current workaround for the A050385
> erratum in XDP scenarios.
> 
> The first patch makes sure the xdp_frame structure stored at the start of
> new buffers isn't overwritten.
> 
> The second patch decreases the required data alignment value, thus
> preventing unnecessary realignments.
> 
> The third patch moves the data in place to align it, instead of allocating
> a new buffer for each frame that breaks the alignment rules, thus bringing
> an up to 40% performance increase. With this change, the impact of the
> erratum workaround is reduced in many cases to a single digit decrease, and
> to lower double digits in single flow scenarios.
> 

For series:
Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

> Changes in v2:
> - guarantee enough tailroom is available for the shared_info in 1/3
> 
> Camelia Groza (3):
>   dpaa_eth: reserve space for the xdp_frame under the A050385 erratum
>   dpaa_eth: reduce data alignment requirements for the A050385 erratum
>   dpaa_eth: try to move the data in place for the A050385 erratum
> 
>  .../net/ethernet/freescale/dpaa/dpaa_eth.c    | 42 +++++++++++++++++--
>  1 file changed, 38 insertions(+), 4 deletions(-)
> 
> --
> 2.17.1
> 

  parent reply	other threads:[~2021-02-04 19:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 16:49 [PATCH net v2 0/3] dpaa_eth: A050385 erratum workaround fixes under XDP Camelia Groza
2021-02-04 16:49 ` [PATCH net v2 1/3] dpaa_eth: reserve space for the xdp_frame under the A050385 erratum Camelia Groza
2021-02-04 16:49 ` [PATCH net v2 2/3] dpaa_eth: reduce data alignment requirements for " Camelia Groza
2021-02-04 16:49 ` [PATCH net v2 3/3] dpaa_eth: try to move the data in place " Camelia Groza
2021-02-04 18:54 ` Maciej Fijalkowski [this message]
2021-02-05  8:29 ` [PATCH net v2 0/3] dpaa_eth: A050385 erratum workaround fixes under XDP Madalin Bucur (OSS)
2021-02-06 17:48 ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210204185403.GD2580@ranger.igk.intel.com \
    --to=maciej.fijalkowski@intel.com \
    --cc=camelia.groza@nxp.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=madalin.bucur@oss.nxp.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.