From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4FC4C433E6 for ; Thu, 4 Feb 2021 22:25:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8BCD264FAF for ; Thu, 4 Feb 2021 22:25:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229554AbhBDWZL (ORCPT ); Thu, 4 Feb 2021 17:25:11 -0500 Received: from mga02.intel.com ([134.134.136.20]:53358 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229534AbhBDWZI (ORCPT ); Thu, 4 Feb 2021 17:25:08 -0500 IronPort-SDR: 12SpxswXJ0iiSFsRgV8eyo+WPutEluUsOBOd+o7AL1h+KJhXLY6wzDUqy6mic9bCBlm8IflXWS QcgBYfOJFdkg== X-IronPort-AV: E=McAfee;i="6000,8403,9885"; a="168455567" X-IronPort-AV: E=Sophos;i="5.81,153,1610438400"; d="scan'208";a="168455567" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 14:24:27 -0800 IronPort-SDR: y/7S/VUBRnji49Z9RcM7MCK9m9bPc9F2qnjPMyRowJSljxxzoccj0mjoNWsOJdTYwHZYVCzA52 cylVr2edM40A== X-IronPort-AV: E=Sophos;i="5.81,153,1610438400"; d="scan'208";a="576429167" Received: from jguillor-mobl1.amr.corp.intel.com (HELO intel.com) ([10.252.133.14]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 14:24:26 -0800 Date: Thu, 4 Feb 2021 14:24:25 -0800 From: Ben Widawsky To: "John Groves (jgroves)" Cc: Dan Williams , Konrad Rzeszutek Wilk , "linux-cxl@vger.kernel.org" , Linux ACPI , Linux Kernel Mailing List , linux-nvdimm , Linux PCI , Bjorn Helgaas , Chris Browy , Christoph Hellwig , Ira Weiny , Jon Masters , Jonathan Cameron , Rafael Wysocki , Randy Dunlap , Vishal Verma , "daniel.lll@alibaba-inc.com" , "Kelley, Sean V" , David Rientjes Subject: Re: [EXT] Re: [PATCH 04/14] cxl/mem: Implement polled mode mailbox Message-ID: <20210204222425.5vlulgaip7stal3z@intel.com> References: <20210130002438.1872527-1-ben.widawsky@intel.com> <20210130002438.1872527-5-ben.widawsky@intel.com> <20210201175400.GG197521@fedora> <20210201191316.e3kkkwqbx5fujp6y@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 21-02-04 21:53:29, John Groves (jgroves) wrote: > Micron Confidential > > > > From: Dan Williams > Date: Monday, February 1, 2021 at 1:28 PM > To: Ben Widawsky > Cc: Konrad Rzeszutek Wilk , > linux-cxl@vger.kernel.org , Linux ACPI > , Linux Kernel Mailing List > , linux-nvdimm > , Linux PCI , > Bjorn Helgaas , Chris Browy > , Christoph Hellwig , Ira > Weiny , Jon Masters , Jonathan > Cameron , Rafael Wysocki > , Randy Dunlap , > Vishal Verma , daniel.lll@alibaba-inc.com > , John Groves (jgroves) > , Kelley, Sean V > Subject: [EXT] Re: [PATCH 04/14] cxl/mem: Implement polled mode mailbox > > CAUTION: EXTERNAL EMAIL. Do not click links or open attachments unless > you recognize the sender and were expecting this message. > On Mon, Feb 1, 2021 at 11:13 AM Ben Widawsky > wrote: > > > > On 21-02-01 12:54:00, Konrad Rzeszutek Wilk wrote: > > > > +#define > cxl_doorbell_busy(cxlm) > \ > > > > + (cxl_read_mbox_reg32(cxlm, CXLDEV_MB_CTRL_OFFSET) > & \ > > > > + CXLDEV_MB_CTRL_DOORBELL) > > > > + > > > > +#define CXL_MAILBOX_TIMEOUT_US 2000 > > > > > > You been using the spec for the values. Is that number also from it > ? > > > > > > > Yes it is. I'll add a comment with the spec reference. > > > > From section 8.2.8.4 in the CXL 2.0 spec: “The mailbox command timeout > is 2 seconds.” So this should be: > > > #define CXL_MAILBOX_TIMEOUT_US 2000000 > > > …right? 2000us is 2ms… > > Thanks. This was caught already in earlier review by David Rientjes It's renamed CXL_MAILBOX_TIMEOUT_MS 2000 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73CEEC433DB for ; Thu, 4 Feb 2021 22:24:32 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF83D64FAD for ; Thu, 4 Feb 2021 22:24:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF83D64FAD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 70EB6100EAB1E; Thu, 4 Feb 2021 14:24:31 -0800 (PST) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=ben.widawsky@intel.com; receiver= Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BC661100EAB17 for ; Thu, 4 Feb 2021 14:24:28 -0800 (PST) IronPort-SDR: pIxQExgNjKvdHIFwaT7/Wgv1ZMPaFECIQChPOYfaSFdymFfiJRcpJfxwYMHZ5ZNEGQ8xfITFri NmHbN1QCHvdg== X-IronPort-AV: E=McAfee;i="6000,8403,9885"; a="200333769" X-IronPort-AV: E=Sophos;i="5.81,153,1610438400"; d="scan'208";a="200333769" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 14:24:27 -0800 IronPort-SDR: y/7S/VUBRnji49Z9RcM7MCK9m9bPc9F2qnjPMyRowJSljxxzoccj0mjoNWsOJdTYwHZYVCzA52 cylVr2edM40A== X-IronPort-AV: E=Sophos;i="5.81,153,1610438400"; d="scan'208";a="576429167" Received: from jguillor-mobl1.amr.corp.intel.com (HELO intel.com) ([10.252.133.14]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2021 14:24:26 -0800 Date: Thu, 4 Feb 2021 14:24:25 -0800 From: Ben Widawsky To: "John Groves (jgroves)" Subject: Re: [EXT] Re: [PATCH 04/14] cxl/mem: Implement polled mode mailbox Message-ID: <20210204222425.5vlulgaip7stal3z@intel.com> References: <20210130002438.1872527-1-ben.widawsky@intel.com> <20210130002438.1872527-5-ben.widawsky@intel.com> <20210201175400.GG197521@fedora> <20210201191316.e3kkkwqbx5fujp6y@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Message-ID-Hash: EMPUULXO7V2HG26RYJXVLKVNCVBN2EHQ X-Message-ID-Hash: EMPUULXO7V2HG26RYJXVLKVNCVBN2EHQ X-MailFrom: ben.widawsky@intel.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: Konrad Rzeszutek Wilk , "linux-cxl@vger.kernel.org" , Linux ACPI , Linux Kernel Mailing List , linux-nvdimm , Linux PCI , Bjorn Helgaas , Chris Browy , Christoph Hellwig , Jon Masters , Jonathan Cameron , Rafael Wysocki , Randy Dunlap , "daniel.lll@alibaba-inc.com" , "Kelley, Sean V" , David Rientjes X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 T24gMjEtMDItMDQgMjE6NTM6MjksIEpvaG4gR3JvdmVzIChqZ3JvdmVzKSB3cm90ZToNCj4gICAg TWljcm9uIENvbmZpZGVudGlhbA0KPiANCj4gDQo+IA0KPiAgICBGcm9tOiBEYW4gV2lsbGlhbXMg PGRhbi5qLndpbGxpYW1zQGludGVsLmNvbT4NCj4gICAgRGF0ZTogTW9uZGF5LCBGZWJydWFyeSAx LCAyMDIxIGF0IDE6MjggUE0NCj4gICAgVG86IEJlbiBXaWRhd3NreSA8YmVuLndpZGF3c2t5QGlu dGVsLmNvbT4NCj4gICAgQ2M6IEtvbnJhZCBSemVzenV0ZWsgV2lsayA8a29ucmFkLndpbGtAb3Jh Y2xlLmNvbT4sDQo+ICAgIGxpbnV4LWN4bEB2Z2VyLmtlcm5lbC5vcmcgPGxpbnV4LWN4bEB2Z2Vy Lmtlcm5lbC5vcmc+LCBMaW51eCBBQ1BJDQo+ICAgIDxsaW51eC1hY3BpQHZnZXIua2VybmVsLm9y Zz4sIExpbnV4IEtlcm5lbCBNYWlsaW5nIExpc3QNCj4gICAgPGxpbnV4LWtlcm5lbEB2Z2VyLmtl cm5lbC5vcmc+LCBsaW51eC1udmRpbW0NCj4gICAgPGxpbnV4LW52ZGltbUBsaXN0cy4wMS5vcmc+ LCBMaW51eCBQQ0kgPGxpbnV4LXBjaUB2Z2VyLmtlcm5lbC5vcmc+LA0KPiAgICBCam9ybiBIZWxn YWFzIDxoZWxnYWFzQGtlcm5lbC5vcmc+LCBDaHJpcyBCcm93eQ0KPiAgICA8Y2Jyb3d5QGF2ZXJ5 LWRlc2lnbi5jb20+LCBDaHJpc3RvcGggSGVsbHdpZyA8aGNoQGluZnJhZGVhZC5vcmc+LCBJcmEN Cj4gICAgV2VpbnkgPGlyYS53ZWlueUBpbnRlbC5jb20+LCBKb24gTWFzdGVycyA8amNtQGpvbm1h c3RlcnMub3JnPiwgSm9uYXRoYW4NCj4gICAgQ2FtZXJvbiA8Sm9uYXRoYW4uQ2FtZXJvbkBodWF3 ZWkuY29tPiwgUmFmYWVsIFd5c29ja2kNCj4gICAgPHJhZmFlbC5qLnd5c29ja2lAaW50ZWwuY29t PiwgUmFuZHkgRHVubGFwIDxyZHVubGFwQGluZnJhZGVhZC5vcmc+LA0KPiAgICBWaXNoYWwgVmVy bWEgPHZpc2hhbC5sLnZlcm1hQGludGVsLmNvbT4sIGRhbmllbC5sbGxAYWxpYmFiYS1pbmMuY29t DQo+ICAgIDxkYW5pZWwubGxsQGFsaWJhYmEtaW5jLmNvbT4sIEpvaG4gR3JvdmVzIChqZ3JvdmVz KQ0KPiAgICA8amdyb3Zlc0BtaWNyb24uY29tPiwgS2VsbGV5LCBTZWFuIFYgPHNlYW4udi5rZWxs ZXlAaW50ZWwuY29tPg0KPiAgICBTdWJqZWN0OiBbRVhUXSBSZTogW1BBVENIIDA0LzE0XSBjeGwv bWVtOiBJbXBsZW1lbnQgcG9sbGVkIG1vZGUgbWFpbGJveA0KPiANCj4gICAgQ0FVVElPTjogRVhU RVJOQUwgRU1BSUwuIERvIG5vdCBjbGljayBsaW5rcyBvciBvcGVuIGF0dGFjaG1lbnRzIHVubGVz cw0KPiAgICB5b3UgcmVjb2duaXplIHRoZSBzZW5kZXIgYW5kIHdlcmUgZXhwZWN0aW5nIHRoaXMg bWVzc2FnZS4NCj4gICAgT24gTW9uLCBGZWIgMSwgMjAyMSBhdCAxMToxMyBBTSBCZW4gV2lkYXdz a3kgPGJlbi53aWRhd3NreUBpbnRlbC5jb20+DQo+ICAgIHdyb3RlOg0KPiAgICA+DQo+ICAgID4g T24gMjEtMDItMDEgMTI6NTQ6MDAsIEtvbnJhZCBSemVzenV0ZWsgV2lsayB3cm90ZToNCj4gICAg PiA+ID4gKyNkZWZpbmUNCj4gICAgY3hsX2Rvb3JiZWxsX2J1c3koY3hsbSkNCj4gICAgXA0KPiAg ICA+ID4gPiArICAgKGN4bF9yZWFkX21ib3hfcmVnMzIoY3hsbSwgQ1hMREVWX01CX0NUUkxfT0ZG U0VUKQ0KPiAgICAmICAgICAgICAgICAgICAgICAgICBcDQo+ICAgID4gPiA+ICsgICAgQ1hMREVW X01CX0NUUkxfRE9PUkJFTEwpDQo+ICAgID4gPiA+ICsNCj4gICAgPiA+ID4gKyNkZWZpbmUgQ1hM X01BSUxCT1hfVElNRU9VVF9VUyAyMDAwDQo+ICAgID4gPg0KPiAgICA+ID4gWW91IGJlZW4gdXNp bmcgdGhlIHNwZWMgZm9yIHRoZSB2YWx1ZXMuIElzIHRoYXQgbnVtYmVyIGFsc28gZnJvbSBpdA0K PiAgICA/DQo+ICAgID4gPg0KPiAgICA+DQo+ICAgID4gWWVzIGl0IGlzLiBJJ2xsIGFkZCBhIGNv bW1lbnQgd2l0aCB0aGUgc3BlYyByZWZlcmVuY2UuDQo+IA0KPiANCj4gDQo+ICAgIEZyb20gc2Vj dGlvbiA4LjIuOC40IGluIHRoZSBDWEwgMi4wIHNwZWM6IOKAnFRoZSBtYWlsYm94IGNvbW1hbmQg dGltZW91dA0KPiAgICBpcyAyIHNlY29uZHMu4oCdICBTbyB0aGlzIHNob3VsZCBiZToNCj4gDQo+ IA0KPiAgICAjZGVmaW5lIENYTF9NQUlMQk9YX1RJTUVPVVRfVVMgMjAwMDAwMA0KPiANCj4gDQo+ ICAgIOKApnJpZ2h0PyAyMDAwdXMgaXMgMm1z4oCmDQo+IA0KPiANCg0KVGhhbmtzLiBUaGlzIHdh cyBjYXVnaHQgYWxyZWFkeSBpbiBlYXJsaWVyIHJldmlldyBieSBEYXZpZCBSaWVudGplcw0KPHJp ZW50amVzQGdvb2dsZS5jb20+DQoNCkl0J3MgcmVuYW1lZCBDWExfTUFJTEJPWF9USU1FT1VUX01T IDIwMDAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGlu dXgtbnZkaW1tIG1haWxpbmcgbGlzdCAtLSBsaW51eC1udmRpbW1AbGlzdHMuMDEub3JnClRvIHVu c3Vic2NyaWJlIHNlbmQgYW4gZW1haWwgdG8gbGludXgtbnZkaW1tLWxlYXZlQGxpc3RzLjAxLm9y Zwo=