From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/xenomai: smp support needs at least armv6
Date: Fri, 5 Feb 2021 10:01:56 +0100 [thread overview]
Message-ID: <20210205090156.GR2384@scaer> (raw)
In-Reply-To: <20210202205614.59303-1-romain.naour@gmail.com>
Romain, All,
On 2021-02-02 21:56 +0100, Romain Naour spake thusly:
> There are no autobuilder failures for this issue, but the following
> defconfig:
>
> BR2_arm=y
> BR2_TOOLCHAIN_EXTERNAL=y
> BR2_PACKAGE_XENOMAI=y
> BR2_PACKAGE_XENOMAI_COBALT=y
>
> See:
> https://gitlab.denx.de/Xenomai/xenomai/-/blob/v3.1/lib/cobalt/arch/arm/include/asm/xenomai/features.h#L56
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
> package/xenomai/Config.in | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/xenomai/Config.in b/package/xenomai/Config.in
> index b655733528..b1b02373c3 100644
> --- a/package/xenomai/Config.in
> +++ b/package/xenomai/Config.in
> @@ -110,6 +110,8 @@ endchoice
> config BR2_PACKAGE_XENOMAI_ENABLE_SMP
> bool "Enable SMP support"
> default y
> + # SMP not supported below armv6
> + depends on !BR2_ARM_CPU_ARMV4 || !BR2_ARM_CPU_ARMV5
This does not make sense:
- if you are using armv4, then you are not using armv5, and thus the
condition is true;
- if you are using armv5, then you are not using armv4, and thus the
condition is true;
- if you are using neither armv4 nor armv5, then the condition is true.
So, the condition is always true...
I've changed that to:
depends on !BR2_ARM_CPU_ARMV4 && !BR2_ARM_CPU_ARMV5
Applied to master with that fixed, thanks.
Regards,
Yann E. MORIN.
> help
> This option enables SMP support in Xenomai userspace.
>
> --
> 2.29.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2021-02-05 9:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 20:56 [Buildroot] [PATCH 1/2] package/xenomai: smp support needs at least armv6 Romain Naour
2021-02-02 20:56 ` [Buildroot] [PATCH 2/2] package/xenomai: disable cobalt for armv8 Romain Naour
2021-02-05 9:03 ` Yann E. MORIN
2021-02-10 18:53 ` Peter Korsgaard
2021-02-05 9:01 ` Yann E. MORIN [this message]
2021-02-10 18:53 ` [Buildroot] [PATCH 1/2] package/xenomai: smp support needs at least armv6 Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205090156.GR2384@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.