From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [RFC conntrack-tools PATCH] conntrack-tools: introduce conntrackdctl
Date: Fri, 5 Feb 2021 13:28:24 +0100 [thread overview]
Message-ID: <20210205122824.GA16269@salvia> (raw)
In-Reply-To: <161243463641.9380.7754148010781645692.stgit@endurance>
On Thu, Feb 04, 2021 at 11:32:06AM +0100, Arturo Borrero Gonzalez wrote:
> Separate conntrackd command line client functionalities into a different
> binary.
>
> This should help with several things:
> * avoid reading and parsing the config file, which can fail in some enviroments, for example if
> conntrackd is running inside a netns and the referenced interfaces/addresses doesn't exist in
> the namespace conntrackd client command is running from.
> * easily update conntrakdctl with more functionalities without polluting the daemon binary
> * easier code maintenance
[...]
> @@ -333,15 +151,6 @@ int main(int argc, char *argv[])
> exit(EXIT_FAILURE);
> }
>
> - if (type == REQUEST) {
> - if (do_local_request(action, &conf.local, local_step) == -1) {
> - dlog(LOG_ERR, "can't connect: is conntrackd "
> - "running? appropriate permissions?");
> - exit(EXIT_FAILURE);
> - }
> - exit(EXIT_SUCCESS);
> - }
The existing interface needs to be in place to be backward compatible.
I'm fine for you to add this, but we'll have to leave the existing
interface for quite a bit of time, it might take years before we can
deprecate the old way.
next prev parent reply other threads:[~2021-02-05 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 10:32 [RFC conntrack-tools PATCH] conntrack-tools: introduce conntrackdctl Arturo Borrero Gonzalez
2021-02-05 12:28 ` Pablo Neira Ayuso [this message]
2021-02-06 1:57 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205122824.GA16269@salvia \
--to=pablo@netfilter.org \
--cc=arturo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.