From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Keith Busch <keith.busch@wdc.com>,
Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH] nvme: move NVMF_OPT_CTRL_LOSS_TMO to generic list of allowed options
Date: Fri, 5 Feb 2021 17:25:06 +0100 [thread overview]
Message-ID: <20210205162506.GA27415@lst.de> (raw)
In-Reply-To: <20210205154714.127995-1-hare@suse.de>
On Fri, Feb 05, 2021 at 04:47:14PM +0100, Hannes Reinecke wrote:
> Every single fabrics driver with the exception of loop is setting
> NVMF_OPT_CTRL_LOSS_TMO, and recent nvme-cli has begun to set this
> in the default options when create a discovery controller.
> As it's not listed for loop connections to the loop controller will
> fail.
> So move it to the generic options to avoid this failure.
Well, the option doesn't really make sense for loop. I think nvme-cli
needs to be fixed to not set in this case.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-02-05 16:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 15:47 [PATCH] nvme: move NVMF_OPT_CTRL_LOSS_TMO to generic list of allowed options Hannes Reinecke
2021-02-05 16:25 ` Christoph Hellwig [this message]
2021-02-05 16:35 ` Hannes Reinecke
2021-02-05 18:47 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205162506.GA27415@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.