All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: <zyjzyj2000@gmail.com>, <linux-rdma@vger.kernel.org>,
	Bob Pearson <rpearson@hpe.com>
Subject: Re: [PATCH for-next] RDMA/rxe: Remove useless code in rxe_recv.c
Date: Fri, 5 Feb 2021 13:57:17 -0400	[thread overview]
Message-ID: <20210205175717.GB968475@nvidia.com> (raw)
In-Reply-To: <20210127224203.2812-1-rpearson@hpe.com>

On Wed, Jan 27, 2021 at 04:42:04PM -0600, Bob Pearson wrote:
> In check_keys() in rxe_recv.c
> 
> 	if ((...) && pkt->mask) {
> 		...
> 	}
> 
> always has pkt->mask non zero since in rxe_udp_encap_recv()
> pkt->mask is always set to RXE_GRH_MASK (!= 0).  There is no obvious
> reason for this additional test and the original intent is
> lost. This patch simplifies the expression.
> 
> Fixes: 8b7b59d030cc0 ("IB/rxe: remove redudant qpn check")
> Signed-off-by: Bob Pearson <rpearson@hpe.com>
> ---
>  drivers/infiniband/sw/rxe/rxe_recv.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Applied to for-next, thanks

Jason

      reply	other threads:[~2021-02-05 18:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27 22:42 [PATCH for-next] RDMA/rxe: Remove useless code in rxe_recv.c Bob Pearson
2021-02-05 17:57 ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210205175717.GB968475@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=rpearson@hpe.com \
    --cc=rpearsonhpe@gmail.com \
    --cc=zyjzyj2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.