From: Rob Herring <robh@kernel.org>
To: Sven Schuchmann <schuchmann@schleissheimer.de>
Cc: Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] leds: lp50xx: remove unused regulator
Date: Fri, 5 Feb 2021 12:03:40 -0600 [thread overview]
Message-ID: <20210205180340.GA3378994@robh.at.kernel.org> (raw)
In-Reply-To: <20210203083305.2434-1-schuchmann@schleissheimer.de>
On Wed, Feb 03, 2021 at 08:33:05AM +0000, Sven Schuchmann wrote:
> The regulator for vled-supply is unused in the driver.
> It is just assigned from DT and disabled in lp50xx_remove.
> So the code can be removed from the driver.
The binding is not a driver. Does the h/w have a 'vled' supply? If so,
then it should remain in the binding.
>
> Part 1 updates the documentation
> Part 2 removes the code
>
> Signed-off-by: Sven Schuchmann <schuchmann@schleissheimer.de>
>
> ---
> Documentation/devicetree/bindings/leds/leds-lp50xx.yaml | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> index c192b5feadc7..c20a81d13bfd 100644
> --- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> @@ -43,9 +43,6 @@ properties:
> maxItems: 1
> description: GPIO pin to enable/disable the device.
>
> - vled-supply:
> - description: LED supply.
> -
> '#address-cells':
> const: 1
>
> --
> 2.17.1
>
prev parent reply other threads:[~2021-02-05 18:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 8:33 [PATCH 1/2] leds: lp50xx: remove unused regulator Sven Schuchmann
2021-02-05 18:03 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205180340.GA3378994@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=schuchmann@schleissheimer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.