From: Guenter Roeck <linux@roeck-us.net>
To: Yicong Yang <yangyicong@hisilicon.com>
Cc: gregkh@linuxfoundation.org, jdelvare@suse.com,
giometti@enneenne.com, abbotti@mev.co.uk,
hsweeten@visionengravers.com, kw@linux.com, helgaas@kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-hwmon@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kbuild@vger.kernel.org, masahiroy@kernel.org,
michal.lkml@markovi.net, prime.zeng@huawei.com,
linuxarm@openeuler.org
Subject: Re: [PATCH 2/4] hwmon: Use subdir-ccflags-* to inherit debug flag
Date: Fri, 5 Feb 2021 10:28:32 -0800 [thread overview]
Message-ID: <20210205182832.GA186268@roeck-us.net> (raw)
In-Reply-To: <1612518255-23052-3-git-send-email-yangyicong@hisilicon.com>
On Fri, Feb 05, 2021 at 05:44:13PM +0800, Yicong Yang wrote:
> From: Junhao He <hejunhao2@hisilicon.com>
>
> Use subdir-ccflags-* instead of ccflags-* to inherit the debug
> settings from Kconfig when traversing subdirectories.
>
> Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
> Signed-off-by: Junhao He <hejunhao2@hisilicon.com>
> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
What problem does this fix ? Maybe I am missing it, but I don't see
DEBUG being used in a subdirectory of drivers/hwmon.
Guenter
> ---
> drivers/hwmon/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile
> index 09a86c5..1c0c089 100644
> --- a/drivers/hwmon/Makefile
> +++ b/drivers/hwmon/Makefile
> @@ -201,5 +201,5 @@ obj-$(CONFIG_SENSORS_XGENE) += xgene-hwmon.o
> obj-$(CONFIG_SENSORS_OCC) += occ/
> obj-$(CONFIG_PMBUS) += pmbus/
>
> -ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG
> +subdir-ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG
>
> --
> 2.8.1
>
next prev parent reply other threads:[~2021-02-05 18:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 9:44 [PATCH 0/4] Use subdir-ccflags-* to inherit debug flag Yicong Yang
2021-02-05 9:44 ` [PATCH 1/4] driver core: " Yicong Yang
2021-02-05 9:53 ` Greg KH
2021-02-08 10:44 ` Yicong Yang
2021-02-08 10:47 ` Greg KH
2021-02-08 13:09 ` Yicong Yang
2021-02-10 11:42 ` Daniel Thompson
2021-02-24 9:56 ` Yicong Yang
2021-02-05 9:44 ` [PATCH 2/4] hwmon: " Yicong Yang
2021-02-05 18:28 ` Guenter Roeck [this message]
2021-02-05 20:08 ` Bjorn Helgaas
2021-02-08 10:51 ` Yicong Yang
2021-02-08 21:00 ` Guenter Roeck
2021-02-05 9:44 ` [PATCH 3/4] pps: " Yicong Yang
2021-02-05 9:44 ` [PATCH 4/4] staging: comedi: " Yicong Yang
2021-02-05 9:54 ` Greg KH
2021-02-06 0:52 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205182832.GA186268@roeck-us.net \
--to=linux@roeck-us.net \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=giometti@enneenne.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=hsweeten@visionengravers.com \
--cc=jdelvare@suse.com \
--cc=kw@linux.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=prime.zeng@huawei.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.