From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 6/6] sched/fair: reduce the window for duplicated update
Date: Fri, 05 Feb 2021 23:13:59 +0800 [thread overview]
Message-ID: <202102052305.pedyEilf-lkp@intel.com> (raw)
In-Reply-To: <20210205114830.781-7-vincent.guittot@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 10938 bytes --]
Hi Vincent,
I love your patch! Yet something to improve:
[auto build test ERROR on tip/sched/core]
[also build test ERROR on tip/master v5.11-rc6 next-20210125]
[cannot apply to tip/timers/nohz]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Vincent-Guittot/move-update-blocked-load-outside-newidle_balance/20210205-200205
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 075a28439d0c8eb6d3c799e1eed24bb9bc7750cd
config: x86_64-randconfig-a014-20210205 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/806753cfbff0017da882b79fe05d4f40a19d72f9
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Vincent-Guittot/move-update-blocked-load-outside-newidle_balance/20210205-200205
git checkout 806753cfbff0017da882b79fe05d4f40a19d72f9
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> kernel/sched/fair.c:8017:17: error: no member named 'last_blocked_load_update_tick' in 'struct rq'
WRITE_ONCE(rq->last_blocked_load_update_tick, jiffies);
~~ ^
include/asm-generic/rwonce.h:60:33: note: expanded from macro 'WRITE_ONCE'
compiletime_assert_rwonce_type(x); \
^
include/asm-generic/rwonce.h:36:35: note: expanded from macro 'compiletime_assert_rwonce_type'
compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
^
include/linux/compiler_types.h:288:10: note: expanded from macro '__native_word'
(sizeof(t) == sizeof(char) || sizeof(t) == sizeof(short) || \
^
include/linux/compiler_types.h:326:22: note: expanded from macro 'compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
^~~~~~~~~
include/linux/compiler_types.h:314:23: note: expanded from macro '_compiletime_assert'
__compiletime_assert(condition, msg, prefix, suffix)
^~~~~~~~~
include/linux/compiler_types.h:306:9: note: expanded from macro '__compiletime_assert'
if (!(condition)) \
^~~~~~~~~
>> kernel/sched/fair.c:8017:17: error: no member named 'last_blocked_load_update_tick' in 'struct rq'
WRITE_ONCE(rq->last_blocked_load_update_tick, jiffies);
~~ ^
include/asm-generic/rwonce.h:60:33: note: expanded from macro 'WRITE_ONCE'
compiletime_assert_rwonce_type(x); \
^
include/asm-generic/rwonce.h:36:35: note: expanded from macro 'compiletime_assert_rwonce_type'
compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
^
include/linux/compiler_types.h:288:39: note: expanded from macro '__native_word'
(sizeof(t) == sizeof(char) || sizeof(t) == sizeof(short) || \
^
include/linux/compiler_types.h:326:22: note: expanded from macro 'compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
^~~~~~~~~
include/linux/compiler_types.h:314:23: note: expanded from macro '_compiletime_assert'
__compiletime_assert(condition, msg, prefix, suffix)
^~~~~~~~~
include/linux/compiler_types.h:306:9: note: expanded from macro '__compiletime_assert'
if (!(condition)) \
^~~~~~~~~
>> kernel/sched/fair.c:8017:17: error: no member named 'last_blocked_load_update_tick' in 'struct rq'
WRITE_ONCE(rq->last_blocked_load_update_tick, jiffies);
~~ ^
include/asm-generic/rwonce.h:60:33: note: expanded from macro 'WRITE_ONCE'
compiletime_assert_rwonce_type(x); \
^
include/asm-generic/rwonce.h:36:35: note: expanded from macro 'compiletime_assert_rwonce_type'
compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
^
include/linux/compiler_types.h:289:10: note: expanded from macro '__native_word'
sizeof(t) == sizeof(int) || sizeof(t) == sizeof(long))
^
include/linux/compiler_types.h:326:22: note: expanded from macro 'compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
^~~~~~~~~
include/linux/compiler_types.h:314:23: note: expanded from macro '_compiletime_assert'
__compiletime_assert(condition, msg, prefix, suffix)
^~~~~~~~~
include/linux/compiler_types.h:306:9: note: expanded from macro '__compiletime_assert'
if (!(condition)) \
^~~~~~~~~
>> kernel/sched/fair.c:8017:17: error: no member named 'last_blocked_load_update_tick' in 'struct rq'
WRITE_ONCE(rq->last_blocked_load_update_tick, jiffies);
~~ ^
include/asm-generic/rwonce.h:60:33: note: expanded from macro 'WRITE_ONCE'
compiletime_assert_rwonce_type(x); \
^
include/asm-generic/rwonce.h:36:35: note: expanded from macro 'compiletime_assert_rwonce_type'
compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
^
include/linux/compiler_types.h:289:38: note: expanded from macro '__native_word'
sizeof(t) == sizeof(int) || sizeof(t) == sizeof(long))
^
include/linux/compiler_types.h:326:22: note: expanded from macro 'compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
^~~~~~~~~
include/linux/compiler_types.h:314:23: note: expanded from macro '_compiletime_assert'
__compiletime_assert(condition, msg, prefix, suffix)
^~~~~~~~~
include/linux/compiler_types.h:306:9: note: expanded from macro '__compiletime_assert'
if (!(condition)) \
^~~~~~~~~
>> kernel/sched/fair.c:8017:17: error: no member named 'last_blocked_load_update_tick' in 'struct rq'
WRITE_ONCE(rq->last_blocked_load_update_tick, jiffies);
~~ ^
include/asm-generic/rwonce.h:60:33: note: expanded from macro 'WRITE_ONCE'
compiletime_assert_rwonce_type(x); \
^
include/asm-generic/rwonce.h:36:48: note: expanded from macro 'compiletime_assert_rwonce_type'
compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
^
include/linux/compiler_types.h:326:22: note: expanded from macro 'compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
^~~~~~~~~
include/linux/compiler_types.h:314:23: note: expanded from macro '_compiletime_assert'
__compiletime_assert(condition, msg, prefix, suffix)
^~~~~~~~~
include/linux/compiler_types.h:306:9: note: expanded from macro '__compiletime_assert'
if (!(condition)) \
^~~~~~~~~
>> kernel/sched/fair.c:8017:17: error: no member named 'last_blocked_load_update_tick' in 'struct rq'
WRITE_ONCE(rq->last_blocked_load_update_tick, jiffies);
~~ ^
include/asm-generic/rwonce.h:61:15: note: expanded from macro 'WRITE_ONCE'
__WRITE_ONCE(x, val); \
^
include/asm-generic/rwonce.h:55:20: note: expanded from macro '__WRITE_ONCE'
*(volatile typeof(x) *)&(x) = (val); \
^
>> kernel/sched/fair.c:8017:17: error: no member named 'last_blocked_load_update_tick' in 'struct rq'
WRITE_ONCE(rq->last_blocked_load_update_tick, jiffies);
~~ ^
include/asm-generic/rwonce.h:61:15: note: expanded from macro 'WRITE_ONCE'
__WRITE_ONCE(x, val); \
^
include/asm-generic/rwonce.h:55:27: note: expanded from macro '__WRITE_ONCE'
*(volatile typeof(x) *)&(x) = (val); \
^
>> kernel/sched/fair.c:8025:7: error: no member named 'has_blocked_load' in 'struct rq'
rq->has_blocked_load = 0;
~~ ^
8 errors generated.
vim +8017 kernel/sched/fair.c
8009
8010 static void update_blocked_averages(int cpu)
8011 {
8012 bool decayed = false, done = true;
8013 struct rq *rq = cpu_rq(cpu);
8014 struct rq_flags rf;
8015
8016 rq_lock_irqsave(rq, &rf);
> 8017 WRITE_ONCE(rq->last_blocked_load_update_tick, jiffies);
8018
8019 update_rq_clock(rq);
8020
8021 decayed |= __update_blocked_others(rq, &done);
8022 decayed |= __update_blocked_fair(rq, &done);
8023
8024 if (done)
> 8025 rq->has_blocked_load = 0;
8026
8027 if (decayed)
8028 cpufreq_update_util(rq, 0);
8029 rq_unlock_irqrestore(rq, &rf);
8030 }
8031
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30569 bytes --]
next prev parent reply other threads:[~2021-02-05 15:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 11:48 [PATCH 0/6] move update blocked load outside newidle_balance Vincent Guittot
2021-02-05 11:48 ` [PATCH 1/6] sched/fair: remove update of blocked load from newidle_balance Vincent Guittot
2021-02-09 13:09 ` Valentin Schneider
2021-02-09 13:20 ` Vincent Guittot
2021-02-09 13:44 ` Dietmar Eggemann
2021-02-05 11:48 ` [PATCH 2/6] sched/fair: remove unused parameter of update_nohz_stats Vincent Guittot
2021-02-09 13:45 ` Dietmar Eggemann
2021-02-09 17:38 ` Vincent Guittot
2021-02-05 11:48 ` [PATCH 3/6] sched/fair: merge for each idle cpu loop of ILB Vincent Guittot
2021-02-09 13:09 ` Valentin Schneider
2021-02-05 11:48 ` [PATCH 4/6] sched/fair: reorder newidle_balance pulled_task test Vincent Guittot
2021-02-09 13:46 ` Dietmar Eggemann
2021-02-05 11:48 ` [RFC PATCH 5/6] sched/fair: trigger the update of blocked load on newly idle cpu Vincent Guittot
2021-02-09 13:09 ` Valentin Schneider
2021-02-09 13:57 ` Vincent Guittot
2021-02-09 17:25 ` Valentin Schneider
2021-02-09 13:47 ` Dietmar Eggemann
2021-02-09 14:22 ` Vincent Guittot
2021-02-05 11:48 ` [PATCH 6/6] sched/fair: reduce the window for duplicated update Vincent Guittot
2021-02-05 15:13 ` kernel test robot [this message]
2021-02-05 16:13 ` [PATCH 6/6 v2] " Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202102052305.pedyEilf-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.