Re: [PATCH v16 02/12] of: Add a common kexec FDT setup function

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4444 bytes --]

Hi Lakshmi,

I love your patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on robh/for-next arm64/for-next/core v5.11-rc6 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Lakshmi-Ramasubramanian/Carry-forward-IMA-measurement-log-on-kexec-on-ARM64/20210205-010018
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: x86_64-randconfig-a006-20210205 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/029dfec178c52eaec7d685d81c9b0a08da337d66
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Lakshmi-Ramasubramanian/Carry-forward-IMA-measurement-log-on-kexec-on-ARM64/20210205-010018
        git checkout 029dfec178c52eaec7d685d81c9b0a08da337d66
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from arch/x86/include/asm/user_64.h:6,
                    from arch/x86/include/asm/user.h:8,
                    from include/linux/user.h:1,
                    from include/linux/elfcore.h:5,
                    from include/linux/crash_core.h:6,
                    from include/linux/kexec.h:18,
                    from drivers/of/kexec.c:13:
   drivers/of/kexec.c: In function 'of_kexec_setup_new_fdt':
>> drivers/of/kexec.c:86:43: error: 'initial_boot_params' undeclared (first use in this function)
      86 |  ret = fdt_find_and_del_mem_rsv(fdt, __pa(initial_boot_params),
         |                                           ^~~~~~~~~~~~~~~~~~~
   arch/x86/include/asm/page.h:42:46: note: in definition of macro '__pa'
      42 | #define __pa(x)  __phys_addr((unsigned long)(x))
         |                                              ^
   drivers/of/kexec.c:86:43: note: each undeclared identifier is reported only once for each function it appears in
      86 |  ret = fdt_find_and_del_mem_rsv(fdt, __pa(initial_boot_params),
         |                                           ^~~~~~~~~~~~~~~~~~~
   arch/x86/include/asm/page.h:42:46: note: in definition of macro '__pa'
      42 | #define __pa(x)  __phys_addr((unsigned long)(x))
         |                                              ^
   drivers/of/kexec.c:163:17: error: 'const struct kimage_arch' has no member named 'elf_headers_mem'; did you mean 'elf_headers_sz'?
     163 |     image->arch.elf_headers_mem,
         |                 ^~~~~~~~~~~~~~~
         |                 elf_headers_sz
   drivers/of/kexec.c:172:42: error: 'const struct kimage_arch' has no member named 'elf_headers_mem'; did you mean 'elf_headers_sz'?
     172 |   ret = fdt_add_mem_rsv(fdt, image->arch.elf_headers_mem,
         |                                          ^~~~~~~~~~~~~~~
         |                                          elf_headers_sz


vim +/initial_boot_params +86 drivers/of/kexec.c

    65	
    66	/*
    67	 * of_kexec_setup_new_fdt - modify /chosen and memory reservation for the next kernel
    68	 *
    69	 * @image:		kexec image being loaded.
    70	 * @fdt:		Flattened device tree for the next kernel.
    71	 * @initrd_load_addr:	Address where the next initrd will be loaded.
    72	 * @initrd_len:		Size of the next initrd, or 0 if there will be none.
    73	 * @cmdline:		Command line for the next kernel, or NULL if there will
    74	 *			be none.
    75	 *
    76	 * Return: 0 on success, or negative errno on error.
    77	 */
    78	int of_kexec_setup_new_fdt(const struct kimage *image, void *fdt,
    79				   unsigned long initrd_load_addr, unsigned long initrd_len,
    80				   const char *cmdline)
    81	{
    82		int ret, chosen_node;
    83		const void *prop;
    84	
    85		/* Remove memory reservation for the current device tree. */
  > 86		ret = fdt_find_and_del_mem_rsv(fdt, __pa(initial_boot_params),

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34394 bytes --]