All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [drm-drm-intel:drm-intel-gt-next 17/41] drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c:142 igt_gpu_fill_dw() warn: maybe use && instead of &
Date: Sun, 07 Feb 2021 10:05:08 +0800	[thread overview]
Message-ID: <202102071003.SwkMFgvj-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3545 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Chris Wilson <chris@chris-wilson.co.uk>
CC: Matthew Auld <matthew.auld@intel.com>

tree:   git://anongit.freedesktop.org/drm/drm-intel drm-intel-gt-next
head:   38a40d2110751bc9f5c408de992551e1ea7d11c6
commit: 3db2eaa19d4238759ded4793ca6e89f0d47a3415 [17/41] drm/i915/gem: Manage all set-domain waits explicitly
:::::: branch date: 12 hours ago
:::::: commit date: 4 days ago
config: x86_64-randconfig-m001-20210207 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c:142 igt_gpu_fill_dw() warn: maybe use && instead of &

Old smatch warnings:
drivers/gpu/drm/i915/gem/i915_gem_context.h:204 i915_gem_context_get_engine() warn: inconsistent indenting
drivers/gpu/drm/i915/gem/i915_gem_context.h:206 i915_gem_context_get_engine() warn: inconsistent indenting

vim +142 drivers/gpu/drm/i915/gem/selftests/igt_gem_utils.c

18851edfa7dbe1 Matthew Auld 2019-08-10  110  
75b974a859e5d9 Chris Wilson 2019-08-24  111  int igt_gpu_fill_dw(struct intel_context *ce,
75b974a859e5d9 Chris Wilson 2019-08-24  112  		    struct i915_vma *vma, u64 offset,
75b974a859e5d9 Chris Wilson 2019-08-24  113  		    unsigned long count, u32 val)
18851edfa7dbe1 Matthew Auld 2019-08-10  114  {
18851edfa7dbe1 Matthew Auld 2019-08-10  115  	struct i915_request *rq;
18851edfa7dbe1 Matthew Auld 2019-08-10  116  	struct i915_vma *batch;
18851edfa7dbe1 Matthew Auld 2019-08-10  117  	unsigned int flags;
18851edfa7dbe1 Matthew Auld 2019-08-10  118  	int err;
18851edfa7dbe1 Matthew Auld 2019-08-10  119  
75b974a859e5d9 Chris Wilson 2019-08-24  120  	GEM_BUG_ON(!intel_engine_can_store_dword(ce->engine));
18851edfa7dbe1 Matthew Auld 2019-08-10  121  	GEM_BUG_ON(!i915_vma_is_pinned(vma));
18851edfa7dbe1 Matthew Auld 2019-08-10  122  
18851edfa7dbe1 Matthew Auld 2019-08-10  123  	batch = igt_emit_store_dw(vma, offset, count, val);
18851edfa7dbe1 Matthew Auld 2019-08-10  124  	if (IS_ERR(batch))
18851edfa7dbe1 Matthew Auld 2019-08-10  125  		return PTR_ERR(batch);
18851edfa7dbe1 Matthew Auld 2019-08-10  126  
75b974a859e5d9 Chris Wilson 2019-08-24  127  	rq = intel_context_create_request(ce);
18851edfa7dbe1 Matthew Auld 2019-08-10  128  	if (IS_ERR(rq)) {
18851edfa7dbe1 Matthew Auld 2019-08-10  129  		err = PTR_ERR(rq);
18851edfa7dbe1 Matthew Auld 2019-08-10  130  		goto err_batch;
18851edfa7dbe1 Matthew Auld 2019-08-10  131  	}
18851edfa7dbe1 Matthew Auld 2019-08-10  132  
18851edfa7dbe1 Matthew Auld 2019-08-10  133  	i915_vma_lock(batch);
70d6894d1456de Chris Wilson 2019-08-19  134  	err = i915_request_await_object(rq, batch->obj, false);
70d6894d1456de Chris Wilson 2019-08-19  135  	if (err == 0)
18851edfa7dbe1 Matthew Auld 2019-08-10  136  		err = i915_vma_move_to_active(batch, rq, 0);
18851edfa7dbe1 Matthew Auld 2019-08-10  137  	i915_vma_unlock(batch);
18851edfa7dbe1 Matthew Auld 2019-08-10  138  	if (err)
18851edfa7dbe1 Matthew Auld 2019-08-10  139  		goto skip_request;
18851edfa7dbe1 Matthew Auld 2019-08-10  140  
18851edfa7dbe1 Matthew Auld 2019-08-10  141  	i915_vma_lock(vma);
3db2eaa19d4238 Chris Wilson 2021-02-03 @142  	if (vma->obj->cache_dirty & ~vma->obj->cache_coherent)

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37329 bytes --]

                 reply	other threads:[~2021-02-07  2:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202102071003.SwkMFgvj-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.