All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] configs/avenger96_defconfig: add support for Arrow Avenger96 board
Date: Sun, 7 Feb 2021 21:44:41 +0100	[thread overview]
Message-ID: <20210207204441.GQ2384@scaer> (raw)
In-Reply-To: <87blcvy715.fsf@tarshish>

On 2021-02-07 22:09 +0200, Baruch Siach spake thusly:
> Hi Bartosz,
> 
> On Sun, Feb 07 2021, Bartosz Bilas wrote:
> > On 2/7/21 6:00 PM, Baruch Siach wrote:
> >> On Sun, Feb 07 2021, Yann E. MORIN wrote:
> >>> On 2021-02-07 18:09 +0200, Baruch Siach spake thusly:
> >>>> On Sun, Feb 07 2021, Peter Korsgaard wrote:
> >>>>> +  $ sudo dd if=output/images/sdcard.img of=/dev/sdX
> >>>> Maybe warn that this overwrites data on the SD card.
> >>> As far as I could see, we don't do that in any of the 72 readme.txt we
> >>> already have...
> >> $ git grep WARNING -- board/
> >> ...
> >> board/chromebook/elm/readme.txt:WARNING: make sure there is nothing important on that card,
> >> board/chromebook/snow/readme.txt:WARNING: make sure there is nothing important on that card,
> >> board/engicam/geam6ul/readme.txt:*** WARNING! This will destroy all the card content. Use with care! ***
[--SNIP--]

OK, that's for sure not a small list, indeed...

I just had a look at a few readmes, and it seems my sampling was not
that fortunate:

    board/acmesystems/aria-g25/readme.txt
    board/acmesystems/arietta-g25/readme.txt
    board/amarula/vyasa/readme.txt
    board/asus/tinker/readme.txt
    board/csky/readme.txt
    board/orangepi/orangepi-plus/readme.txt
    board/raspberrypi/readme.txt
    board/warp7/readme.txt

And surely, we do not have that warning in all the readmes we have a
"sudo dd":

    $ git grep 'sudo dd ' |wc -l
    72

> > Is not that obvious that dd will overwrite the data? Imo it's superfluous
> > information at all.
> It might be obvious to you. Many newcomers don't know what dd is, or how
> filesystem works. A warning can't hurt.

I too believe that such a warning is superfluous. Working with things
like Buildroot really requires a bit of preliminary knowledge; we can't
take everyone by the hand and we should probably require quite some
prerequisites...

Yeah, the might sound haughty or elitist, but we have to draw the line
somewhere, and I believe usage of 'dd' and its consequences are below
that line...

Regards,
Yann E. MORIN.

> 
> baruch
> 
> -- 
>                                                      ~. .~   Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2021-02-07 20:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-07 15:55 [Buildroot] [PATCH] configs/avenger96_defconfig: add support for Arrow Avenger96 board Peter Korsgaard
2021-02-07 16:09 ` Baruch Siach
2021-02-07 16:52   ` Yann E. MORIN
2021-02-07 17:00     ` Baruch Siach
2021-02-07 17:52       ` Bartosz Bilas
2021-02-07 20:09         ` Baruch Siach
2021-02-07 20:44           ` Yann E. MORIN [this message]
2021-02-07 22:12           ` Peter Korsgaard
2021-02-07 21:49   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210207204441.GQ2384@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.