Re: [RFC PATCH v3 03/11] nvme-tcp-offload: Add device scan implementation

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4473 bytes --]

Hi Shai,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on ipvs/master]
[also build test WARNING on linus/master v5.11-rc6 next-20210125]
[cannot apply to sparc-next/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Shai-Malin/NVMeTCP-Offload-ULP-and-QEDN-Device-Driver/20210208-021754
base:   https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master
config: parisc-randconfig-r034-20210208 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/0d4f6b2496e1300172dd0fcbf94c96a3c2c86441
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Shai-Malin/NVMeTCP-Offload-ULP-and-QEDN-Device-Driver/20210208-021754
        git checkout 0d4f6b2496e1300172dd0fcbf94c96a3c2c86441
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/nvme/host/tcp-offload.c:80:5: warning: no previous prototype for 'nvme_tcp_ofld_report_queue_err' [-Wmissing-prototypes]
      80 | int nvme_tcp_ofld_report_queue_err(struct nvme_tcp_ofld_queue *queue)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/nvme/host/tcp-offload.c:98:1: warning: no previous prototype for 'nvme_tcp_ofld_req_done' [-Wmissing-prototypes]
      98 | nvme_tcp_ofld_req_done(struct nvme_tcp_ofld_req *req,
         | ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/nvme/host/tcp-offload.c:106:1: warning: no previous prototype for 'nvme_tcp_ofld_lookup_dev' [-Wmissing-prototypes]
     106 | nvme_tcp_ofld_lookup_dev(struct nvme_tcp_ofld_ctrl *ctrl)
         | ^~~~~~~~~~~~~~~~~~~~~~~~


vim +/nvme_tcp_ofld_lookup_dev +106 drivers/nvme/host/tcp-offload.c

    71	
    72	/**
    73	 * nvme_tcp_ofld_report_queue_err() - NVMeTCP Offload report error event
    74	 * callback function. Pointed to by nvme_tcp_ofld_queue->report_err.
    75	 * @queue:	NVMeTCP offload queue instance on which the error has occurred.
    76	 *
    77	 * API function that allows the vendor specific offload driver to reports errors
    78	 * to the common offload layer, to invoke error recovery.
    79	 */
  > 80	int nvme_tcp_ofld_report_queue_err(struct nvme_tcp_ofld_queue *queue)
    81	{
    82		/* Placeholder - invoke error recovery flow */
    83	
    84		return 0;
    85	}
    86	
    87	/**
    88	 * nvme_tcp_ofld_req_done() - NVMeTCP Offload request done callback
    89	 * function. Pointed to by nvme_tcp_ofld_req->done.
    90	 * @req:	NVMeTCP offload request to complete.
    91	 * @result:     The nvme_result.
    92	 * @status:     The completion status.
    93	 *
    94	 * API function that allows the vendor specific offload driver to report request
    95	 * completions to the common offload layer.
    96	 */
    97	void
    98	nvme_tcp_ofld_req_done(struct nvme_tcp_ofld_req *req,
    99			       union nvme_result *result,
   100			       __le16 status)
   101	{
   102		/* Placeholder - complete request with/without error */
   103	}
   104	
   105	struct nvme_tcp_ofld_dev *
 > 106	nvme_tcp_ofld_lookup_dev(struct nvme_tcp_ofld_ctrl *ctrl)
   107	{
   108		struct nvme_tcp_ofld_dev *dev;
   109	
   110		down_read(&nvme_tcp_ofld_devices_rwsem);
   111		list_for_each_entry(dev, &nvme_tcp_ofld_devices, entry) {
   112			if (dev->ops->claim_dev(dev, &ctrl->conn_params)) {
   113				/* Increase driver refcnt */
   114				if (!try_module_get(dev->ops->module)) {
   115					pr_err("try_module_get failed\n");
   116					dev = NULL;
   117				}
   118	
   119				goto out;
   120			}
   121		}
   122	
   123		dev = NULL;
   124	out:
   125		up_read(&nvme_tcp_ofld_devices_rwsem);
   126	
   127		return dev;
   128	}
   129	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 31654 bytes --]