From: Alexey Dobriyan <adobriyan@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] sched: make struct task_struct::state 32-bit
Date: Mon, 8 Feb 2021 17:52:45 +0300 [thread overview]
Message-ID: <20210208145245.GA11701@localhost.localdomain> (raw)
In-Reply-To: <20210208143025.GA10066@localhost.localdomain>
On Mon, Feb 08, 2021 at 05:30:25PM +0300, Alexey Dobriyan wrote:
> On Mon, Feb 08, 2021 at 11:34:18AM +0100, Peter Zijlstra wrote:
> > On Sat, Feb 06, 2021 at 06:18:32PM +0300, Alexey Dobriyan wrote:
> >
> > > Silently delete "extern" from prototypes.
> >
> > NAK, extern is right.
>
> Extern is only necessary for variables.
Specifically C17, 6.2.2 p5 (linkage of identifiers):
if the declaration of an identifier for a function has no
storage-class specifier, its linkage is determined exactly as if
it were declared with the storage-class specifier "extern".
This is why nothing happens if "extern" is deleted.
next prev parent reply other threads:[~2021-02-08 14:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-06 15:18 [PATCH 1/5] sched: make struct task_struct::state 32-bit Alexey Dobriyan
2021-02-06 15:20 ` [PATCH 2/5] sched: make nr_running() return 32-bit Alexey Dobriyan
2021-02-06 15:22 ` [PATCH 3/5] sched: make nr_iowait() return 32-bit value Alexey Dobriyan
2021-02-06 15:24 ` [PATCH 4/5] sched: make nr_iowait_cpu() return 32-bit Alexey Dobriyan
2021-02-06 15:30 ` [PATCH 5/5] sched: make multiple runqueue task counters 32-bit Alexey Dobriyan
2021-02-08 10:34 ` [PATCH 1/5] sched: make struct task_struct::state 32-bit Peter Zijlstra
2021-02-08 14:30 ` Alexey Dobriyan
2021-02-08 14:52 ` Alexey Dobriyan [this message]
2021-02-08 15:25 ` Peter Zijlstra
2021-02-08 16:45 ` Alexey Dobriyan
2021-02-08 10:39 ` Peter Zijlstra
2021-02-08 14:33 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210208145245.GA11701@localhost.localdomain \
--to=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.