From: Christoph Hellwig <hch@infradead.org>
To: Sasha Levin <sashal@kernel.org>
Cc: masahiroy@kernel.org, michal.lkml@markovi.net,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org
Subject: Re: [PATCH] kbuild: simplify access to the kernel's version
Date: Mon, 8 Feb 2021 17:50:07 +0000 [thread overview]
Message-ID: <20210208175007.GA1501867@infradead.org> (raw)
In-Reply-To: <20210207161352.2044572-1-sashal@kernel.org>
On Sun, Feb 07, 2021 at 11:13:52AM -0500, Sasha Levin wrote:
> + (u8)(LINUX_VERSION_MAJOR), (u8)(LINUX_VERSION_PATCHLEVEL),
> + (u16)(LINUX_VERSION_SUBLEVEL));
No need for the casts and braces.
Otherwise this looks good, but please also kill off KERNEL_VERSION
and LINUX_KERNEL_VERSION entirely while you're at it.
next prev parent reply other threads:[~2021-02-08 17:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-07 16:13 [PATCH] kbuild: simplify access to the kernel's version Sasha Levin
2021-02-08 7:40 ` Greg KH
2021-02-08 17:50 ` Christoph Hellwig [this message]
2021-02-08 18:20 ` Sasha Levin
2021-02-11 20:18 ` Masahiro Yamada
2021-02-12 3:40 ` Masahiro Yamada
2021-02-12 3:41 ` Masahiro Yamada
2021-02-12 16:19 ` Sasha Levin
-- strict thread matches above, loose matches on Subject: below --
2021-02-08 3:28 Sedat Dilek
2021-02-08 18:17 ` Sasha Levin
2021-02-08 19:26 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210208175007.GA1501867@infradead.org \
--to=hch@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.