From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: <zyjzyj2000@gmail.com>, <linux-rdma@vger.kernel.org>,
Bob Pearson <rpearson@hpe.com>
Subject: Re: [PATCH for-next] RDMA/rxe: Fix checkpatch warnings
Date: Mon, 8 Feb 2021 20:41:02 -0400 [thread overview]
Message-ID: <20210209004102.GA1248548@nvidia.com> (raw)
In-Reply-To: <20210205230525.49068-1-rpearson@hpe.com>
On Fri, Feb 05, 2021 at 05:05:26PM -0600, Bob Pearson wrote:
> checkpatch -f found 3 warnings in RDMA/rxe
>
> 1. a missing space following switch
> 2. return followed by else
> 3. use of strlcpy() instead of strscpy().
>
> This patch fixes each of these. In
>
> ...
> } elseif (...) {
> ...
> return 0;
> } else
> ...
>
> The middle block can be safely moved since it is completely
> independant of the other code.
>
> Signed-off-by: Bob Pearson <rpearson@hpe.com>
> ---
> drivers/infiniband/sw/rxe/rxe_qp.c | 2 +-
> drivers/infiniband/sw/rxe/rxe_verbs.c | 16 ++++++++++------
> 2 files changed, 11 insertions(+), 7 deletions(-)
Applied to for-next, thanks
Jason
prev parent reply other threads:[~2021-02-09 0:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 23:05 [PATCH for-next] RDMA/rxe: Fix checkpatch warnings Bob Pearson
2021-02-09 0:41 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209004102.GA1248548@nvidia.com \
--to=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearson@hpe.com \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.