All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: hch@lst.de, linux-nvme@lists.infradead.org, sagi@grimberg.me
Subject: Re: [PATCH V2 01/11] nvmet: zeroout id-ns buffer for invalid nsid
Date: Tue, 9 Feb 2021 08:57:55 +0100	[thread overview]
Message-ID: <20210209075755.GA31428@lst.de> (raw)
In-Reply-To: <20210209040843.45572-2-chaitanya.kulkarni@wdc.com>

NAK.  Please don't add dead code for a slow path, and please fix the
actual bug in that we need to return 0 here and not an error.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2021-02-09  7:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-09  4:08 [PATCH V2 00/11] nvmet: fixes and some cleanups Chaitanya Kulkarni
2021-02-09  4:08 ` [PATCH V2 01/11] nvmet: zeroout id-ns buffer for invalid nsid Chaitanya Kulkarni
2021-02-09  7:57   ` Christoph Hellwig [this message]
2021-02-09  4:08 ` [PATCH V2 02/11] nvmet: return uniform error for invalid ns Chaitanya Kulkarni
2021-02-09  4:08 ` [PATCH V2 03/11] nvmet: make nvmet_find_namespace() req based Chaitanya Kulkarni
2021-02-09  4:08 ` [PATCH V2 04/11] nvmet: remove extra variable in id-ns handler Chaitanya Kulkarni
2021-02-09  4:08 ` [PATCH V2 05/11] nvmet: add helper to report invalid opcode Chaitanya Kulkarni
2021-02-09  4:08 ` [PATCH V2 06/11] nvmet: use invalid cmd opcode helper Chaitanya Kulkarni
2021-02-09  4:08 ` [PATCH V2 07/11] " Chaitanya Kulkarni
2021-02-09  4:08 ` [PATCH V2 08/11] nvmet: use min of device_path and disk len Chaitanya Kulkarni
2021-02-09  4:08 ` [PATCH V2 09/11] nvme-loop: rename variable to get rid of the warn Chaitanya Kulkarni
2021-02-09  4:08 ` [PATCH V2 10/11] nvmet: add nvmet_req_subsys() helper Chaitanya Kulkarni
2021-02-09  4:08 ` [PATCH V2 11/11] nvmet: remove else at the end of the function Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210209075755.GA31428@lst.de \
    --to=hch@lst.de \
    --cc=chaitanya.kulkarni@wdc.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.