tree: https://github.com/Freescale/linux-fslc 5.4-2.3.x-imx head: 31272db029d013be75160f3fe4aa31d77c911c95 commit: 7801f9a5347345b16fc4039c7b5b612403af0234 [12732/16931] MLK-24507-3 usb: typec: tcpm: add BC charger types if power type is usb config: x86_64-randconfig-m001-20210209 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter New smatch warnings: drivers/usb/typec/tcpm/tcpm.c:4734 tcpm_psy_set_prop() error: uninitialized symbol 'ret'. Old smatch warnings: drivers/usb/typec/tcpm/tcpm.c:463 _tcpm_log() error: testing array offset 'port->logbuffer_head' after use. vim +/ret +4734 drivers/usb/typec/tcpm/tcpm.c f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4702 static int tcpm_psy_set_prop(struct power_supply *psy, f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4703 enum power_supply_property psp, f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4704 const union power_supply_propval *val) f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4705 { f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4706 struct tcpm_port *port = power_supply_get_drvdata(psy); f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4707 int ret; f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4708 f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4709 switch (psp) { f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4710 case POWER_SUPPLY_PROP_ONLINE: f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4711 ret = tcpm_psy_set_online(port, val); f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4712 break; f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4713 case POWER_SUPPLY_PROP_VOLTAGE_NOW: f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4714 if (val->intval < port->pps_data.min_volt * 1000 || f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4715 val->intval > port->pps_data.max_volt * 1000) f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4716 ret = -EINVAL; f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4717 else f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4718 ret = tcpm_pps_set_out_volt(port, val->intval / 1000); f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4719 break; f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4720 case POWER_SUPPLY_PROP_CURRENT_NOW: f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4721 if (val->intval > port->pps_data.max_curr * 1000) f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4722 ret = -EINVAL; f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4723 else f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4724 ret = tcpm_pps_set_op_curr(port, val->intval / 1000); f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4725 break; 7801f9a5347345 drivers/usb/typec/tcpm/tcpm.c Li Jun 2020-08-17 4726 case POWER_SUPPLY_PROP_USB_TYPE: 7801f9a5347345 drivers/usb/typec/tcpm/tcpm.c Li Jun 2020-08-17 4727 port->usb_type = val->intval; 7801f9a5347345 drivers/usb/typec/tcpm/tcpm.c Li Jun 2020-08-17 4728 break; "ret" not set on this path. f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4729 default: f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4730 ret = -EINVAL; f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4731 break; f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4732 } f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4733 f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 @4734 return ret; f2a8aa053c1761 drivers/usb/typec/tcpm.c Adam Thomson 2018-04-23 4735 } --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org