From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sakari Ailus Date: Tue, 09 Feb 2021 12:08:04 +0000 Subject: Re: [PATCH] media: i2c: imx334: Fix an error message Message-Id: <20210209120804.GD32460@paasikivi.fi.intel.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: "Paul J. Murphy" , Martina Krasteva , Daniele Alessandrelli , Mauro Carvalho Chehab , Jacopo Mondi , Gjorgji Rosikopulos , linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org Hi Dan, On Tue, Feb 09, 2021 at 02:04:48PM +0300, Dan Carpenter wrote: > The "ret" variable is uninitialized in this error message. > > Fixes: 9746b11715c3 ("media: i2c: Add imx334 camera sensor driver") > Signed-off-by: Dan Carpenter Thanks for the patch. This has been already addressed by a patch from Hans (but not merged yet): > --- > When new drivers are merged into the kernel, then could we use the > driver prefix? In other words something like this: > > media: i2c/imx334: Add imx334 camera sensor driver We've usually had driver's name and Mauro's scripts add media: prefix --- unless it's already there. Are you suggesting also the bus should be part of it? -- Kind regards, Sakari Ailus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AE68C433DB for ; Tue, 9 Feb 2021 12:11:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 081A264E45 for ; Tue, 9 Feb 2021 12:11:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230033AbhBIMLC (ORCPT ); Tue, 9 Feb 2021 07:11:02 -0500 Received: from mga02.intel.com ([134.134.136.20]:60667 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229705AbhBIMJ7 (ORCPT ); Tue, 9 Feb 2021 07:09:59 -0500 IronPort-SDR: b0vtR+7bJ5Xhui5I3kURhg4F3I9MuNfT1sVhHw2/PTtfrSvp2iI7NrbNXqZb5s5gVwxCHTBOo3 QOHHZ7VPuhDw== X-IronPort-AV: E=McAfee;i="6000,8403,9889"; a="168992860" X-IronPort-AV: E=Sophos;i="5.81,164,1610438400"; d="scan'208";a="168992860" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2021 04:08:09 -0800 IronPort-SDR: Tr4PBGm/FMthpmhKVbqXAKSGFuBdC1bKsJJojV1ehukhdGsp9aFVDSuFuD6OZLqzwIBUFz/3Iz VWGYGoF/wA1g== X-IronPort-AV: E=Sophos;i="5.81,164,1610438400"; d="scan'208";a="509852615" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2021 04:08:06 -0800 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id A3814206D0; Tue, 9 Feb 2021 14:08:04 +0200 (EET) Date: Tue, 9 Feb 2021 14:08:04 +0200 From: Sakari Ailus To: Dan Carpenter Cc: "Paul J. Murphy" , Martina Krasteva , Daniele Alessandrelli , Mauro Carvalho Chehab , Jacopo Mondi , Gjorgji Rosikopulos , linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] media: i2c: imx334: Fix an error message Message-ID: <20210209120804.GD32460@paasikivi.fi.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Dan, On Tue, Feb 09, 2021 at 02:04:48PM +0300, Dan Carpenter wrote: > The "ret" variable is uninitialized in this error message. > > Fixes: 9746b11715c3 ("media: i2c: Add imx334 camera sensor driver") > Signed-off-by: Dan Carpenter Thanks for the patch. This has been already addressed by a patch from Hans (but not merged yet): > --- > When new drivers are merged into the kernel, then could we use the > driver prefix? In other words something like this: > > media: i2c/imx334: Add imx334 camera sensor driver We've usually had driver's name and Mauro's scripts add media: prefix --- unless it's already there. Are you suggesting also the bus should be part of it? -- Kind regards, Sakari Ailus