From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org,
chandanrlinux@gmail.com, Chaitanya.Kulkarni@wdc.com
Subject: Re: [PATCH 5/6] xfs_repair: check dquot id and type
Date: Tue, 9 Feb 2021 08:55:30 -0800 [thread overview]
Message-ID: <20210209165530.GG7190@magnolia> (raw)
In-Reply-To: <20210209093114.GQ1718132@infradead.org>
On Tue, Feb 09, 2021 at 09:31:14AM +0000, Christoph Hellwig wrote:
> On Mon, Feb 08, 2021 at 08:11:44PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Make sure that we actually check the type and id of an ondisk dquot.
>
> This looks copied from the kernel code.
Yeah, it might be time to refactor the quotacheck code into libxfs,
though I suspect the biggest hurdle is that we'd have to port at least
some of xfs_dquot along with it.
--D
> But otherwise looks fine:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2021-02-09 16:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 4:11 [PATCHSET v4 0/6] various: random fixes Darrick J. Wong
2021-02-09 4:11 ` [PATCH 1/6] misc: fix valgrind complaints Darrick J. Wong
2021-02-09 9:19 ` Christoph Hellwig
2021-02-09 4:11 ` [PATCH 2/6] xfs_scrub: detect infinite loops when scanning inodes Darrick J. Wong
2021-02-09 9:26 ` Christoph Hellwig
2021-02-09 4:11 ` [PATCH 3/6] xfs_scrub: load and unload libicu properly Darrick J. Wong
2021-02-09 9:28 ` Christoph Hellwig
2021-02-09 4:11 ` [PATCH 4/6] xfs_scrub: handle concurrent directory updates during name scan Darrick J. Wong
2021-02-09 9:30 ` Christoph Hellwig
2021-02-09 16:53 ` Darrick J. Wong
2021-02-09 4:11 ` [PATCH 5/6] xfs_repair: check dquot id and type Darrick J. Wong
2021-02-09 9:31 ` Christoph Hellwig
2021-02-09 16:55 ` Darrick J. Wong [this message]
2021-02-10 9:48 ` Chandan Babu R
2021-02-11 17:06 ` [PATCH v4.1 " Darrick J. Wong
2021-02-12 12:08 ` Chandan Babu R
2021-02-09 4:11 ` [PATCH 6/6] xfs_scrub: fix weirdness in directory name check code Darrick J. Wong
2021-02-09 9:31 ` Christoph Hellwig
2021-02-10 10:04 ` Chandan Babu R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209165530.GG7190@magnolia \
--to=djwong@kernel.org \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=chandanrlinux@gmail.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.