Re: [RFC] Filesystem error notifications proposal

["Darrick J. Wong" <djwong@kernel.org>]

On Tue, Feb 09, 2021 at 12:57:08PM -0500, Theodore Ts'o wrote:
> On Tue, Feb 09, 2021 at 07:55:01PM +1100, Dave Chinner wrote:
> > 
> > That means we have to work together to find common ground and a
> > solution that works for everyone.  What I've suggested allows all
> > filesystems to supply the same information for the same events.  It
> > also allows filesystems to include their own private diagnostic
> > information appended to the generic message, thereby fulfulling both
> > the goals of both David Howells' original patchset and Gabriel's
> > derived ext4 specific patchset.
> 
> So the simple common ground would be a plain text message, which is
> what *I* had suggested.  But I saw you requesting some complex object
> based system which XFS has.
> 
> I think if we want to keep something that is common, it's going to
> have to be kept simple.  Do you not agree?

I definitely don't want to implement string parsing for xfs_scrub.

The kernel already has enough information to fill out the struct
xfs_scrub_metadata structure for userspace in case it decides to repair.

(HA, maybe that should be the notification format for xfs metadata :P)

--D

>      	   		    	    - Ted