From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8F4CC433E0 for ; Wed, 10 Feb 2021 12:12:47 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6AFF064E31 for ; Wed, 10 Feb 2021 12:12:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6AFF064E31 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id EB79E6F600 for ; Wed, 10 Feb 2021 12:12:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id InMMcNKZzscp for ; Wed, 10 Feb 2021 12:12:46 +0000 (UTC) Received: by smtp3.osuosl.org (Postfix, from userid 1001) id D41EC6F4B9; Wed, 10 Feb 2021 12:12:44 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTP id ADE806ED1C; Wed, 10 Feb 2021 12:12:41 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 81B5EC0174; Wed, 10 Feb 2021 12:12:41 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1AFABC013A for ; Wed, 10 Feb 2021 12:12:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 09F1A87148 for ; Wed, 10 Feb 2021 12:12:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BYiwMsOAWjA6 for ; Wed, 10 Feb 2021 12:12:39 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by hemlock.osuosl.org (Postfix) with ESMTPS id 3FDA08712C for ; Wed, 10 Feb 2021 12:12:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612959158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fo185b+KWk8zT3SUUKGeVFpd35TVy7HrhZIt8uxdMU0=; b=dTllJmQc5kfX0b4uf8MeyCdNs00B0+63FDox50ON0vH2KozQoOUZ3C9tM+SIVru+Vdh38N wfjt/U3B2x4kZtEqW4uS+Kq9QIMA7nNhee6T5TxkNxdjaNI1Z5piko99Qd91x10+TCiqLs 6kYUNHW6Y1/HRQAzA8z73H9JkZHci7o= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-429-HZR9gaNZMQGtUnYN1aUNZQ-1; Wed, 10 Feb 2021 07:12:36 -0500 X-MC-Unique: HZR9gaNZMQGtUnYN1aUNZQ-1 Received: by mail-wm1-f70.google.com with SMTP id y18so1271639wma.8 for ; Wed, 10 Feb 2021 04:12:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=fo185b+KWk8zT3SUUKGeVFpd35TVy7HrhZIt8uxdMU0=; b=AiQBfwrFCTJB/uTSigYi6n0dKbiSajSySELvlrWldY1EN4hpNEtYaoINPVUEglrdY2 6sDKSouem9A/saUdiYXKVGVOpPUh3uJ83N9ZJ0JtwpNj3ngM0sp2sTfQOYY/B6K9jgSM WebYyFPhhVt86oJGN9DUZzsxoRGeqBtYb4d4pScfb81RrOMPYO34rGYe7DmltGwQuUma uOtNT1MJk8sCvkuj6HM/PAg1PNhjdkXRCOtxu6cND+J8KUdKM/yQejqcSbMvqnbDnaWH /O0/nPBtl88uc73TZjLGVjeskknrbUoxe9FKps2+pDYpbtLLZWZlEVgkAIOjAWgixtNA 1BSg== X-Gm-Message-State: AOAM530e0d7mqtiDy95Mu846KsKc9D43SKXQaJLuYhoec8Q6qKH3FYGl kqqqdnniLjy6pD3G4LyNRJpImwB/Ie47+O3jWTeqWyfE41M4YsrfxT8znXQ4F0UoR6xm7CYEhoy W4YARKCxS93babakK2L9C+fuC0VhAtOCcPMwQOQHICw== X-Received: by 2002:a1c:480a:: with SMTP id v10mr2730116wma.132.1612959155134; Wed, 10 Feb 2021 04:12:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJxqJ1zRXwLt0V7vMoyUlpyzWYnYnT3tXF+r0Hdj1LTI3bX10t05o4NRDt3JSbViSeLbfsdcxQ== X-Received: by 2002:a1c:480a:: with SMTP id v10mr2730098wma.132.1612959154945; Wed, 10 Feb 2021 04:12:34 -0800 (PST) Received: from redhat.com (bzq-79-180-2-31.red.bezeqint.net. [79.180.2.31]) by smtp.gmail.com with ESMTPSA id w4sm2695060wrt.69.2021.02.10.04.12.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 04:12:34 -0800 (PST) Date: Wed, 10 Feb 2021 07:12:31 -0500 From: "Michael S. Tsirkin" To: Jason Wang Subject: Re: [PATCH] vdpa/mlx5: fix param validation in mlx5_vdpa_get_config() Message-ID: <20210210071129-mutt-send-email-mst@kernel.org> References: <20210208161741.104939-1-sgarzare@redhat.com> <20210209054302.GA210455@mtl-vdi-166.wap.labs.mlnx> <20210209090014.xolf5kxri3xdmacz@steredhat> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: Eli Cohen , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gV2VkLCBGZWIgMTAsIDIwMjEgYXQgMTI6MTc6MTlQTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiAKPiBPbiAyMDIxLzIvOSDkuIvljYg1OjAwLCBTdGVmYW5vIEdhcnphcmVsbGEgd3JvdGU6 Cj4gPiBPbiBUdWUsIEZlYiAwOSwgMjAyMSBhdCAwNzo0MzowMkFNICswMjAwLCBFbGkgQ29oZW4g d3JvdGU6Cj4gPiA+IE9uIE1vbiwgRmViIDA4LCAyMDIxIGF0IDA1OjE3OjQxUE0gKzAxMDAsIFN0 ZWZhbm8gR2FyemFyZWxsYSB3cm90ZToKPiA+ID4gPiBJdCdzIGxlZ2FsIHRvIGhhdmUgJ29mZnNl dCArIGxlbicgZXF1YWwgdG8KPiA+ID4gPiBzaXplb2Yoc3RydWN0IHZpcnRpb19uZXRfY29uZmln KSwgc2luY2UgJ25kZXYtPmNvbmZpZycgaXMgYQo+ID4gPiA+ICdzdHJ1Y3QgdmlydGlvX25ldF9j b25maWcnLCBzbyB3ZSBjYW4gc2FmZWx5IGNvcHkgaXRzIGNvbnRlbnQgdW5kZXIKPiA+ID4gPiB0 aGlzIGNvbmRpdGlvbi4KPiA+ID4gPiAKPiA+ID4gPiBGaXhlczogMWE4NmIzNzdhYTIxICgidmRw YS9tbHg1OiBBZGQgVkRQQSBkcml2ZXIgZm9yIHN1cHBvcnRlZAo+ID4gPiA+IG1seDUgZGV2aWNl cyIpCj4gPiA+ID4gQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcKPiA+ID4gPiBTaWduZWQtb2Zm LWJ5OiBTdGVmYW5vIEdhcnphcmVsbGEgPHNnYXJ6YXJlQHJlZGhhdC5jb20+Cj4gPiA+IAo+ID4g PiBBY2tlZC1ieTogRWxpIENvaGVuIDxlbGljQG52aWRpYS5jb20+Cj4gPiA+IAo+ID4gPiBCVFcs IHNhbWUgZXJyb3IgaW4gdmRwYV9zaW0geW91IG1heSB3YW50IHRvIGZpeC4KPiA+ID4gCj4gPiAK PiA+IENvbW1pdCA2NWI3MDk1ODZlMjIgKCJ2ZHBhX3NpbTogYWRkIGdldF9jb25maWcgY2FsbGJh Y2sgaW4KPiA+IHZkcGFzaW1fZGV2X2F0dHIiKSB1bmludGVudGlvbmFsbHkgc29sdmVkIGl0Lgo+ ID4gCj4gPiBTaW5jZSBpdCdzIGEgc2ltdWxhdG9yLCBtYXliZSB3ZSBjYW4gYXZvaWQgc29sdmlu ZyBpdCBpbiB0aGUgc3RhYmxlCj4gPiBicmFuY2hlcy4gT3IgZG9lcyBpdCBtYXR0ZXI/Cj4gCj4g Cj4gSSB0aGluayBub3QsIHNpbmNlIHRoZSBtb2R1bGUgZGVwZW5kcyBvbiBSVU5USU1FX1RFU1RJ TkdfTUVOVS4KPiAKPiBUaGFua3MKPiAKCldlbGwgcGVvcGxlIHVzZSB0aGUgc2ltdWxhdG9yIGZv ciBkZXZlbG9wbWVudC4uLgpJJ20gbm90IGdvaW5nIHRvIGJsb2NrIHRoaXMgcGF0Y2ggb24gaXQs IGJ1dCBpZiBzb21lb25lCmhhcyB0aGUgY3ljbGVzIHRvIHBvc3QgYSBzdGFibGUgYnJhbmNoIHBh dGNoLCB0aGF0IHdvdWxkIGJlCmdyZWF0LgoKCj4gCj4gCj4gPiAKPiA+IFRoYW5rcywKPiA+IFN0 ZWZhbm8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClZp cnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3Vu ZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0 aW5mby92aXJ0dWFsaXphdGlvbg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA428C433E0 for ; Wed, 10 Feb 2021 12:19:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C04164E31 for ; Wed, 10 Feb 2021 12:19:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230484AbhBJMTl (ORCPT ); Wed, 10 Feb 2021 07:19:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:25269 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231671AbhBJMOT (ORCPT ); Wed, 10 Feb 2021 07:14:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612959158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fo185b+KWk8zT3SUUKGeVFpd35TVy7HrhZIt8uxdMU0=; b=dTllJmQc5kfX0b4uf8MeyCdNs00B0+63FDox50ON0vH2KozQoOUZ3C9tM+SIVru+Vdh38N wfjt/U3B2x4kZtEqW4uS+Kq9QIMA7nNhee6T5TxkNxdjaNI1Z5piko99Qd91x10+TCiqLs 6kYUNHW6Y1/HRQAzA8z73H9JkZHci7o= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-442-BVEb-Rs5O5CTiisOPPTC6g-1; Wed, 10 Feb 2021 07:12:36 -0500 X-MC-Unique: BVEb-Rs5O5CTiisOPPTC6g-1 Received: by mail-wr1-f69.google.com with SMTP id x12so1627870wrw.21 for ; Wed, 10 Feb 2021 04:12:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=fo185b+KWk8zT3SUUKGeVFpd35TVy7HrhZIt8uxdMU0=; b=JPAputaQoGuL/d0l8K2K1Czao8NYbGXN8NTg70Ad2JDdhyeIjzRDy2u+DA4XsqwIvh h0yAE1WYjFa9TqcnrpVTvCZFiw8Zuf21SDPJVJxd4vO6Kh1dSYV3bP2gC1PWVaIR8Zv8 BXv2ms9ykwoO/bz0O26E2nnlHkxn++5JxaTRLBcJjesASL4Oq+5/a1qy51mtSA55Gp4x P12XDsA4TKuWA6kgEO7zv8gM1k4HgCo/T04RXWat5J/AltI8ssGOxMfPbAqMKqQx7gvq ZUxkVIXmTYbn426i4XzrxHoH/fzEc+46rgJQJl2t2hHvF7U2T41t2zOiKlNmsGZefCa4 Dxrw== X-Gm-Message-State: AOAM530ZhDhs9UFCyi4PTdZrSBiG+aTtgVsURa7O6cURGfQbFc23pJvB aQnlomiM+AXlsM8PX3ivycZPqJWTBjmANI0gSG0U2ZfGJgihtqZ8QyeVrZ/TjRComhirdeTggz0 7obofK2c9qneK7hdrd1tgEp7X X-Received: by 2002:a1c:480a:: with SMTP id v10mr2730115wma.132.1612959155134; Wed, 10 Feb 2021 04:12:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJxqJ1zRXwLt0V7vMoyUlpyzWYnYnT3tXF+r0Hdj1LTI3bX10t05o4NRDt3JSbViSeLbfsdcxQ== X-Received: by 2002:a1c:480a:: with SMTP id v10mr2730098wma.132.1612959154945; Wed, 10 Feb 2021 04:12:34 -0800 (PST) Received: from redhat.com (bzq-79-180-2-31.red.bezeqint.net. [79.180.2.31]) by smtp.gmail.com with ESMTPSA id w4sm2695060wrt.69.2021.02.10.04.12.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 04:12:34 -0800 (PST) Date: Wed, 10 Feb 2021 07:12:31 -0500 From: "Michael S. Tsirkin" To: Jason Wang Cc: Stefano Garzarella , Eli Cohen , virtualization@lists.linux-foundation.org, Parav Pandit , linux-kernel@vger.kernel.org Subject: Re: [PATCH] vdpa/mlx5: fix param validation in mlx5_vdpa_get_config() Message-ID: <20210210071129-mutt-send-email-mst@kernel.org> References: <20210208161741.104939-1-sgarzare@redhat.com> <20210209054302.GA210455@mtl-vdi-166.wap.labs.mlnx> <20210209090014.xolf5kxri3xdmacz@steredhat> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 10, 2021 at 12:17:19PM +0800, Jason Wang wrote: > > On 2021/2/9 下午5:00, Stefano Garzarella wrote: > > On Tue, Feb 09, 2021 at 07:43:02AM +0200, Eli Cohen wrote: > > > On Mon, Feb 08, 2021 at 05:17:41PM +0100, Stefano Garzarella wrote: > > > > It's legal to have 'offset + len' equal to > > > > sizeof(struct virtio_net_config), since 'ndev->config' is a > > > > 'struct virtio_net_config', so we can safely copy its content under > > > > this condition. > > > > > > > > Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported > > > > mlx5 devices") > > > > Cc: stable@vger.kernel.org > > > > Signed-off-by: Stefano Garzarella > > > > > > Acked-by: Eli Cohen > > > > > > BTW, same error in vdpa_sim you may want to fix. > > > > > > > Commit 65b709586e22 ("vdpa_sim: add get_config callback in > > vdpasim_dev_attr") unintentionally solved it. > > > > Since it's a simulator, maybe we can avoid solving it in the stable > > branches. Or does it matter? > > > I think not, since the module depends on RUNTIME_TESTING_MENU. > > Thanks > Well people use the simulator for development... I'm not going to block this patch on it, but if someone has the cycles to post a stable branch patch, that would be great. > > > > > > Thanks, > > Stefano