From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Wed, 10 Feb 2021 08:23:41 +0000 Subject: Re: [PATCH] video: use getter/setter functions Message-Id: <20210210082341.GH220368@dell> List-Id: References: <20210209211325.1261842-1-Julia.Lawall@inria.fr> In-Reply-To: <20210209211325.1261842-1-Julia.Lawall@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Julia Lawall Cc: Daniel Thompson , linux-kernel@vger.kernel.org, Pengutronix Kernel Team , Jingoo Han , Sascha Hauer , kernel-janitors@vger.kernel.org, Michal Simek , dri-devel@lists.freedesktop.org, Bjorn Andersson , Andy Gross , NXP Linux Team , linux-fbdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, Shawn Guo , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org On Tue, 09 Feb 2021, Julia Lawall wrote: > Use getter and setter functions, for platform_device structures and a > spi_device structure. > > Signed-off-by: Julia Lawall > > --- > drivers/video/backlight/qcom-wled.c | 2 +- This patch is fine. Could you please split it out and submit it separately though please. > drivers/video/fbdev/amifb.c | 4 ++-- > drivers/video/fbdev/da8xx-fb.c | 4 ++-- > drivers/video/fbdev/imxfb.c | 2 +- > drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c | 6 +++--- > drivers/video/fbdev/omap2/omapfb/dss/dpi.c | 4 ++-- > drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 4 ++-- > drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c | 2 +- > drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c | 2 +- > drivers/video/fbdev/xilinxfb.c | 2 +- > 10 files changed, 16 insertions(+), 16 deletions(-) ...] > diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c > index 3bc7800eb0a9..091f07e7c145 100644 > --- a/drivers/video/backlight/qcom-wled.c > +++ b/drivers/video/backlight/qcom-wled.c > @@ -1692,7 +1692,7 @@ static int wled_probe(struct platform_device *pdev) > > static int wled_remove(struct platform_device *pdev) > { > - struct wled *wled = dev_get_drvdata(&pdev->dev); > + struct wled *wled = platform_get_drvdata(pdev); > > mutex_destroy(&wled->lock); > cancel_delayed_work_sync(&wled->ovp_work); For my own reference (apply this as-is to your sign-off block): Acked-for-Backlight-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09E21C433DB for ; Wed, 10 Feb 2021 08:24:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7EA064E42 for ; Wed, 10 Feb 2021 08:24:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233162AbhBJIYf (ORCPT ); Wed, 10 Feb 2021 03:24:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233657AbhBJIYZ (ORCPT ); Wed, 10 Feb 2021 03:24:25 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 430EAC06174A for ; Wed, 10 Feb 2021 00:23:45 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id z6so1416927wrq.10 for ; Wed, 10 Feb 2021 00:23:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=MJzRoK5AHHgr8V25vpyceNTWmZxiFyKsyjhqQm8Vxxc=; b=d/b3ponHrtEaGh9+nR4CHVGjqOHtnpraE5raOOOMutWd3Y/vW/uw1i/PmwjfcCAOlI hSBPogoT7cAULj0g3PmoKbO+SoDAWMPSOECHnT1Hf4DW/HG3NgCZs5Oz4yycpbsGpbXz 6aDc3GNQtnk1ZzXHSwQCVv4LOVj0FL2tcZrnkEKPH22CeUw6azGEwO6gqPhOeo/UTzC8 CAGMYMu0CibvYCRJgy2fuPg3TqVZbhGt5gHufNtUof0Gw0FDR3KgWX5KWtTvRU2bJCB3 6J8LXoac3H1R5/6ZWZ8wIHim0sOUZG312tHezmcG2vA/YZDFQNq2NLrC7BlZj/TPwF8d LG7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=MJzRoK5AHHgr8V25vpyceNTWmZxiFyKsyjhqQm8Vxxc=; b=AWWyQ7Jw0lK0HN1pPd6R1UPtv57gYD04XppFJhxT8Cu6crpJ7hTNmavTYJ47dOs3Tm AarfY9bn/kOqqRkVnNeCnmhaOi3t1UwjDJ2U2v2KqxsAyx+Ai35nregUdijEHn5OA6Lt ff1GedcG70prTPSNpoxqbo8uQtj/48lKk8UFtg0Qf2PEULjICuXwvEWIORiyo9CjLlcw GlFlg/+PbvjKKQKpc3RQo3k2+M0hWv5QKgeS8IH5gmdzpw3orap2rYOAyVFWKPzhuut/ TdTlejpBGTAvIIC2+surfkKS9BXUqwOFr8xq14aRHfV4eHa+tJSGWYbktcokHhUnGoWK cbSg== X-Gm-Message-State: AOAM533cKHRFLyWpwBEdbRLygS28kiHp5NoquFccUcv41SdzUvErnD0M XDWsLkN9IigydDcWZJOvJsa7ZphK241b5g== X-Google-Smtp-Source: ABdhPJzpmLKGtf/B7RhbJlQwrCAP0Mb8Tyioqci54O7y0v57o4U82PROFirmSWr5+lJk79X2A0kouQ== X-Received: by 2002:a05:6000:2cf:: with SMTP id o15mr2236419wry.184.1612945423966; Wed, 10 Feb 2021 00:23:43 -0800 (PST) Received: from dell ([91.110.221.237]) by smtp.gmail.com with ESMTPSA id h9sm1850897wrc.94.2021.02.10.00.23.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 00:23:43 -0800 (PST) Date: Wed, 10 Feb 2021 08:23:41 +0000 From: Lee Jones To: Julia Lawall Cc: Fabio Estevam , kernel-janitors@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Michal Simek , Andy Gross , Bjorn Andersson , Daniel Thompson , Jingoo Han , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Sascha Hauer , Pengutronix Kernel Team , Shawn Guo , NXP Linux Team Subject: Re: [PATCH] video: use getter/setter functions Message-ID: <20210210082341.GH220368@dell> References: <20210209211325.1261842-1-Julia.Lawall@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210209211325.1261842-1-Julia.Lawall@inria.fr> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, 09 Feb 2021, Julia Lawall wrote: > Use getter and setter functions, for platform_device structures and a > spi_device structure. > > Signed-off-by: Julia Lawall > > --- > drivers/video/backlight/qcom-wled.c | 2 +- This patch is fine. Could you please split it out and submit it separately though please. > drivers/video/fbdev/amifb.c | 4 ++-- > drivers/video/fbdev/da8xx-fb.c | 4 ++-- > drivers/video/fbdev/imxfb.c | 2 +- > drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c | 6 +++--- > drivers/video/fbdev/omap2/omapfb/dss/dpi.c | 4 ++-- > drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 4 ++-- > drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c | 2 +- > drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c | 2 +- > drivers/video/fbdev/xilinxfb.c | 2 +- > 10 files changed, 16 insertions(+), 16 deletions(-) ...] > diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c > index 3bc7800eb0a9..091f07e7c145 100644 > --- a/drivers/video/backlight/qcom-wled.c > +++ b/drivers/video/backlight/qcom-wled.c > @@ -1692,7 +1692,7 @@ static int wled_probe(struct platform_device *pdev) > > static int wled_remove(struct platform_device *pdev) > { > - struct wled *wled = dev_get_drvdata(&pdev->dev); > + struct wled *wled = platform_get_drvdata(pdev); > > mutex_destroy(&wled->lock); > cancel_delayed_work_sync(&wled->ovp_work); For my own reference (apply this as-is to your sign-off block): Acked-for-Backlight-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 254C7C433E0 for ; Wed, 10 Feb 2021 08:25:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F03460231 for ; Wed, 10 Feb 2021 08:25:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F03460231 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=65csT5o5ciBO+ULShrU5NMc3F03RSMroUqtHG6cnbbA=; b=BtZ+e4PeJDH16fNfLScpazvA3 Xzc73Uav0xDzkj/uJ45NYfjK8JDlDowhGFeLazI5KIb/W0ThxKbSW83mR1SCffHMwx2SAA7rqkvt/ fxcdtEwiBffQm6l7KR1m4AO2hSjWQUAL68P+zsHvSoWkzYg6TSFjjw9xUaTmfJ5vzuomi40JRRvrB nUi5Xke5LLv2RzOJ3smPrJHZpjYBH0Zb44JpkSN45cTYJa9xFEFRd6dZqIGZpayAA6iLa1Zt9Wo4L +M8cF2x1sz+yImfNVNRA3G/jdCdSuOvCR49w1fPZRJtLs8rBPG9RKtiEiqMO1y5fdq1N4XFOsqJW/ 8O8ppE4Aw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9kms-0004iu-KL; Wed, 10 Feb 2021 08:23:50 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9kmn-0004hN-Q8 for linux-arm-kernel@lists.infradead.org; Wed, 10 Feb 2021 08:23:46 +0000 Received: by mail-wr1-x434.google.com with SMTP id z6so1416926wrq.10 for ; Wed, 10 Feb 2021 00:23:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=MJzRoK5AHHgr8V25vpyceNTWmZxiFyKsyjhqQm8Vxxc=; b=d/b3ponHrtEaGh9+nR4CHVGjqOHtnpraE5raOOOMutWd3Y/vW/uw1i/PmwjfcCAOlI hSBPogoT7cAULj0g3PmoKbO+SoDAWMPSOECHnT1Hf4DW/HG3NgCZs5Oz4yycpbsGpbXz 6aDc3GNQtnk1ZzXHSwQCVv4LOVj0FL2tcZrnkEKPH22CeUw6azGEwO6gqPhOeo/UTzC8 CAGMYMu0CibvYCRJgy2fuPg3TqVZbhGt5gHufNtUof0Gw0FDR3KgWX5KWtTvRU2bJCB3 6J8LXoac3H1R5/6ZWZ8wIHim0sOUZG312tHezmcG2vA/YZDFQNq2NLrC7BlZj/TPwF8d LG7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=MJzRoK5AHHgr8V25vpyceNTWmZxiFyKsyjhqQm8Vxxc=; b=ksuedW6+UGSKrUVz287WWWpJ1x7pYQp93eB4RbPV82pV0Iiw+2DqiGIMJAERVTn0pO qb6rkw+iz+PW+cWV621p4jG+9WLbwJhejwAVQQKiD0oZzL99FmrDRCbEX+c+kN5Rdf34 b6NERpYkATSsqmcvI8tbloOHue8/MikeCfBLPeL52DalLqtipx8C+KCqeipjcWKOJDPu inhNnbDIWDboCKZYVwUj9ICDEr4Bh1bMVYee8IhyDwTH5fkICSx+OcB9ZQviQb6eypEc Viy7p2RRBQfEW6n4WEimRjxhflh9u26IHKH5YWZCtUtBGCtmjdijSgvVUUZAalCn6uPP ncAQ== X-Gm-Message-State: AOAM532YX901BA66JOGqcmaaeQ7eJ6334WOwGxanbbwRwHqx0x0bjWz0 aWJjSTPa/qY/BvCcgTS7U5uP/g== X-Google-Smtp-Source: ABdhPJzpmLKGtf/B7RhbJlQwrCAP0Mb8Tyioqci54O7y0v57o4U82PROFirmSWr5+lJk79X2A0kouQ== X-Received: by 2002:a05:6000:2cf:: with SMTP id o15mr2236419wry.184.1612945423966; Wed, 10 Feb 2021 00:23:43 -0800 (PST) Received: from dell ([91.110.221.237]) by smtp.gmail.com with ESMTPSA id h9sm1850897wrc.94.2021.02.10.00.23.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 00:23:43 -0800 (PST) Date: Wed, 10 Feb 2021 08:23:41 +0000 From: Lee Jones To: Julia Lawall Subject: Re: [PATCH] video: use getter/setter functions Message-ID: <20210210082341.GH220368@dell> References: <20210209211325.1261842-1-Julia.Lawall@inria.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210209211325.1261842-1-Julia.Lawall@inria.fr> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210210_032345_948108_D43AB827 X-CRM114-Status: GOOD ( 16.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Thompson , linux-kernel@vger.kernel.org, Pengutronix Kernel Team , Jingoo Han , Sascha Hauer , kernel-janitors@vger.kernel.org, Michal Simek , dri-devel@lists.freedesktop.org, Bjorn Andersson , Andy Gross , NXP Linux Team , linux-fbdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, Shawn Guo , linux-omap@vger.kernel.org, Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAwOSBGZWIgMjAyMSwgSnVsaWEgTGF3YWxsIHdyb3RlOgoKPiBVc2UgZ2V0dGVyIGFu ZCBzZXR0ZXIgZnVuY3Rpb25zLCBmb3IgcGxhdGZvcm1fZGV2aWNlIHN0cnVjdHVyZXMgYW5kIGEK PiBzcGlfZGV2aWNlIHN0cnVjdHVyZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBKdWxpYSBMYXdhbGwg PEp1bGlhLkxhd2FsbEBpbnJpYS5mcj4KPiAKPiAtLS0KPiAgZHJpdmVycy92aWRlby9iYWNrbGln aHQvcWNvbS13bGVkLmMgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgICAyICst CgpUaGlzIHBhdGNoIGlzIGZpbmUuCgpDb3VsZCB5b3UgcGxlYXNlIHNwbGl0IGl0IG91dCBhbmQg c3VibWl0IGl0IHNlcGFyYXRlbHkgdGhvdWdoIHBsZWFzZS4KCj4gIGRyaXZlcnMvdmlkZW8vZmJk ZXYvYW1pZmIuYyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAg NCArKy0tCj4gIGRyaXZlcnMvdmlkZW8vZmJkZXYvZGE4eHgtZmIuYyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHwgICAgNCArKy0tCj4gIGRyaXZlcnMvdmlkZW8vZmJkZXYv aW14ZmIuYyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgMiAr LQo+ICBkcml2ZXJzL3ZpZGVvL2ZiZGV2L29tYXAyL29tYXBmYi9kaXNwbGF5cy9wYW5lbC1sZ3Bo aWxpcHMtbGIwMzVxMDIuYyB8ICAgIDYgKysrLS0tCj4gIGRyaXZlcnMvdmlkZW8vZmJkZXYvb21h cDIvb21hcGZiL2Rzcy9kcGkuYyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgNCArKy0t Cj4gIGRyaXZlcnMvdmlkZW8vZmJkZXYvb21hcDIvb21hcGZiL2Rzcy9kc2kuYyAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgICAgNCArKy0tCj4gIGRyaXZlcnMvdmlkZW8vZmJkZXYvb21hcDIv b21hcGZiL2Rzcy9oZG1pNC5jICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgMiArLQo+ICBk cml2ZXJzL3ZpZGVvL2ZiZGV2L29tYXAyL29tYXBmYi9kc3MvaGRtaTUuYyAgICAgICAgICAgICAg ICAgICAgICAgICB8ICAgIDIgKy0KPiAgZHJpdmVycy92aWRlby9mYmRldi94aWxpbnhmYi5jICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgICAyICstCj4gIDEwIGZpbGVz IGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQoKLi4uXQoKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy92aWRlby9iYWNrbGlnaHQvcWNvbS13bGVkLmMgYi9kcml2ZXJzL3Zp ZGVvL2JhY2tsaWdodC9xY29tLXdsZWQuYwo+IGluZGV4IDNiYzc4MDBlYjBhOS4uMDkxZjA3ZTdj MTQ1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L3Fjb20td2xlZC5jCj4g KysrIGIvZHJpdmVycy92aWRlby9iYWNrbGlnaHQvcWNvbS13bGVkLmMKPiBAQCAtMTY5Miw3ICsx NjkyLDcgQEAgc3RhdGljIGludCB3bGVkX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBk ZXYpCj4gIAo+ICBzdGF0aWMgaW50IHdsZWRfcmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2Ug KnBkZXYpCj4gIHsKPiAtCXN0cnVjdCB3bGVkICp3bGVkID0gZGV2X2dldF9kcnZkYXRhKCZwZGV2 LT5kZXYpOwo+ICsJc3RydWN0IHdsZWQgKndsZWQgPSBwbGF0Zm9ybV9nZXRfZHJ2ZGF0YShwZGV2 KTsKPiAgCj4gIAltdXRleF9kZXN0cm95KCZ3bGVkLT5sb2NrKTsKPiAgCWNhbmNlbF9kZWxheWVk X3dvcmtfc3luYygmd2xlZC0+b3ZwX3dvcmspOwoKRm9yIG15IG93biByZWZlcmVuY2UgKGFwcGx5 IHRoaXMgYXMtaXMgdG8geW91ciBzaWduLW9mZiBibG9jayk6CgogIEFja2VkLWZvci1CYWNrbGln aHQtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+CgotLSAKTGVlIEpvbmVzIFvm nY7nkLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVhZCAtIERldmVsb3BlciBTZXJ2aWNlcwpMaW5h cm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExpbmFy bzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55C5AC433E0 for ; Wed, 10 Feb 2021 08:23:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8D2360231 for ; Wed, 10 Feb 2021 08:23:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8D2360231 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 184CE6E99B; Wed, 10 Feb 2021 08:23:47 +0000 (UTC) Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6B3D76E99B for ; Wed, 10 Feb 2021 08:23:45 +0000 (UTC) Received: by mail-wr1-x433.google.com with SMTP id g10so1481809wrx.1 for ; Wed, 10 Feb 2021 00:23:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=MJzRoK5AHHgr8V25vpyceNTWmZxiFyKsyjhqQm8Vxxc=; b=d/b3ponHrtEaGh9+nR4CHVGjqOHtnpraE5raOOOMutWd3Y/vW/uw1i/PmwjfcCAOlI hSBPogoT7cAULj0g3PmoKbO+SoDAWMPSOECHnT1Hf4DW/HG3NgCZs5Oz4yycpbsGpbXz 6aDc3GNQtnk1ZzXHSwQCVv4LOVj0FL2tcZrnkEKPH22CeUw6azGEwO6gqPhOeo/UTzC8 CAGMYMu0CibvYCRJgy2fuPg3TqVZbhGt5gHufNtUof0Gw0FDR3KgWX5KWtTvRU2bJCB3 6J8LXoac3H1R5/6ZWZ8wIHim0sOUZG312tHezmcG2vA/YZDFQNq2NLrC7BlZj/TPwF8d LG7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=MJzRoK5AHHgr8V25vpyceNTWmZxiFyKsyjhqQm8Vxxc=; b=LXqHDxguHICpr9CQSzOlw3iiWmlWlprRy3yBp6mbkQcgkJ1gAVSMEy3mETfhAsgWT9 qrXhLGgnU/xh5yYz/a7ogeoCqC9JDSZ7l5HzS+0ZFqSKSEuFyzYb4K1ZGu83uP/S0v0J 0+CMOuobNhr6VqTdLK6y6xdLAu30FzXxXB8KsKLMm15GqEij7Yf7HrW4Ew8LcP+OwpAU jaQjwBmSO8L17jmBUXTkagZwuEQgtzbNMkf2aRqTHxcDsWL2zU8LnA4I7NvXzyY21B2b EZsQSfX108Hfu5oieYWVa0v0PkJRU3IOIwAgRZ52wwEgVk+vUqxrEUqIQSZ5u2gwMM+I 5bpw== X-Gm-Message-State: AOAM532xPqCRd/CjBco3FaGyBxaGX5btdfsdtuwa10Vc6Ah/+fGoD5d8 FaUWkjf6gjFOthM8AO6nKjwhvg== X-Google-Smtp-Source: ABdhPJzpmLKGtf/B7RhbJlQwrCAP0Mb8Tyioqci54O7y0v57o4U82PROFirmSWr5+lJk79X2A0kouQ== X-Received: by 2002:a05:6000:2cf:: with SMTP id o15mr2236419wry.184.1612945423966; Wed, 10 Feb 2021 00:23:43 -0800 (PST) Received: from dell ([91.110.221.237]) by smtp.gmail.com with ESMTPSA id h9sm1850897wrc.94.2021.02.10.00.23.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 00:23:43 -0800 (PST) Date: Wed, 10 Feb 2021 08:23:41 +0000 From: Lee Jones To: Julia Lawall Subject: Re: [PATCH] video: use getter/setter functions Message-ID: <20210210082341.GH220368@dell> References: <20210209211325.1261842-1-Julia.Lawall@inria.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210209211325.1261842-1-Julia.Lawall@inria.fr> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Thompson , linux-kernel@vger.kernel.org, Pengutronix Kernel Team , Jingoo Han , Sascha Hauer , kernel-janitors@vger.kernel.org, Michal Simek , dri-devel@lists.freedesktop.org, Bjorn Andersson , Andy Gross , NXP Linux Team , linux-fbdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, Shawn Guo , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVHVlLCAwOSBGZWIgMjAyMSwgSnVsaWEgTGF3YWxsIHdyb3RlOgoKPiBVc2UgZ2V0dGVyIGFu ZCBzZXR0ZXIgZnVuY3Rpb25zLCBmb3IgcGxhdGZvcm1fZGV2aWNlIHN0cnVjdHVyZXMgYW5kIGEK PiBzcGlfZGV2aWNlIHN0cnVjdHVyZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBKdWxpYSBMYXdhbGwg PEp1bGlhLkxhd2FsbEBpbnJpYS5mcj4KPiAKPiAtLS0KPiAgZHJpdmVycy92aWRlby9iYWNrbGln aHQvcWNvbS13bGVkLmMgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgICAyICst CgpUaGlzIHBhdGNoIGlzIGZpbmUuCgpDb3VsZCB5b3UgcGxlYXNlIHNwbGl0IGl0IG91dCBhbmQg c3VibWl0IGl0IHNlcGFyYXRlbHkgdGhvdWdoIHBsZWFzZS4KCj4gIGRyaXZlcnMvdmlkZW8vZmJk ZXYvYW1pZmIuYyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAg NCArKy0tCj4gIGRyaXZlcnMvdmlkZW8vZmJkZXYvZGE4eHgtZmIuYyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHwgICAgNCArKy0tCj4gIGRyaXZlcnMvdmlkZW8vZmJkZXYv aW14ZmIuYyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgMiAr LQo+ICBkcml2ZXJzL3ZpZGVvL2ZiZGV2L29tYXAyL29tYXBmYi9kaXNwbGF5cy9wYW5lbC1sZ3Bo aWxpcHMtbGIwMzVxMDIuYyB8ICAgIDYgKysrLS0tCj4gIGRyaXZlcnMvdmlkZW8vZmJkZXYvb21h cDIvb21hcGZiL2Rzcy9kcGkuYyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgNCArKy0t Cj4gIGRyaXZlcnMvdmlkZW8vZmJkZXYvb21hcDIvb21hcGZiL2Rzcy9kc2kuYyAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgICAgNCArKy0tCj4gIGRyaXZlcnMvdmlkZW8vZmJkZXYvb21hcDIv b21hcGZiL2Rzcy9oZG1pNC5jICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgMiArLQo+ICBk cml2ZXJzL3ZpZGVvL2ZiZGV2L29tYXAyL29tYXBmYi9kc3MvaGRtaTUuYyAgICAgICAgICAgICAg ICAgICAgICAgICB8ICAgIDIgKy0KPiAgZHJpdmVycy92aWRlby9mYmRldi94aWxpbnhmYi5jICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgICAyICstCj4gIDEwIGZpbGVz IGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQoKLi4uXQoKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy92aWRlby9iYWNrbGlnaHQvcWNvbS13bGVkLmMgYi9kcml2ZXJzL3Zp ZGVvL2JhY2tsaWdodC9xY29tLXdsZWQuYwo+IGluZGV4IDNiYzc4MDBlYjBhOS4uMDkxZjA3ZTdj MTQ1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L3Fjb20td2xlZC5jCj4g KysrIGIvZHJpdmVycy92aWRlby9iYWNrbGlnaHQvcWNvbS13bGVkLmMKPiBAQCAtMTY5Miw3ICsx NjkyLDcgQEAgc3RhdGljIGludCB3bGVkX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBk ZXYpCj4gIAo+ICBzdGF0aWMgaW50IHdsZWRfcmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2Ug KnBkZXYpCj4gIHsKPiAtCXN0cnVjdCB3bGVkICp3bGVkID0gZGV2X2dldF9kcnZkYXRhKCZwZGV2 LT5kZXYpOwo+ICsJc3RydWN0IHdsZWQgKndsZWQgPSBwbGF0Zm9ybV9nZXRfZHJ2ZGF0YShwZGV2 KTsKPiAgCj4gIAltdXRleF9kZXN0cm95KCZ3bGVkLT5sb2NrKTsKPiAgCWNhbmNlbF9kZWxheWVk X3dvcmtfc3luYygmd2xlZC0+b3ZwX3dvcmspOwoKRm9yIG15IG93biByZWZlcmVuY2UgKGFwcGx5 IHRoaXMgYXMtaXMgdG8geW91ciBzaWduLW9mZiBibG9jayk6CgogIEFja2VkLWZvci1CYWNrbGln aHQtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+CgotLSAKTGVlIEpvbmVzIFvm nY7nkLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVhZCAtIERldmVsb3BlciBTZXJ2aWNlcwpMaW5h cm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExpbmFy bzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK