From: Oscar Salvador <osalvador@suse.de>
To: Dave Hansen <dave.hansen@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
ben.widawsky@intel.com, cl@linux.com, alex.shi@linux.alibaba.com,
tobin@kernel.org, akpm@linux-foundation.org,
ying.huang@intel.com, dan.j.williams@intel.com, cai@lca.pw,
dwagner@suse.de
Subject: Re: [RFC][PATCH 03/13] mm/vmscan: replace implicit RECLAIM_ZONE checks with explicit checks
Date: Wed, 10 Feb 2021 10:54:37 +0100 [thread overview]
Message-ID: <20210210095437.GC27173@linux> (raw)
In-Reply-To: <20210126003417.72B4BCFB@viggo.jf.intel.com>
On Mon, Jan 25, 2021 at 04:34:17PM -0800, Dave Hansen wrote:
>
> From: Dave Hansen <dave.hansen@linux.intel.com>
>
> RECLAIM_ZONE was assumed to be unused because it was never explicitly
> used in the kernel. However, there were a number of places where it
> was checked implicitly by checking 'node_reclaim_mode' for a zero
> value.
>
> These zero checks are not great because it is not obvious what a zero
> mode *means* in the code. Replace them with a helper which makes it
> more obvious: node_reclaim_enabled().
>
> This helper also provides a handy place to explicitly check the
> RECLAIM_ZONE bit itself. Check it explicitly there to make it more
> obvious where the bit can affect behavior.
>
> This should have no functional impact.
>
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
> Reviewed-by: Ben Widawsky <ben.widawsky@intel.com>
> Acked-by: Christoph Lameter <cl@linux.com>
> Cc: Alex Shi <alex.shi@linux.alibaba.com>
> Cc: "Tobin C. Harding" <tobin@kernel.org>
> Cc: Christoph Lameter <cl@linux.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Huang Ying <ying.huang@intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Qian Cai <cai@lca.pw>
> Cc: Daniel Wagner <dwagner@suse.de>
> Cc: osalvador <osalvador@suse.de>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2021-02-10 9:54 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 0:34 [RFC][PATCH 00/13] [v5] Migrate Pages in lieu of discard Dave Hansen
2021-01-26 0:34 ` Dave Hansen
2021-01-26 0:34 ` [RFC][PATCH 01/13] mm/vmscan: restore zone_reclaim_mode ABI Dave Hansen
2021-01-26 0:34 ` Dave Hansen
2021-02-10 9:42 ` Oscar Salvador
2021-01-26 0:34 ` [RFC][PATCH 02/13] mm/vmscan: move RECLAIM* bits to uapi header Dave Hansen
2021-01-26 0:34 ` Dave Hansen
2021-02-10 9:44 ` Oscar Salvador
2021-01-26 0:34 ` [RFC][PATCH 03/13] mm/vmscan: replace implicit RECLAIM_ZONE checks with explicit checks Dave Hansen
2021-01-26 0:34 ` Dave Hansen
2021-01-31 1:10 ` David Rientjes
2021-02-10 9:54 ` Oscar Salvador [this message]
2021-01-26 0:34 ` [RFC][PATCH 04/13] mm/numa: node demotion data structure and lookup Dave Hansen
2021-01-26 0:34 ` Dave Hansen
2021-01-31 1:19 ` David Rientjes
2021-02-01 17:49 ` Dave Hansen
2021-01-26 0:34 ` [RFC][PATCH 05/13] mm/numa: automatically generate node migration order Dave Hansen
2021-01-26 0:34 ` Dave Hansen
2021-01-29 20:46 ` Yang Shi
2021-02-01 19:13 ` Dave Hansen
2021-02-02 11:43 ` Oscar Salvador
2021-02-02 17:46 ` Yang Shi
2021-02-03 0:43 ` Dave Hansen
2021-02-04 0:26 ` Yang Shi
2021-01-26 0:34 ` [RFC][PATCH 06/13] mm/migrate: update migration order during on hotplug events Dave Hansen
2021-01-26 0:34 ` Dave Hansen
2021-01-29 20:59 ` Yang Shi
2021-02-02 11:42 ` Oscar Salvador
2021-02-09 23:45 ` Dave Hansen
2021-02-10 8:55 ` Oscar Salvador
2021-01-26 0:34 ` [RFC][PATCH 07/13] mm/migrate: make migrate_pages() return nr_succeeded Dave Hansen
2021-01-26 0:34 ` Dave Hansen
2021-01-29 21:04 ` Yang Shi
2021-02-09 23:41 ` Dave Hansen
2021-01-26 0:34 ` [RFC][PATCH 08/13] mm/migrate: demote pages during reclaim Dave Hansen
2021-01-26 0:34 ` Dave Hansen
2021-02-02 11:55 ` Oscar Salvador
2021-02-02 22:45 ` Yang Shi
2021-02-02 22:56 ` Dave Hansen
2021-02-02 18:22 ` Yang Shi
2021-02-02 18:34 ` Dave Hansen
2021-01-26 0:34 ` [RFC][PATCH 09/13] mm/vmscan: add page demotion counter Dave Hansen
2021-01-26 0:34 ` Dave Hansen
2021-01-26 0:34 ` [RFC][PATCH 10/13] mm/vmscan: add helper for querying ability to age anonymous pages Dave Hansen
2021-01-26 0:34 ` Dave Hansen
2021-01-26 0:34 ` [RFC][PATCH 11/13] mm/vmscan: Consider anonymous pages without swap Dave Hansen
2021-01-26 0:34 ` Dave Hansen
2021-02-02 18:56 ` Yang Shi
2021-02-02 21:35 ` Dave Hansen
2021-02-02 22:35 ` Yang Shi
2021-01-26 0:34 ` [RFC][PATCH 12/13] mm/vmscan: never demote for memcg reclaim Dave Hansen
2021-01-26 0:34 ` Dave Hansen
2021-01-26 0:34 ` [RFC][PATCH 13/13] mm/migrate: new zone_reclaim_mode to enable reclaim migration Dave Hansen
2021-01-26 0:34 ` Dave Hansen
2021-01-31 1:13 ` [RFC][PATCH 00/13] [v5] Migrate Pages in lieu of discard David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210095437.GC27173@linux \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@linux.alibaba.com \
--cc=ben.widawsky@intel.com \
--cc=cai@lca.pw \
--cc=cl@linux.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dwagner@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tobin@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.