From: Olaf Hering <olaf@aepfle.de>
To: Ian Jackson <iwj@xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: [PATCH v20210209 4/4] xl: disable --debug option for xl migrate
Date: Wed, 10 Feb 2021 10:06:06 +0100 [thread overview]
Message-ID: <20210210100606.45de7991.olaf@aepfle.de> (raw)
In-Reply-To: <24610.49788.493621.307069@mariner.uk.xensource.com>
[-- Attachment #1: Type: text/plain, Size: 915 bytes --]
Am Tue, 9 Feb 2021 17:12:28 +0000
schrieb Ian Jackson <iwj@xenproject.org>:
> It seems to me that something is definitely a bug here but I want to
> understand from Andy what the best thing to do is. I'm hesitant to
> release-ack removing this at this stage.
>
> Wouldn't it be better to just fix the docs like in your previously
> suggested patch ?
To make that initial patch accurate, this additional change is required:
--- a/tools/libs/guest/xg_sr_save.c
+++ b/tools/libs/guest/xg_sr_save.c
@@ -752,7 +752,7 @@ static int send_domain_memory_live(struct xc_sr_context *ctx)
if ( rc )
goto out;
- if ( ctx->save.debug && ctx->stream_type != XC_STREAM_PLAIN )
+ if ( ctx->save.debug )
{
rc = verify_frames(ctx);
if ( rc )
Otherwise there is no way for "xl" to trigger a call into verify_frames.
I will test this patch today.
Olaf
[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-02-10 9:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 15:45 [PATCH v20210209 0/4] tools changes Olaf Hering
2021-02-09 15:45 ` [PATCH v20210209 1/4] tools: move CONFIG_DIR and XEN_CONFIG_DIR in paths.m4 Olaf Hering
2021-02-09 16:48 ` Ian Jackson
2021-02-09 15:45 ` [PATCH v20210209 2/4] tools: add with-xen-scriptdir configure option Olaf Hering
2021-02-09 16:49 ` Ian Jackson
2021-02-09 15:45 ` [PATCH v20210209 3/4] xl: optionally print timestamps when running xl commands Olaf Hering
2021-02-09 16:53 ` Ian Jackson
2021-02-09 17:06 ` Olaf Hering
2021-02-09 17:16 ` Ian Jackson
2021-02-09 15:45 ` [PATCH v20210209 4/4] xl: disable --debug option for xl migrate Olaf Hering
2021-02-09 17:12 ` Ian Jackson
2021-02-09 17:16 ` Olaf Hering
2021-02-10 9:06 ` Olaf Hering [this message]
2021-02-10 9:44 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210100606.45de7991.olaf@aepfle.de \
--to=olaf@aepfle.de \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=iwj@xenproject.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.