Re: [PATCH v2 5/5] ext4: add proc files to monitor new structures

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3620 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210209202857.4185846-6-harshadshirwadkar@gmail.com>
References: <20210209202857.4185846-6-harshadshirwadkar@gmail.com>
TO: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
TO: linux-ext4(a)vger.kernel.org
CC: tytso(a)mit.edu
CC: bzzz(a)whamcloud.com
CC: artem.blagodarenko(a)gmail.com
CC: sihara(a)ddn.com
CC: adilger(a)dilger.ca
CC: Harshad Shirwadkar <harshadshirwadkar@gmail.com>

Hi Harshad,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on ext4/dev]
[also build test WARNING on v5.11-rc7 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Harshad-Shirwadkar/ext4-drop-s_mb_bal_lock-and-convert-protected-fields-to-atomic/20210210-054647
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
:::::: branch date: 10 hours ago
:::::: commit date: 10 hours ago
config: x86_64-randconfig-s021-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-215-g0fb77bb6-dirty
        # https://github.com/0day-ci/linux/commit/51dc3ee0ba379809b113ad2bd596888e8b55b534
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Harshad-Shirwadkar/ext4-drop-s_mb_bal_lock-and-convert-protected-fields-to-atomic/20210210-054647
        git checkout 51dc3ee0ba379809b113ad2bd596888e8b55b534
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
   fs/ext4/mballoc.c:2460:9: sparse: sparse: context imbalance in 'ext4_mb_good_group_nolock' - different lock contexts for basic block
>> fs/ext4/mballoc.c:2867:13: sparse: sparse: context imbalance in 'ext4_mb_seq_structs_summary_start' - wrong count at exit
   fs/ext4/mballoc.c:2937:13: sparse: sparse: context imbalance in 'ext4_mb_seq_structs_summary_stop' - unexpected unlock

vim +/ext4_mb_seq_structs_summary_start +2867 fs/ext4/mballoc.c

251fb84975e8df Harshad Shirwadkar 2021-02-09  2866  
51dc3ee0ba3798 Harshad Shirwadkar 2021-02-09 @2867  static void *ext4_mb_seq_structs_summary_start(struct seq_file *seq, loff_t *pos)
51dc3ee0ba3798 Harshad Shirwadkar 2021-02-09  2868  {
51dc3ee0ba3798 Harshad Shirwadkar 2021-02-09  2869  	struct super_block *sb = PDE_DATA(file_inode(seq->file));
51dc3ee0ba3798 Harshad Shirwadkar 2021-02-09  2870  	unsigned long position;
51dc3ee0ba3798 Harshad Shirwadkar 2021-02-09  2871  
51dc3ee0ba3798 Harshad Shirwadkar 2021-02-09  2872  	read_lock(&EXT4_SB(sb)->s_mb_rb_lock);
51dc3ee0ba3798 Harshad Shirwadkar 2021-02-09  2873  
51dc3ee0ba3798 Harshad Shirwadkar 2021-02-09  2874  	if (*pos < 0 || *pos >= MB_NUM_ORDERS(sb) + 1)
51dc3ee0ba3798 Harshad Shirwadkar 2021-02-09  2875  		return NULL;
51dc3ee0ba3798 Harshad Shirwadkar 2021-02-09  2876  	position = *pos + 1;
51dc3ee0ba3798 Harshad Shirwadkar 2021-02-09  2877  	return (void *) ((unsigned long) position);
51dc3ee0ba3798 Harshad Shirwadkar 2021-02-09  2878  }
51dc3ee0ba3798 Harshad Shirwadkar 2021-02-09  2879  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39006 bytes --]