From: Keith Busch <kbusch@kernel.org>
To: linux-pci@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>
Cc: Keith Busch <kbusch@kernel.org>
Subject: [PATCH] PCI/ERR: Fix state assignment
Date: Wed, 10 Feb 2021 07:16:04 -0800 [thread overview]
Message-ID: <20210210151604.2678236-1-kbusch@kernel.org> (raw)
The state was intended to be assigned rather than compared for equality.
Link: https://lore.kernel.org/linux-pci/202102101255.HZtDITwe-lkp@intel.com/
Fixes: 8fae7d8809b815148 ("PCI/ERR: Simplify pci_dev_set_io_state()")
Cc: Bjorn Helgass <helgaas@kernel.org>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
drivers/pci/pci.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
index db267120c962..1e4e4cb48bab 100644
--- a/drivers/pci/pci.h
+++ b/drivers/pci/pci.h
@@ -345,7 +345,7 @@ static inline bool pci_dev_set_io_state(struct pci_dev *dev,
/* Can always put a device in perm_failure state */
if (new == pci_channel_io_perm_failure) {
- dev->error_state == pci_channel_io_perm_failure;
+ dev->error_state = pci_channel_io_perm_failure;
return true;
}
--
2.25.4
next reply other threads:[~2021-02-10 15:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 15:16 Keith Busch [this message]
2021-02-10 16:14 ` [PATCH] PCI/ERR: Fix state assignment Krzysztof Wilczyński
2021-02-10 16:59 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210151604.2678236-1-kbusch@kernel.org \
--to=kbusch@kernel.org \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.