From: Igor Mammedov <imammedo@redhat.com>
To: Wang Xingang <wangxingang5@huawei.com>
Cc: xieyingtai@huawei.com, Peter Maydell <peter.maydell@linaro.org>,
cenjiahui@huawei.com, mst@redhat.com, Drew <drjones@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH 2/3] acpi/gpex: Fix cca attribute check for pxb device
Date: Wed, 10 Feb 2021 15:24:59 +0100 [thread overview]
Message-ID: <20210210152459.39b08d34@redhat.com> (raw)
In-Reply-To: <1612490205-48788-3-git-send-email-wangxingang5@huawei.com>
On Fri, 5 Feb 2021 01:56:44 +0000
Wang Xingang <wangxingang5@huawei.com> wrote:
> From: Xingang Wang <wangxingang5@huawei.com>
>
> When check DMA support for device attached to pxb,
> the cache coherency attribute need to be set.
> This add _CCA attribute for pxb DSDT.
>
> Fixes: 6f9765fbad ("acpi/gpex: Build tables for pxb")
>
> Signed-off-by: Jiahui Cen <cenjiahui@huawei.com>
> Signed-off-by: Xingang Wang <wangxingang5@huawei.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
I'm not sure about if ARM side if fine with the change, CCed.
> ---
> hw/pci-host/gpex-acpi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/pci-host/gpex-acpi.c b/hw/pci-host/gpex-acpi.c
> index 446912d771..0f01f13a6e 100644
> --- a/hw/pci-host/gpex-acpi.c
> +++ b/hw/pci-host/gpex-acpi.c
> @@ -175,6 +175,7 @@ void acpi_dsdt_add_gpex(Aml *scope, struct GPEXConfig *cfg)
> aml_append(dev, aml_name_decl("_BBN", aml_int(bus_num)));
> aml_append(dev, aml_name_decl("_UID", aml_int(bus_num)));
> aml_append(dev, aml_name_decl("_STR", aml_unicode("pxb Device")));
> + aml_append(dev, aml_name_decl("_CCA", aml_int(1)));
> if (numa_node != NUMA_NODE_UNASSIGNED) {
> aml_append(dev, aml_name_decl("_PXM", aml_int(numa_node)));
> }
next prev parent reply other threads:[~2021-02-10 14:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 1:56 [PATCH 0/3] acpi: Add _CCA support for pxb devices Wang Xingang
2021-02-05 1:56 ` [PATCH 1/3] acpi: Allow pxb DSDT acpi table changes Wang Xingang
2021-02-10 14:22 ` Igor Mammedov
2021-02-05 1:56 ` [PATCH 2/3] acpi/gpex: Fix cca attribute check for pxb device Wang Xingang
2021-02-10 14:24 ` Igor Mammedov [this message]
2021-02-05 1:56 ` [PATCH 3/3] acpi: Update _CCA attribute in DSDT.pxb Wang Xingang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210152459.39b08d34@redhat.com \
--to=imammedo@redhat.com \
--cc=cenjiahui@huawei.com \
--cc=drjones@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=wangxingang5@huawei.com \
--cc=xieyingtai@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.