From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH RFC 4/6] btrfs: Check if the filesystem is has mixed type of devices
Date: Wed, 10 Feb 2021 16:03:34 +0800 [thread overview]
Message-ID: <202102101536.Ry8iZJzs-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4043 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210209203041.21493-5-mrostecki@suse.de>
References: <20210209203041.21493-5-mrostecki@suse.de>
TO: Michal Rostecki <mrostecki@suse.de>
Hi Michal,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on v5.11-rc7]
[also build test WARNING on next-20210125]
[cannot apply to kdave/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Michal-Rostecki/Add-roundrobin-raid1-read-policy/20210210-053511
base: 92bf22614b21a2706f4993b278017e437f7785b3
:::::: branch date: 10 hours ago
:::::: commit date: 10 hours ago
config: i386-randconfig-m021-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
fs/btrfs/volumes.c:635 btrfs_check_mixed() error: uninitialized symbol 'prev_device'.
Old smatch warnings:
fs/btrfs/volumes.c:1264 open_fs_devices() error: we previously assumed 'latest_dev' could be null (see line 1252)
fs/btrfs/volumes.h:218 btrfs_device_set_total_bytes() warn: statement has no effect 31
fs/btrfs/volumes.h:219 btrfs_device_set_disk_total_bytes() warn: statement has no effect 31
fs/btrfs/volumes.h:220 btrfs_device_set_bytes_used() warn: statement has no effect 31
vim +/prev_device +635 fs/btrfs/volumes.c
4fde46f0cc71c7 Anand Jain 2015-06-17 619
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 620 /*
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 621 * Checks if after adding the new device the filesystem is going to have mixed
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 622 * types of devices (non-rotational and rotational).
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 623 *
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 624 * @fs_devices: list of devices
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 625 * @new_device_rotating: if the new device is rotational
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 626 *
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 627 * Returns true if there are mixed types of devices, otherwise returns false.
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 628 */
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 629 static bool btrfs_check_mixed(struct btrfs_fs_devices *fs_devices,
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 630 bool new_device_rotating)
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 631 {
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 632 struct btrfs_device *device, *prev_device;
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 633
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 634 list_for_each_entry(device, &fs_devices->devices, dev_list) {
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 @635 if (prev_device == NULL &&
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 636 device->rotating != new_device_rotating)
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 637 return true;
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 638 if (prev_device != NULL &&
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 639 (device->rotating != prev_device->rotating ||
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 640 device->rotating != new_device_rotating))
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 641 return true;
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 642
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 643 prev_device = device;
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 644 }
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 645
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 646 return false;
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 647 }
bd7608b9a9bbf6 Michal Rostecki 2021-02-09 648
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37174 bytes --]
next reply other threads:[~2021-02-10 8:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 8:03 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-02-09 20:30 [PATCH RFC 0/6] Add roundrobin raid1 read policy Michal Rostecki
2021-02-09 20:30 ` [PATCH RFC 4/6] btrfs: Check if the filesystem is has mixed type of devices Michal Rostecki
2021-02-10 4:08 ` Michał Mirosław
2021-02-10 12:50 ` Michal Rostecki
2021-02-12 18:26 ` Michal Rostecki
2021-02-12 23:36 ` Michał Mirosław
2021-02-15 14:40 ` Michal Rostecki
2021-02-10 8:09 ` Dan Carpenter
2021-02-10 8:09 ` Dan Carpenter
2021-02-10 10:09 ` Filipe Manana
2021-02-10 12:55 ` Michal Rostecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202102101536.Ry8iZJzs-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.