From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Wed, 10 Feb 2021 16:12:58 +0000 Subject: Re: [PATCH] video: use getter/setter functions Message-Id: <20210210161258.GA124276@x1> List-Id: References: <20210209211325.1261842-1-Julia.Lawall@inria.fr> <20210210082341.GH220368@dell> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Julia Lawall , Daniel Thompson , linux-kernel@vger.kernel.org, Pengutronix Kernel Team , Jingoo Han , Sascha Hauer , kernel-janitors@vger.kernel.org, Michal Simek , dri-devel@lists.freedesktop.org, Bjorn Andersson , Andy Gross , NXP Linux Team , linux-fbdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, Shawn Guo , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org On Wed, 10 Feb 2021, Daniel Vetter wrote: > On Wed, Feb 10, 2021 at 08:23:41AM +0000, Lee Jones wrote: > > On Tue, 09 Feb 2021, Julia Lawall wrote: > > > > > Use getter and setter functions, for platform_device structures and a > > > spi_device structure. > > > > > > Signed-off-by: Julia Lawall > > > > > > --- > > > drivers/video/backlight/qcom-wled.c | 2 +- > > > > This patch is fine. > > > > Could you please split it out and submit it separately though please. > > Or just apply the entire patch through backlight tree, there's nothing > going on in fbdev anyway I think. > > Acked-by: Daniel Vetter I can do that. Is that an fbdev Ack? > > > drivers/video/fbdev/amifb.c | 4 ++-- > > > drivers/video/fbdev/da8xx-fb.c | 4 ++-- > > > drivers/video/fbdev/imxfb.c | 2 +- > > > drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c | 6 +++--- > > > drivers/video/fbdev/omap2/omapfb/dss/dpi.c | 4 ++-- > > > drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 4 ++-- > > > drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c | 2 +- > > > drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c | 2 +- > > > drivers/video/fbdev/xilinxfb.c | 2 +- > > > 10 files changed, 16 insertions(+), 16 deletions(-) > > > > ...] > > > > > diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c > > > index 3bc7800eb0a9..091f07e7c145 100644 > > > --- a/drivers/video/backlight/qcom-wled.c > > > +++ b/drivers/video/backlight/qcom-wled.c > > > @@ -1692,7 +1692,7 @@ static int wled_probe(struct platform_device *pdev) > > > > > > static int wled_remove(struct platform_device *pdev) > > > { > > > - struct wled *wled = dev_get_drvdata(&pdev->dev); > > > + struct wled *wled = platform_get_drvdata(pdev); > > > > > > mutex_destroy(&wled->lock); > > > cancel_delayed_work_sync(&wled->ovp_work); > > > > For my own reference (apply this as-is to your sign-off block): > > > > Acked-for-Backlight-by: Lee Jones > > > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E3CAC433DB for ; Wed, 10 Feb 2021 16:14:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BEA5264E76 for ; Wed, 10 Feb 2021 16:14:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BEA5264E76 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=98MEWlnFntobfl6kux/OhxaFQBsSNwnzbcFCRblejCE=; b=HX8LC2guE6DubRljaw7dTNbi61 PpfDGi+c7E9PJijLkfnFccfQw8nPKExy+FWpzCHYQn8k1Nj8PJlsPw776AaF9hq1cYAxvgNJn4u7A XkXa/mL3y9vuV2DG/xk4Po4ElsChYAtRTUXRjkL/AoqijzBUem28iWBrg7Sdno6mwPDPSmdKeStYn +STap4so5QT6tK8ZMJ6o7cbUGLTOJtX7g6s4XSus/WAHQ+SJYNFn/6HI9f6u7qZrL4HhcbZGZb6YR dyKmu4uI++eglyrZozMxRmNRnsfl3+tnAqZ4uaHIDObszWSrpDWKa3kswujffZzPARc8VuyhzpE4p rQ8nsAkA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9s71-0005m9-KY; Wed, 10 Feb 2021 16:13:07 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9s6z-0005kr-6F for linux-arm-kernel@lists.infradead.org; Wed, 10 Feb 2021 16:13:06 +0000 Received: by mail-wm1-x32b.google.com with SMTP id l17so717520wmq.2 for ; Wed, 10 Feb 2021 08:13:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=9EqkICeAqFea9hutcJE8LTJk6fkCLGfHmOvQQmMvAJM=; b=Hh49I+GceO/gmkekotuymhn3rjlU3YIypVisjoLOygTP1mgYBpzmbiY1B+Z5kDHv1H X+1p+H/pZbOPlldO65mL33J/nmB6ms47MC+u60d9S34oT4MiRfwDpZZWh/qETmt/Om/y olUsvQGKt/zp/HREvWDezf3EVhY9WQSBDq//vrYo+RtlXuw1teA/flfEzF4rT2UCYUo6 WEyPCuv9rP7JAXB7hd4Zk5CXQfiPo2bj7YDV4C/V4SfKbO6gG7O8nWSxiVamK32i6r03 Vi1DcAM4Whf1JnAWKjVWawTmQnF73oyA7TPneeQ1mIDpdIwY/evQfcTuEdgRAkLg3tZr f/6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=9EqkICeAqFea9hutcJE8LTJk6fkCLGfHmOvQQmMvAJM=; b=N77tYvRs320N/51WFR4UQJr/vWMTDeT5uq3QznZtXqrHYKAH9+6RrJCEyyjAR2T7SR UzFhi+L2GjTQKkwHWuHQLD6uYPFh+CqSnbHwrvGFJKV0AwsRycuM/Xud6RK8cKS0cUpF X5k2Mf91cxdmCBzrDwGxffHUMtNCc+OEuAcDQKmDhH7syZQVIl90DbJfmiDKRnzInv4h Ipsvhq2+zW4mVL0wRvn2L9OFywivERD0qb/+8rJCTrp+KMbP7LN79DXZYdeoXkkpBDzN dG+6ZxjXMnmawV+Kz5sRbaInwhqrStONftjxnNlodoyalRLBrjli/TYXjqd8lcyBbO61 WyUA== X-Gm-Message-State: AOAM531+9NNNr9Y3PfoqVpisC5bFtBXTIFNupNnEBhOnTQWETloc7dAY +yHMO1RlRjtlKwQMuizeimblYQ== X-Google-Smtp-Source: ABdhPJxwjN9tnOjYE29ii/KagRZk+egL7JyD+GF9hT3oJWkCY7DOqROK+nqMjm3eItHTGs95G9LYOA== X-Received: by 2002:a05:600c:216:: with SMTP id 22mr3432179wmi.111.1612973581930; Wed, 10 Feb 2021 08:13:01 -0800 (PST) Received: from x1 ([91.110.221.237]) by smtp.gmail.com with ESMTPSA id x9sm3275333wmb.14.2021.02.10.08.12.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 08:13:00 -0800 (PST) Date: Wed, 10 Feb 2021 16:12:58 +0000 From: Lee Jones To: Julia Lawall , Daniel Thompson , linux-kernel@vger.kernel.org, Pengutronix Kernel Team , Jingoo Han , Sascha Hauer , kernel-janitors@vger.kernel.org, Michal Simek , dri-devel@lists.freedesktop.org, Bjorn Andersson , Andy Gross , NXP Linux Team , linux-fbdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, Shawn Guo , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] video: use getter/setter functions Message-ID: <20210210161258.GA124276@x1> References: <20210209211325.1261842-1-Julia.Lawall@inria.fr> <20210210082341.GH220368@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210210_111305_540987_F6EDBFD8 X-CRM114-Status: GOOD ( 22.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAxMCBGZWIgMjAyMSwgRGFuaWVsIFZldHRlciB3cm90ZToKCj4gT24gV2VkLCBGZWIg MTAsIDIwMjEgYXQgMDg6MjM6NDFBTSArMDAwMCwgTGVlIEpvbmVzIHdyb3RlOgo+ID4gT24gVHVl LCAwOSBGZWIgMjAyMSwgSnVsaWEgTGF3YWxsIHdyb3RlOgo+ID4gCj4gPiA+IFVzZSBnZXR0ZXIg YW5kIHNldHRlciBmdW5jdGlvbnMsIGZvciBwbGF0Zm9ybV9kZXZpY2Ugc3RydWN0dXJlcyBhbmQg YQo+ID4gPiBzcGlfZGV2aWNlIHN0cnVjdHVyZS4KPiA+ID4gCj4gPiA+IFNpZ25lZC1vZmYtYnk6 IEp1bGlhIExhd2FsbCA8SnVsaWEuTGF3YWxsQGlucmlhLmZyPgo+ID4gPiAKPiA+ID4gLS0tCj4g PiA+ICBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9xY29tLXdsZWQuYyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB8ICAgIDIgKy0KPiA+IAo+ID4gVGhpcyBwYXRjaCBpcyBmaW5lLgo+ ID4gCj4gPiBDb3VsZCB5b3UgcGxlYXNlIHNwbGl0IGl0IG91dCBhbmQgc3VibWl0IGl0IHNlcGFy YXRlbHkgdGhvdWdoIHBsZWFzZS4KPiAKPiBPciBqdXN0IGFwcGx5IHRoZSBlbnRpcmUgcGF0Y2gg dGhyb3VnaCBiYWNrbGlnaHQgdHJlZSwgdGhlcmUncyBub3RoaW5nCj4gZ29pbmcgb24gaW4gZmJk ZXYgYW55d2F5IEkgdGhpbmsuCj4gCj4gQWNrZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52 ZXR0ZXJAZmZ3bGwuY2g+CgpJIGNhbiBkbyB0aGF0LiAgSXMgdGhhdCBhbiBmYmRldiBBY2s/Cgo+ ID4gPiAgZHJpdmVycy92aWRlby9mYmRldi9hbWlmYi5jICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgfCAgICA0ICsrLS0KPiA+ID4gIGRyaXZlcnMvdmlkZW8vZmJkZXYv ZGE4eHgtZmIuYyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgNCAr Ky0tCj4gPiA+ICBkcml2ZXJzL3ZpZGVvL2ZiZGV2L2lteGZiLmMgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB8ICAgIDIgKy0KPiA+ID4gIGRyaXZlcnMvdmlkZW8vZmJk ZXYvb21hcDIvb21hcGZiL2Rpc3BsYXlzL3BhbmVsLWxncGhpbGlwcy1sYjAzNXEwMi5jIHwgICAg NiArKystLS0KPiA+ID4gIGRyaXZlcnMvdmlkZW8vZmJkZXYvb21hcDIvb21hcGZiL2Rzcy9kcGku YyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgNCArKy0tCj4gPiA+ICBkcml2ZXJzL3Zp ZGVvL2ZiZGV2L29tYXAyL29tYXBmYi9kc3MvZHNpLmMgICAgICAgICAgICAgICAgICAgICAgICAg ICB8ICAgIDQgKystLQo+ID4gPiAgZHJpdmVycy92aWRlby9mYmRldi9vbWFwMi9vbWFwZmIvZHNz L2hkbWk0LmMgICAgICAgICAgICAgICAgICAgICAgICAgfCAgICAyICstCj4gPiA+ICBkcml2ZXJz L3ZpZGVvL2ZiZGV2L29tYXAyL29tYXBmYi9kc3MvaGRtaTUuYyAgICAgICAgICAgICAgICAgICAg ICAgICB8ICAgIDIgKy0KPiA+ID4gIGRyaXZlcnMvdmlkZW8vZmJkZXYveGlsaW54ZmIuYyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgMiArLQo+ID4gPiAgMTAgZmls ZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pCj4gPiAKPiA+IC4u Ll0KPiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92aWRlby9iYWNrbGlnaHQvcWNvbS13 bGVkLmMgYi9kcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9xY29tLXdsZWQuYwo+ID4gPiBpbmRleCAz YmM3ODAwZWIwYTkuLjA5MWYwN2U3YzE0NSAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy92aWRl by9iYWNrbGlnaHQvcWNvbS13bGVkLmMKPiA+ID4gKysrIGIvZHJpdmVycy92aWRlby9iYWNrbGln aHQvcWNvbS13bGVkLmMKPiA+ID4gQEAgLTE2OTIsNyArMTY5Miw3IEBAIHN0YXRpYyBpbnQgd2xl ZF9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ID4gPiAgCj4gPiA+ICBzdGF0 aWMgaW50IHdsZWRfcmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gPiA+ICB7 Cj4gPiA+IC0Jc3RydWN0IHdsZWQgKndsZWQgPSBkZXZfZ2V0X2RydmRhdGEoJnBkZXYtPmRldik7 Cj4gPiA+ICsJc3RydWN0IHdsZWQgKndsZWQgPSBwbGF0Zm9ybV9nZXRfZHJ2ZGF0YShwZGV2KTsK PiA+ID4gIAo+ID4gPiAgCW11dGV4X2Rlc3Ryb3koJndsZWQtPmxvY2spOwo+ID4gPiAgCWNhbmNl bF9kZWxheWVkX3dvcmtfc3luYygmd2xlZC0+b3ZwX3dvcmspOwo+ID4gCj4gPiBGb3IgbXkgb3du IHJlZmVyZW5jZSAoYXBwbHkgdGhpcyBhcy1pcyB0byB5b3VyIHNpZ24tb2ZmIGJsb2NrKToKPiA+ IAo+ID4gICBBY2tlZC1mb3ItQmFja2xpZ2h0LWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5h cm8ub3JnPgo+ID4gCj4gCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmlj YWwgTGVhZCAtIERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBz b2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwg QmxvZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt YXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6515DC433E6 for ; Wed, 10 Feb 2021 16:13:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0482464E6B for ; Wed, 10 Feb 2021 16:13:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0482464E6B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 586726ECA6; Wed, 10 Feb 2021 16:13:04 +0000 (UTC) Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 441756ECA6 for ; Wed, 10 Feb 2021 16:13:03 +0000 (UTC) Received: by mail-wm1-x32d.google.com with SMTP id m1so2300741wml.2 for ; Wed, 10 Feb 2021 08:13:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=9EqkICeAqFea9hutcJE8LTJk6fkCLGfHmOvQQmMvAJM=; b=Hh49I+GceO/gmkekotuymhn3rjlU3YIypVisjoLOygTP1mgYBpzmbiY1B+Z5kDHv1H X+1p+H/pZbOPlldO65mL33J/nmB6ms47MC+u60d9S34oT4MiRfwDpZZWh/qETmt/Om/y olUsvQGKt/zp/HREvWDezf3EVhY9WQSBDq//vrYo+RtlXuw1teA/flfEzF4rT2UCYUo6 WEyPCuv9rP7JAXB7hd4Zk5CXQfiPo2bj7YDV4C/V4SfKbO6gG7O8nWSxiVamK32i6r03 Vi1DcAM4Whf1JnAWKjVWawTmQnF73oyA7TPneeQ1mIDpdIwY/evQfcTuEdgRAkLg3tZr f/6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=9EqkICeAqFea9hutcJE8LTJk6fkCLGfHmOvQQmMvAJM=; b=JCtezT0WGD6BlBnFRtO+y4yMF0PRm1BN37KOI/caG9Qk3NbMOYevWpd8s4t716RC8Y NMwe24WhQsIIGx8j/kUFU1kn3bU4cvMIV9j0YjZvxKlkNf8BnN+n6RzQQPD4+smLVmXu Y1MMQhWchP2lu8ai+hTvNcrXuDevRR/yJOwmcNpP3metEmSEw/27wRbAYJ5W9z3eIreP AVwTwXxFPKEKg65F99bDF01TJleNfFmAT4YR/hdO5J71MDmlyUoI9YZdTeKMlxat5TaO LzacQEEQNPjYBmtz6lp1VGeBrLCxL5bm488taGiL/pYzLXSlKj30ugvmhmq3xC6brN2b n6fA== X-Gm-Message-State: AOAM530xSQGhtZ3ih/URHGXQpmkCRBLPU6WtH2mB5Ehb5KUminCyyYA/ O/jdnMnl8tIV6ggKKcpmqan3ZmL/qyk4gA== X-Google-Smtp-Source: ABdhPJxwjN9tnOjYE29ii/KagRZk+egL7JyD+GF9hT3oJWkCY7DOqROK+nqMjm3eItHTGs95G9LYOA== X-Received: by 2002:a05:600c:216:: with SMTP id 22mr3432179wmi.111.1612973581930; Wed, 10 Feb 2021 08:13:01 -0800 (PST) Received: from x1 ([91.110.221.237]) by smtp.gmail.com with ESMTPSA id x9sm3275333wmb.14.2021.02.10.08.12.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 08:13:00 -0800 (PST) Date: Wed, 10 Feb 2021 16:12:58 +0000 From: Lee Jones To: Julia Lawall , Daniel Thompson , linux-kernel@vger.kernel.org, Pengutronix Kernel Team , Jingoo Han , Sascha Hauer , kernel-janitors@vger.kernel.org, Michal Simek , dri-devel@lists.freedesktop.org, Bjorn Andersson , Andy Gross , NXP Linux Team , linux-fbdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, Shawn Guo , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] video: use getter/setter functions Message-ID: <20210210161258.GA124276@x1> References: <20210209211325.1261842-1-Julia.Lawall@inria.fr> <20210210082341.GH220368@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gV2VkLCAxMCBGZWIgMjAyMSwgRGFuaWVsIFZldHRlciB3cm90ZToKCj4gT24gV2VkLCBGZWIg MTAsIDIwMjEgYXQgMDg6MjM6NDFBTSArMDAwMCwgTGVlIEpvbmVzIHdyb3RlOgo+ID4gT24gVHVl LCAwOSBGZWIgMjAyMSwgSnVsaWEgTGF3YWxsIHdyb3RlOgo+ID4gCj4gPiA+IFVzZSBnZXR0ZXIg YW5kIHNldHRlciBmdW5jdGlvbnMsIGZvciBwbGF0Zm9ybV9kZXZpY2Ugc3RydWN0dXJlcyBhbmQg YQo+ID4gPiBzcGlfZGV2aWNlIHN0cnVjdHVyZS4KPiA+ID4gCj4gPiA+IFNpZ25lZC1vZmYtYnk6 IEp1bGlhIExhd2FsbCA8SnVsaWEuTGF3YWxsQGlucmlhLmZyPgo+ID4gPiAKPiA+ID4gLS0tCj4g PiA+ICBkcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9xY29tLXdsZWQuYyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB8ICAgIDIgKy0KPiA+IAo+ID4gVGhpcyBwYXRjaCBpcyBmaW5lLgo+ ID4gCj4gPiBDb3VsZCB5b3UgcGxlYXNlIHNwbGl0IGl0IG91dCBhbmQgc3VibWl0IGl0IHNlcGFy YXRlbHkgdGhvdWdoIHBsZWFzZS4KPiAKPiBPciBqdXN0IGFwcGx5IHRoZSBlbnRpcmUgcGF0Y2gg dGhyb3VnaCBiYWNrbGlnaHQgdHJlZSwgdGhlcmUncyBub3RoaW5nCj4gZ29pbmcgb24gaW4gZmJk ZXYgYW55d2F5IEkgdGhpbmsuCj4gCj4gQWNrZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52 ZXR0ZXJAZmZ3bGwuY2g+CgpJIGNhbiBkbyB0aGF0LiAgSXMgdGhhdCBhbiBmYmRldiBBY2s/Cgo+ ID4gPiAgZHJpdmVycy92aWRlby9mYmRldi9hbWlmYi5jICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgfCAgICA0ICsrLS0KPiA+ID4gIGRyaXZlcnMvdmlkZW8vZmJkZXYv ZGE4eHgtZmIuYyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgNCAr Ky0tCj4gPiA+ICBkcml2ZXJzL3ZpZGVvL2ZiZGV2L2lteGZiLmMgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB8ICAgIDIgKy0KPiA+ID4gIGRyaXZlcnMvdmlkZW8vZmJk ZXYvb21hcDIvb21hcGZiL2Rpc3BsYXlzL3BhbmVsLWxncGhpbGlwcy1sYjAzNXEwMi5jIHwgICAg NiArKystLS0KPiA+ID4gIGRyaXZlcnMvdmlkZW8vZmJkZXYvb21hcDIvb21hcGZiL2Rzcy9kcGku YyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgNCArKy0tCj4gPiA+ICBkcml2ZXJzL3Zp ZGVvL2ZiZGV2L29tYXAyL29tYXBmYi9kc3MvZHNpLmMgICAgICAgICAgICAgICAgICAgICAgICAg ICB8ICAgIDQgKystLQo+ID4gPiAgZHJpdmVycy92aWRlby9mYmRldi9vbWFwMi9vbWFwZmIvZHNz L2hkbWk0LmMgICAgICAgICAgICAgICAgICAgICAgICAgfCAgICAyICstCj4gPiA+ICBkcml2ZXJz L3ZpZGVvL2ZiZGV2L29tYXAyL29tYXBmYi9kc3MvaGRtaTUuYyAgICAgICAgICAgICAgICAgICAg ICAgICB8ICAgIDIgKy0KPiA+ID4gIGRyaXZlcnMvdmlkZW8vZmJkZXYveGlsaW54ZmIuYyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgMiArLQo+ID4gPiAgMTAgZmls ZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pCj4gPiAKPiA+IC4u Ll0KPiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92aWRlby9iYWNrbGlnaHQvcWNvbS13 bGVkLmMgYi9kcml2ZXJzL3ZpZGVvL2JhY2tsaWdodC9xY29tLXdsZWQuYwo+ID4gPiBpbmRleCAz YmM3ODAwZWIwYTkuLjA5MWYwN2U3YzE0NSAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy92aWRl by9iYWNrbGlnaHQvcWNvbS13bGVkLmMKPiA+ID4gKysrIGIvZHJpdmVycy92aWRlby9iYWNrbGln aHQvcWNvbS13bGVkLmMKPiA+ID4gQEAgLTE2OTIsNyArMTY5Miw3IEBAIHN0YXRpYyBpbnQgd2xl ZF9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ID4gPiAgCj4gPiA+ICBzdGF0 aWMgaW50IHdsZWRfcmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gPiA+ICB7 Cj4gPiA+IC0Jc3RydWN0IHdsZWQgKndsZWQgPSBkZXZfZ2V0X2RydmRhdGEoJnBkZXYtPmRldik7 Cj4gPiA+ICsJc3RydWN0IHdsZWQgKndsZWQgPSBwbGF0Zm9ybV9nZXRfZHJ2ZGF0YShwZGV2KTsK PiA+ID4gIAo+ID4gPiAgCW11dGV4X2Rlc3Ryb3koJndsZWQtPmxvY2spOwo+ID4gPiAgCWNhbmNl bF9kZWxheWVkX3dvcmtfc3luYygmd2xlZC0+b3ZwX3dvcmspOwo+ID4gCj4gPiBGb3IgbXkgb3du IHJlZmVyZW5jZSAoYXBwbHkgdGhpcyBhcy1pcyB0byB5b3VyIHNpZ24tb2ZmIGJsb2NrKToKPiA+ IAo+ID4gICBBY2tlZC1mb3ItQmFja2xpZ2h0LWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5h cm8ub3JnPgo+ID4gCj4gCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmlj YWwgTGVhZCAtIERldmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBz b2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwg QmxvZwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK