From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61E75C433DB for ; Wed, 10 Feb 2021 16:21:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1FA4264E76 for ; Wed, 10 Feb 2021 16:21:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231873AbhBJQUv (ORCPT ); Wed, 10 Feb 2021 11:20:51 -0500 Received: from elvis.franken.de ([193.175.24.41]:40677 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231642AbhBJQUu (ORCPT ); Wed, 10 Feb 2021 11:20:50 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1l9sDm-0002jH-00; Wed, 10 Feb 2021 17:20:06 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 9243CC0E2C; Wed, 10 Feb 2021 17:19:42 +0100 (CET) Date: Wed, 10 Feb 2021 17:19:42 +0100 From: Thomas Bogendoerfer To: Waiman Long Cc: Peter Zijlstra , Ingo Molnar , Will Deacon , Catalin Marinas , Chris Zankel , Max Filippov , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-xtensa@linux-xtensa.org, Naresh Kamboju , Guenter Roeck , Ben Gardon Subject: Re: [PATCH] locking/arch: Move qrwlock.h include after qspinlock.h Message-ID: <20210210161942.GA5683@alpha.franken.de> References: <20210210144556.10932-1-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210210144556.10932-1-longman@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Wed, Feb 10, 2021 at 09:45:56AM -0500, Waiman Long wrote: > The queued rwlock code has a dependency on the current spinlock > implementation (likely to be qspinlock), but not vice versa. Including > qrwlock.h before qspinlock.h can be problematic when expanding qrwlock > functionality. > > If both qspinlock.h and qrwlock.h are to be included, the qrwlock.h > include should always be after qspinlock.h. Update the current set of > asm/spinlock.h files to enforce that. > > Signed-off-by: Waiman Long > --- > arch/arm64/include/asm/spinlock.h | 2 +- > arch/mips/include/asm/spinlock.h | 2 +- > arch/xtensa/include/asm/spinlock.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) which tree should this go through ? I can take it via mips-next, if everybody agrees. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 451C6C433DB for ; Wed, 10 Feb 2021 16:21:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F355A64E25 for ; Wed, 10 Feb 2021 16:21:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F355A64E25 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yaSczi/Jg1rlhgvHscHgqYde5eva1E6G/iGKKT4M6cw=; b=XMpZIRtalHRseUvXajGzv3eur zjP1AUIojPzW8FVm/v1Na/IVPRXkzdtCnvPQ5h4ZSyfau+5Ua00HBSWf8GK3vW9OjiWnQkK/NReQ/ Trr6/h/dDlTJcjGwZ4xF5aVH+vTeGPmvgIWld9j1w8iIwRBwKUdT2eCitSyeIcrtLw6K5FoIxcRld sirh5LRd61dG3COeOZg4W3ll4t4n1WhLLsGjvaIC3mxLMbK+bbp2gSt9yWWJn2DFqJCWtc1W45ELT od0QEJiqfEKrGtPf4QA5g4hRSmCLLl1u34GvIfqgt3XI9a4R3SYlaEd/p4rcSQ+Yc1AHwL1fOnoGy LuD3zk7Xw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9sDu-0006Wy-EY; Wed, 10 Feb 2021 16:20:14 +0000 Received: from elvis.franken.de ([193.175.24.41]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9sDq-0006WH-VA for linux-arm-kernel@lists.infradead.org; Wed, 10 Feb 2021 16:20:12 +0000 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1l9sDm-0002jH-00; Wed, 10 Feb 2021 17:20:06 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 9243CC0E2C; Wed, 10 Feb 2021 17:19:42 +0100 (CET) Date: Wed, 10 Feb 2021 17:19:42 +0100 From: Thomas Bogendoerfer To: Waiman Long Subject: Re: [PATCH] locking/arch: Move qrwlock.h include after qspinlock.h Message-ID: <20210210161942.GA5683@alpha.franken.de> References: <20210210144556.10932-1-longman@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210210144556.10932-1-longman@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210210_112011_152320_6B2EEAC2 X-CRM114-Status: GOOD ( 15.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Zankel , linux-xtensa@linux-xtensa.org, Peter Zijlstra , Catalin Marinas , Naresh Kamboju , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, Max Filippov , Ingo Molnar , Guenter Roeck , Ben Gardon , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 10, 2021 at 09:45:56AM -0500, Waiman Long wrote: > The queued rwlock code has a dependency on the current spinlock > implementation (likely to be qspinlock), but not vice versa. Including > qrwlock.h before qspinlock.h can be problematic when expanding qrwlock > functionality. > > If both qspinlock.h and qrwlock.h are to be included, the qrwlock.h > include should always be after qspinlock.h. Update the current set of > asm/spinlock.h files to enforce that. > > Signed-off-by: Waiman Long > --- > arch/arm64/include/asm/spinlock.h | 2 +- > arch/mips/include/asm/spinlock.h | 2 +- > arch/xtensa/include/asm/spinlock.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) which tree should this go through ? I can take it via mips-next, if everybody agrees. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel