From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8298BC433DB for ; Wed, 10 Feb 2021 22:40:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3BBB564EAC for ; Wed, 10 Feb 2021 22:40:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3BBB564EAC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A53D26ED17; Wed, 10 Feb 2021 22:40:35 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 560B26ED13; Wed, 10 Feb 2021 22:40:34 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 5898164E8A; Wed, 10 Feb 2021 22:40:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612996834; bh=fv/SaLX4OCbE+8LRP74tQIUI6aMJIwiNKHsef7saXqc=; h=Date:From:To:Cc:Subject:From; b=FkYmsTOayGNs35h2mi4e3gHIin0mbtpK2ov/p/hu4m8hqbmEhw/0DqAIgEXpBoASj KQeYDvQm1/rLMnskdVd+UI5fa1ALYJu+o8LAVNiqlTRqC+rDAU0bnBwUgTesuUdd2D 1lgRYeXqomTOCcsk7//NjPkKqhyjGqgROfv86HXmp2VZ3Ml4zVqweoMaoRkgGwL1UW fTWSdj8qf7m93PrvcAmB9YlOrhzo9EHfG5UBqUeW3d6v4wEqyD1Cvp1mXyX3qD8kEY IPwFcbcmzxz/OOCaRn/3nugCqG5Ebh7sLJJ0i1DPMn2kQMBREZ4EbgSSamz452Ugha a5mbXO/6nUSgQ== Date: Wed, 10 Feb 2021 16:40:31 -0600 From: "Gustavo A. R. Silva" To: Evan Quan , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Daniel Vetter Subject: [PATCH][next] drm/amd/pm: Replace one-element array with flexible-array in struct SISLANDS_SMC_SWSTATE Message-ID: <20210210224031.GA8795@embeddedor> MIME-Version: 1.0 Content-Disposition: inline X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" VGhlcmUgaXMgYSByZWd1bGFyIG5lZWQgaW4gdGhlIGtlcm5lbCB0byBwcm92aWRlIGEgd2F5IHRv IGRlY2xhcmUgaGF2aW5nCmEgZHluYW1pY2FsbHkgc2l6ZWQgc2V0IG9mIHRyYWlsaW5nIGVsZW1l bnRzIGluIGEgc3RydWN0dXJlLiBLZXJuZWwgY29kZQpzaG91bGQgYWx3YXlzIHVzZSDigJxmbGV4 aWJsZSBhcnJheSBtZW1iZXJz4oCdWzFdIGZvciB0aGVzZSBjYXNlcy4gVGhlIG9sZGVyCnN0eWxl IG9mIG9uZS1lbGVtZW50IG9yIHplcm8tbGVuZ3RoIGFycmF5cyBzaG91bGQgbm8gbG9uZ2VyIGJl IHVzZWRbMl0uCgpSZWZhY3RvciB0aGUgY29kZSBhY2NvcmRpbmcgdG8gdGhlIHVzZSBvZiBhIGZs ZXhpYmxlLWFycmF5IG1lbWJlciBpbgpzdHJ1Y3QgU0lTTEFORFNfU01DX1NXU1RBVEUsIGluc3Rl YWQgb2YgYSBvbmUtZWxlbWVudCBhcnJheSwgYW5kIHVzZQp0aGUgc3RydWN0X3NpemUoKSBoZWxw ZXIgdG8gY2FsY3VsYXRlIHRoZSBzaXplIGZvciB0aGUgYWxsb2NhdGlvbi4KCkFsc28sIHRoaXMg aGVscHMgd2l0aCB0aGUgb25nb2luZyBlZmZvcnRzIHRvIGVuYWJsZSAtV2FycmF5LWJvdW5kcyBh bmQKZml4IHRoZSBmb2xsb3dpbmcgd2FybmluZ3M6Cgpkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw dS8uLi9wbS9wb3dlcnBsYXkvc2lfZHBtLmM6MjQ0ODoyMDogd2FybmluZzogYXJyYXkKc3Vic2Ny aXB0IDEgaXMgYWJvdmUgYXJyYXkgYm91bmRzIG9mIOKAmFNJU0xBTkRTX1NNQ19IV19QRVJGT1JN QU5DRV9MRVZFTFsxXeKAmQp7YWthIOKAmHN0cnVjdCBTSVNMQU5EU19TTUNfSFdfUEVSRk9STUFO Q0VfTEVWRUxbMV3igJl9IFstV2FycmF5LWJvdW5kc10KZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvLi4vcG0vcG93ZXJwbGF5L3NpX2RwbS5jOjI0NDk6MjA6IHdhcm5pbmc6IGFycmF5CnN1YnNj cmlwdCAxIGlzIGFib3ZlIGFycmF5IGJvdW5kcyBvZiDigJhTSVNMQU5EU19TTUNfSFdfUEVSRk9S TUFOQ0VfTEVWRUxbMV3igJkKe2FrYSDigJhzdHJ1Y3QgU0lTTEFORFNfU01DX0hXX1BFUkZPUk1B TkNFX0xFVkVMWzFd4oCZfSBbLVdhcnJheS1ib3VuZHNdCmRyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1Ly4uL3BtL3Bvd2VycGxheS9zaV9kcG0uYzoyNDUwOjIwOiB3YXJuaW5nOiBhcnJheQpzdWJz Y3JpcHQgMSBpcyBhYm92ZSBhcnJheSBib3VuZHMgb2Yg4oCYU0lTTEFORFNfU01DX0hXX1BFUkZP Uk1BTkNFX0xFVkVMWzFd4oCZCntha2Eg4oCYc3RydWN0IFNJU0xBTkRTX1NNQ19IV19QRVJGT1JN QU5DRV9MRVZFTFsxXeKAmX0gWy1XYXJyYXktYm91bmRzXQpkcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS8uLi9wbS9wb3dlcnBsYXkvc2lfZHBtLmM6MjQ1MToyMDogd2FybmluZzogYXJyYXkKc3Vi c2NyaXB0IDEgaXMgYWJvdmUgYXJyYXkgYm91bmRzIG9mIOKAmFNJU0xBTkRTX1NNQ19IV19QRVJG T1JNQU5DRV9MRVZFTFsxXeKAmQp7YWthIOKAmHN0cnVjdCBTSVNMQU5EU19TTUNfSFdfUEVSRk9S TUFOQ0VfTEVWRUxbMV3igJl9IFstV2FycmF5LWJvdW5kc10KZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvLi4vcG0vcG93ZXJwbGF5L3NpX2RwbS5jOjI0NTI6MjA6IHdhcm5pbmc6IGFycmF5CnN1 YnNjcmlwdCAxIGlzIGFib3ZlIGFycmF5IGJvdW5kcyBvZiDigJhTSVNMQU5EU19TTUNfSFdfUEVS Rk9STUFOQ0VfTEVWRUxbMV3igJkKe2FrYSDigJhzdHJ1Y3QgU0lTTEFORFNfU01DX0hXX1BFUkZP Uk1BTkNFX0xFVkVMWzFd4oCZfSBbLVdhcnJheS1ib3VuZHNdCmRyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1Ly4uL3BtL3Bvd2VycGxheS9zaV9kcG0uYzo1NTcwOjIwOiB3YXJuaW5nOiBhcnJheQpz dWJzY3JpcHQgMSBpcyBhYm92ZSBhcnJheSBib3VuZHMgb2Yg4oCYU0lTTEFORFNfU01DX0hXX1BF UkZPUk1BTkNFX0xFVkVMWzFd4oCZCntha2Eg4oCYc3RydWN0IFNJU0xBTkRTX1NNQ19IV19QRVJG T1JNQU5DRV9MRVZFTFsxXeKAmX0gWy1XYXJyYXktYm91bmRzXQoKWzFdIGh0dHBzOi8vZW4ud2lr aXBlZGlhLm9yZy93aWtpL0ZsZXhpYmxlX2FycmF5X21lbWJlcgpbMl0gaHR0cHM6Ly93d3cua2Vy bmVsLm9yZy9kb2MvaHRtbC92NS45L3Byb2Nlc3MvZGVwcmVjYXRlZC5odG1sI3plcm8tbGVuZ3Ro LWFuZC1vbmUtZWxlbWVudC1hcnJheXMKCkxpbms6IGh0dHBzOi8vZ2l0aHViLmNvbS9LU1BQL2xp bnV4L2lzc3Vlcy83OQpMaW5rOiBodHRwczovL2dpdGh1Yi5jb20vS1NQUC9saW51eC9pc3N1ZXMv MTA5CkJ1aWxkLXRlc3RlZC1ieToga2VybmVsIHRlc3Qgcm9ib3QgPGxrcEBpbnRlbC5jb20+Ckxp bms6IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xrbWwvNjAyM2JlNTguc2s2NkwlMkZWNHZ1U0pJ NW1JJTI1bGtwQGludGVsLmNvbS8gClNpZ25lZC1vZmYtYnk6IEd1c3Rhdm8gQS4gUi4gU2lsdmEg PGd1c3Rhdm9hcnNAa2VybmVsLm9yZz4KLS0tCiBkcml2ZXJzL2dwdS9kcm0vYW1kL3BtL3Bvd2Vy cGxheS9zaV9kcG0uYyAgICAgICB8ICA2ICsrLS0tLQogZHJpdmVycy9ncHUvZHJtL2FtZC9wbS9w b3dlcnBsYXkvc2lzbGFuZHNfc21jLmggfCAxMCArKysrKy0tLS0tCiAyIGZpbGVzIGNoYW5nZWQs IDcgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vYW1kL3BtL3Bvd2VycGxheS9zaV9kcG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvcG0v cG93ZXJwbGF5L3NpX2RwbS5jCmluZGV4IGFmYTE3MTFjOTYyMC4uNjIyOTEzNThmYjFjIDEwMDY0 NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL3BtL3Bvd2VycGxheS9zaV9kcG0uYworKysgYi9k cml2ZXJzL2dwdS9kcm0vYW1kL3BtL3Bvd2VycGxheS9zaV9kcG0uYwpAQCAtNTcxNSwxMSArNTcx NSw5IEBAIHN0YXRpYyBpbnQgc2lfdXBsb2FkX3N3X3N0YXRlKHN0cnVjdCBhbWRncHVfZGV2aWNl ICphZGV2LAogCWludCByZXQ7CiAJdTMyIGFkZHJlc3MgPSBzaV9waS0+c3RhdGVfdGFibGVfc3Rh cnQgKwogCQlvZmZzZXRvZihTSVNMQU5EU19TTUNfU1RBVEVUQUJMRSwgZHJpdmVyU3RhdGUpOwot CXUzMiBzdGF0ZV9zaXplID0gc2l6ZW9mKFNJU0xBTkRTX1NNQ19TV1NUQVRFKSArCi0JCSgobmV3 X3N0YXRlLT5wZXJmb3JtYW5jZV9sZXZlbF9jb3VudCAtIDEpICoKLQkJIHNpemVvZihTSVNMQU5E U19TTUNfSFdfUEVSRk9STUFOQ0VfTEVWRUwpKTsKIAlTSVNMQU5EU19TTUNfU1dTVEFURSAqc21j X3N0YXRlID0gJnNpX3BpLT5zbWNfc3RhdGV0YWJsZS5kcml2ZXJTdGF0ZTsKLQorCXNpemVfdCBz dGF0ZV9zaXplID0gc3RydWN0X3NpemUoc21jX3N0YXRlLCBsZXZlbHMsCisJCQkJCW5ld19zdGF0 ZS0+cGVyZm9ybWFuY2VfbGV2ZWxfY291bnQpOwogCW1lbXNldChzbWNfc3RhdGUsIDAsIHN0YXRl X3NpemUpOwogCiAJcmV0ID0gc2lfY29udmVydF9wb3dlcl9zdGF0ZV90b19zbWMoYWRldiwgYW1k Z3B1X25ld19zdGF0ZSwgc21jX3N0YXRlKTsKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9h bWQvcG0vcG93ZXJwbGF5L3Npc2xhbmRzX3NtYy5oIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9wbS9w b3dlcnBsYXkvc2lzbGFuZHNfc21jLmgKaW5kZXggZDI5MzBlY2VhZjNjLi4wZjc1NTQwNTJjOTAg MTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvcG0vcG93ZXJwbGF5L3Npc2xhbmRzX3Nt Yy5oCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvcG0vcG93ZXJwbGF5L3Npc2xhbmRzX3NtYy5o CkBAIC0xODIsMTEgKzE4MiwxMSBAQCB0eXBlZGVmIHN0cnVjdCBTSVNMQU5EU19TTUNfSFdfUEVS Rk9STUFOQ0VfTEVWRUwgU0lTTEFORFNfU01DX0hXX1BFUkZPUk1BTkNFX0xFVgogCiBzdHJ1Y3Qg U0lTTEFORFNfU01DX1NXU1RBVEUKIHsKLSAgICB1aW50OF90ICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBmbGFnczsKLSAgICB1aW50OF90ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBs ZXZlbENvdW50OwotICAgIHVpbnQ4X3QgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBhZGRp bmcyOwotICAgIHVpbnQ4X3QgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBhZGRpbmczOwot ICAgIFNJU0xBTkRTX1NNQ19IV19QRVJGT1JNQU5DRV9MRVZFTCAgIGxldmVsc1sxXTsKKwl1aW50 OF90ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmbGFnczsKKwl1aW50OF90ICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBsZXZlbENvdW50OworCXVpbnQ4X3QgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHBhZGRpbmcyOworCXVpbnQ4X3QgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHBhZGRpbmczOworCVNJU0xBTkRTX1NNQ19IV19QRVJGT1JNQU5DRV9MRVZFTCAgIGxldmVs c1tdOwogfTsKIAogdHlwZWRlZiBzdHJ1Y3QgU0lTTEFORFNfU01DX1NXU1RBVEUgU0lTTEFORFNf U01DX1NXU1RBVEU7Ci0tIAoyLjI3LjAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v YW1kLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAAB7C433DB for ; Wed, 10 Feb 2021 22:41:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE3CB64DDA for ; Wed, 10 Feb 2021 22:41:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232164AbhBJWlP (ORCPT ); Wed, 10 Feb 2021 17:41:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:48704 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232045AbhBJWlP (ORCPT ); Wed, 10 Feb 2021 17:41:15 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5898164E8A; Wed, 10 Feb 2021 22:40:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612996834; bh=fv/SaLX4OCbE+8LRP74tQIUI6aMJIwiNKHsef7saXqc=; h=Date:From:To:Cc:Subject:From; b=FkYmsTOayGNs35h2mi4e3gHIin0mbtpK2ov/p/hu4m8hqbmEhw/0DqAIgEXpBoASj KQeYDvQm1/rLMnskdVd+UI5fa1ALYJu+o8LAVNiqlTRqC+rDAU0bnBwUgTesuUdd2D 1lgRYeXqomTOCcsk7//NjPkKqhyjGqgROfv86HXmp2VZ3Ml4zVqweoMaoRkgGwL1UW fTWSdj8qf7m93PrvcAmB9YlOrhzo9EHfG5UBqUeW3d6v4wEqyD1Cvp1mXyX3qD8kEY IPwFcbcmzxz/OOCaRn/3nugCqG5Ebh7sLJJ0i1DPMn2kQMBREZ4EbgSSamz452Ugha a5mbXO/6nUSgQ== Date: Wed, 10 Feb 2021 16:40:31 -0600 From: "Gustavo A. R. Silva" To: Evan Quan , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Daniel Vetter Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org Subject: [PATCH][next] drm/amd/pm: Replace one-element array with flexible-array in struct SISLANDS_SMC_SWSTATE Message-ID: <20210210224031.GA8795@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2]. Refactor the code according to the use of a flexible-array member in struct SISLANDS_SMC_SWSTATE, instead of a one-element array, and use the struct_size() helper to calculate the size for the allocation. Also, this helps with the ongoing efforts to enable -Warray-bounds and fix the following warnings: drivers/gpu/drm/amd/amdgpu/../pm/powerplay/si_dpm.c:2448:20: warning: array subscript 1 is above array bounds of ‘SISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’ {aka ‘struct SISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’} [-Warray-bounds] drivers/gpu/drm/amd/amdgpu/../pm/powerplay/si_dpm.c:2449:20: warning: array subscript 1 is above array bounds of ‘SISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’ {aka ‘struct SISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’} [-Warray-bounds] drivers/gpu/drm/amd/amdgpu/../pm/powerplay/si_dpm.c:2450:20: warning: array subscript 1 is above array bounds of ‘SISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’ {aka ‘struct SISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’} [-Warray-bounds] drivers/gpu/drm/amd/amdgpu/../pm/powerplay/si_dpm.c:2451:20: warning: array subscript 1 is above array bounds of ‘SISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’ {aka ‘struct SISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’} [-Warray-bounds] drivers/gpu/drm/amd/amdgpu/../pm/powerplay/si_dpm.c:2452:20: warning: array subscript 1 is above array bounds of ‘SISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’ {aka ‘struct SISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’} [-Warray-bounds] drivers/gpu/drm/amd/amdgpu/../pm/powerplay/si_dpm.c:5570:20: warning: array subscript 1 is above array bounds of ‘SISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’ {aka ‘struct SISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’} [-Warray-bounds] [1] https://en.wikipedia.org/wiki/Flexible_array_member [2] https://www.kernel.org/doc/html/v5.9/process/deprecated.html#zero-length-and-one-element-arrays Link: https://github.com/KSPP/linux/issues/79 Link: https://github.com/KSPP/linux/issues/109 Build-tested-by: kernel test robot Link: https://lore.kernel.org/lkml/6023be58.sk66L%2FV4vuSJI5mI%25lkp@intel.com/ Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/amd/pm/powerplay/si_dpm.c | 6 ++---- drivers/gpu/drm/amd/pm/powerplay/sislands_smc.h | 10 +++++----- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/si_dpm.c b/drivers/gpu/drm/amd/pm/powerplay/si_dpm.c index afa1711c9620..62291358fb1c 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/si_dpm.c +++ b/drivers/gpu/drm/amd/pm/powerplay/si_dpm.c @@ -5715,11 +5715,9 @@ static int si_upload_sw_state(struct amdgpu_device *adev, int ret; u32 address = si_pi->state_table_start + offsetof(SISLANDS_SMC_STATETABLE, driverState); - u32 state_size = sizeof(SISLANDS_SMC_SWSTATE) + - ((new_state->performance_level_count - 1) * - sizeof(SISLANDS_SMC_HW_PERFORMANCE_LEVEL)); SISLANDS_SMC_SWSTATE *smc_state = &si_pi->smc_statetable.driverState; - + size_t state_size = struct_size(smc_state, levels, + new_state->performance_level_count); memset(smc_state, 0, state_size); ret = si_convert_power_state_to_smc(adev, amdgpu_new_state, smc_state); diff --git a/drivers/gpu/drm/amd/pm/powerplay/sislands_smc.h b/drivers/gpu/drm/amd/pm/powerplay/sislands_smc.h index d2930eceaf3c..0f7554052c90 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/sislands_smc.h +++ b/drivers/gpu/drm/amd/pm/powerplay/sislands_smc.h @@ -182,11 +182,11 @@ typedef struct SISLANDS_SMC_HW_PERFORMANCE_LEVEL SISLANDS_SMC_HW_PERFORMANCE_LEV struct SISLANDS_SMC_SWSTATE { - uint8_t flags; - uint8_t levelCount; - uint8_t padding2; - uint8_t padding3; - SISLANDS_SMC_HW_PERFORMANCE_LEVEL levels[1]; + uint8_t flags; + uint8_t levelCount; + uint8_t padding2; + uint8_t padding3; + SISLANDS_SMC_HW_PERFORMANCE_LEVEL levels[]; }; typedef struct SISLANDS_SMC_SWSTATE SISLANDS_SMC_SWSTATE; -- 2.27.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B782C433E0 for ; Wed, 10 Feb 2021 22:40:36 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFDCE64ECF for ; Wed, 10 Feb 2021 22:40:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFDCE64ECF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 147AE6ED13; Wed, 10 Feb 2021 22:40:35 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 560B26ED13; Wed, 10 Feb 2021 22:40:34 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 5898164E8A; Wed, 10 Feb 2021 22:40:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612996834; bh=fv/SaLX4OCbE+8LRP74tQIUI6aMJIwiNKHsef7saXqc=; h=Date:From:To:Cc:Subject:From; b=FkYmsTOayGNs35h2mi4e3gHIin0mbtpK2ov/p/hu4m8hqbmEhw/0DqAIgEXpBoASj KQeYDvQm1/rLMnskdVd+UI5fa1ALYJu+o8LAVNiqlTRqC+rDAU0bnBwUgTesuUdd2D 1lgRYeXqomTOCcsk7//NjPkKqhyjGqgROfv86HXmp2VZ3Ml4zVqweoMaoRkgGwL1UW fTWSdj8qf7m93PrvcAmB9YlOrhzo9EHfG5UBqUeW3d6v4wEqyD1Cvp1mXyX3qD8kEY IPwFcbcmzxz/OOCaRn/3nugCqG5Ebh7sLJJ0i1DPMn2kQMBREZ4EbgSSamz452Ugha a5mbXO/6nUSgQ== Date: Wed, 10 Feb 2021 16:40:31 -0600 From: "Gustavo A. R. Silva" To: Evan Quan , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Daniel Vetter Subject: [PATCH][next] drm/amd/pm: Replace one-element array with flexible-array in struct SISLANDS_SMC_SWSTATE Message-ID: <20210210224031.GA8795@embeddedor> MIME-Version: 1.0 Content-Disposition: inline X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" VGhlcmUgaXMgYSByZWd1bGFyIG5lZWQgaW4gdGhlIGtlcm5lbCB0byBwcm92aWRlIGEgd2F5IHRv IGRlY2xhcmUgaGF2aW5nCmEgZHluYW1pY2FsbHkgc2l6ZWQgc2V0IG9mIHRyYWlsaW5nIGVsZW1l bnRzIGluIGEgc3RydWN0dXJlLiBLZXJuZWwgY29kZQpzaG91bGQgYWx3YXlzIHVzZSDigJxmbGV4 aWJsZSBhcnJheSBtZW1iZXJz4oCdWzFdIGZvciB0aGVzZSBjYXNlcy4gVGhlIG9sZGVyCnN0eWxl IG9mIG9uZS1lbGVtZW50IG9yIHplcm8tbGVuZ3RoIGFycmF5cyBzaG91bGQgbm8gbG9uZ2VyIGJl IHVzZWRbMl0uCgpSZWZhY3RvciB0aGUgY29kZSBhY2NvcmRpbmcgdG8gdGhlIHVzZSBvZiBhIGZs ZXhpYmxlLWFycmF5IG1lbWJlciBpbgpzdHJ1Y3QgU0lTTEFORFNfU01DX1NXU1RBVEUsIGluc3Rl YWQgb2YgYSBvbmUtZWxlbWVudCBhcnJheSwgYW5kIHVzZQp0aGUgc3RydWN0X3NpemUoKSBoZWxw ZXIgdG8gY2FsY3VsYXRlIHRoZSBzaXplIGZvciB0aGUgYWxsb2NhdGlvbi4KCkFsc28sIHRoaXMg aGVscHMgd2l0aCB0aGUgb25nb2luZyBlZmZvcnRzIHRvIGVuYWJsZSAtV2FycmF5LWJvdW5kcyBh bmQKZml4IHRoZSBmb2xsb3dpbmcgd2FybmluZ3M6Cgpkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw dS8uLi9wbS9wb3dlcnBsYXkvc2lfZHBtLmM6MjQ0ODoyMDogd2FybmluZzogYXJyYXkKc3Vic2Ny aXB0IDEgaXMgYWJvdmUgYXJyYXkgYm91bmRzIG9mIOKAmFNJU0xBTkRTX1NNQ19IV19QRVJGT1JN QU5DRV9MRVZFTFsxXeKAmQp7YWthIOKAmHN0cnVjdCBTSVNMQU5EU19TTUNfSFdfUEVSRk9STUFO Q0VfTEVWRUxbMV3igJl9IFstV2FycmF5LWJvdW5kc10KZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvLi4vcG0vcG93ZXJwbGF5L3NpX2RwbS5jOjI0NDk6MjA6IHdhcm5pbmc6IGFycmF5CnN1YnNj cmlwdCAxIGlzIGFib3ZlIGFycmF5IGJvdW5kcyBvZiDigJhTSVNMQU5EU19TTUNfSFdfUEVSRk9S TUFOQ0VfTEVWRUxbMV3igJkKe2FrYSDigJhzdHJ1Y3QgU0lTTEFORFNfU01DX0hXX1BFUkZPUk1B TkNFX0xFVkVMWzFd4oCZfSBbLVdhcnJheS1ib3VuZHNdCmRyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1Ly4uL3BtL3Bvd2VycGxheS9zaV9kcG0uYzoyNDUwOjIwOiB3YXJuaW5nOiBhcnJheQpzdWJz Y3JpcHQgMSBpcyBhYm92ZSBhcnJheSBib3VuZHMgb2Yg4oCYU0lTTEFORFNfU01DX0hXX1BFUkZP Uk1BTkNFX0xFVkVMWzFd4oCZCntha2Eg4oCYc3RydWN0IFNJU0xBTkRTX1NNQ19IV19QRVJGT1JN QU5DRV9MRVZFTFsxXeKAmX0gWy1XYXJyYXktYm91bmRzXQpkcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS8uLi9wbS9wb3dlcnBsYXkvc2lfZHBtLmM6MjQ1MToyMDogd2FybmluZzogYXJyYXkKc3Vi c2NyaXB0IDEgaXMgYWJvdmUgYXJyYXkgYm91bmRzIG9mIOKAmFNJU0xBTkRTX1NNQ19IV19QRVJG T1JNQU5DRV9MRVZFTFsxXeKAmQp7YWthIOKAmHN0cnVjdCBTSVNMQU5EU19TTUNfSFdfUEVSRk9S TUFOQ0VfTEVWRUxbMV3igJl9IFstV2FycmF5LWJvdW5kc10KZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRncHUvLi4vcG0vcG93ZXJwbGF5L3NpX2RwbS5jOjI0NTI6MjA6IHdhcm5pbmc6IGFycmF5CnN1 YnNjcmlwdCAxIGlzIGFib3ZlIGFycmF5IGJvdW5kcyBvZiDigJhTSVNMQU5EU19TTUNfSFdfUEVS Rk9STUFOQ0VfTEVWRUxbMV3igJkKe2FrYSDigJhzdHJ1Y3QgU0lTTEFORFNfU01DX0hXX1BFUkZP Uk1BTkNFX0xFVkVMWzFd4oCZfSBbLVdhcnJheS1ib3VuZHNdCmRyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1Ly4uL3BtL3Bvd2VycGxheS9zaV9kcG0uYzo1NTcwOjIwOiB3YXJuaW5nOiBhcnJheQpz dWJzY3JpcHQgMSBpcyBhYm92ZSBhcnJheSBib3VuZHMgb2Yg4oCYU0lTTEFORFNfU01DX0hXX1BF UkZPUk1BTkNFX0xFVkVMWzFd4oCZCntha2Eg4oCYc3RydWN0IFNJU0xBTkRTX1NNQ19IV19QRVJG T1JNQU5DRV9MRVZFTFsxXeKAmX0gWy1XYXJyYXktYm91bmRzXQoKWzFdIGh0dHBzOi8vZW4ud2lr aXBlZGlhLm9yZy93aWtpL0ZsZXhpYmxlX2FycmF5X21lbWJlcgpbMl0gaHR0cHM6Ly93d3cua2Vy bmVsLm9yZy9kb2MvaHRtbC92NS45L3Byb2Nlc3MvZGVwcmVjYXRlZC5odG1sI3plcm8tbGVuZ3Ro LWFuZC1vbmUtZWxlbWVudC1hcnJheXMKCkxpbms6IGh0dHBzOi8vZ2l0aHViLmNvbS9LU1BQL2xp bnV4L2lzc3Vlcy83OQpMaW5rOiBodHRwczovL2dpdGh1Yi5jb20vS1NQUC9saW51eC9pc3N1ZXMv MTA5CkJ1aWxkLXRlc3RlZC1ieToga2VybmVsIHRlc3Qgcm9ib3QgPGxrcEBpbnRlbC5jb20+Ckxp bms6IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xrbWwvNjAyM2JlNTguc2s2NkwlMkZWNHZ1U0pJ NW1JJTI1bGtwQGludGVsLmNvbS8gClNpZ25lZC1vZmYtYnk6IEd1c3Rhdm8gQS4gUi4gU2lsdmEg PGd1c3Rhdm9hcnNAa2VybmVsLm9yZz4KLS0tCiBkcml2ZXJzL2dwdS9kcm0vYW1kL3BtL3Bvd2Vy cGxheS9zaV9kcG0uYyAgICAgICB8ICA2ICsrLS0tLQogZHJpdmVycy9ncHUvZHJtL2FtZC9wbS9w b3dlcnBsYXkvc2lzbGFuZHNfc21jLmggfCAxMCArKysrKy0tLS0tCiAyIGZpbGVzIGNoYW5nZWQs IDcgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vYW1kL3BtL3Bvd2VycGxheS9zaV9kcG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvcG0v cG93ZXJwbGF5L3NpX2RwbS5jCmluZGV4IGFmYTE3MTFjOTYyMC4uNjIyOTEzNThmYjFjIDEwMDY0 NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL3BtL3Bvd2VycGxheS9zaV9kcG0uYworKysgYi9k cml2ZXJzL2dwdS9kcm0vYW1kL3BtL3Bvd2VycGxheS9zaV9kcG0uYwpAQCAtNTcxNSwxMSArNTcx NSw5IEBAIHN0YXRpYyBpbnQgc2lfdXBsb2FkX3N3X3N0YXRlKHN0cnVjdCBhbWRncHVfZGV2aWNl ICphZGV2LAogCWludCByZXQ7CiAJdTMyIGFkZHJlc3MgPSBzaV9waS0+c3RhdGVfdGFibGVfc3Rh cnQgKwogCQlvZmZzZXRvZihTSVNMQU5EU19TTUNfU1RBVEVUQUJMRSwgZHJpdmVyU3RhdGUpOwot CXUzMiBzdGF0ZV9zaXplID0gc2l6ZW9mKFNJU0xBTkRTX1NNQ19TV1NUQVRFKSArCi0JCSgobmV3 X3N0YXRlLT5wZXJmb3JtYW5jZV9sZXZlbF9jb3VudCAtIDEpICoKLQkJIHNpemVvZihTSVNMQU5E U19TTUNfSFdfUEVSRk9STUFOQ0VfTEVWRUwpKTsKIAlTSVNMQU5EU19TTUNfU1dTVEFURSAqc21j X3N0YXRlID0gJnNpX3BpLT5zbWNfc3RhdGV0YWJsZS5kcml2ZXJTdGF0ZTsKLQorCXNpemVfdCBz dGF0ZV9zaXplID0gc3RydWN0X3NpemUoc21jX3N0YXRlLCBsZXZlbHMsCisJCQkJCW5ld19zdGF0 ZS0+cGVyZm9ybWFuY2VfbGV2ZWxfY291bnQpOwogCW1lbXNldChzbWNfc3RhdGUsIDAsIHN0YXRl X3NpemUpOwogCiAJcmV0ID0gc2lfY29udmVydF9wb3dlcl9zdGF0ZV90b19zbWMoYWRldiwgYW1k Z3B1X25ld19zdGF0ZSwgc21jX3N0YXRlKTsKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9h bWQvcG0vcG93ZXJwbGF5L3Npc2xhbmRzX3NtYy5oIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9wbS9w b3dlcnBsYXkvc2lzbGFuZHNfc21jLmgKaW5kZXggZDI5MzBlY2VhZjNjLi4wZjc1NTQwNTJjOTAg MTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvcG0vcG93ZXJwbGF5L3Npc2xhbmRzX3Nt Yy5oCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvcG0vcG93ZXJwbGF5L3Npc2xhbmRzX3NtYy5o CkBAIC0xODIsMTEgKzE4MiwxMSBAQCB0eXBlZGVmIHN0cnVjdCBTSVNMQU5EU19TTUNfSFdfUEVS Rk9STUFOQ0VfTEVWRUwgU0lTTEFORFNfU01DX0hXX1BFUkZPUk1BTkNFX0xFVgogCiBzdHJ1Y3Qg U0lTTEFORFNfU01DX1NXU1RBVEUKIHsKLSAgICB1aW50OF90ICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBmbGFnczsKLSAgICB1aW50OF90ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBs ZXZlbENvdW50OwotICAgIHVpbnQ4X3QgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBhZGRp bmcyOwotICAgIHVpbnQ4X3QgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBhZGRpbmczOwot ICAgIFNJU0xBTkRTX1NNQ19IV19QRVJGT1JNQU5DRV9MRVZFTCAgIGxldmVsc1sxXTsKKwl1aW50 OF90ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmbGFnczsKKwl1aW50OF90ICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBsZXZlbENvdW50OworCXVpbnQ4X3QgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHBhZGRpbmcyOworCXVpbnQ4X3QgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHBhZGRpbmczOworCVNJU0xBTkRTX1NNQ19IV19QRVJGT1JNQU5DRV9MRVZFTCAgIGxldmVs c1tdOwogfTsKIAogdHlwZWRlZiBzdHJ1Y3QgU0lTTEFORFNfU01DX1NXU1RBVEUgU0lTTEFORFNf U01DX1NXU1RBVEU7Ci0tIAoyLjI3LjAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo=