From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F4D2C433DB for ; Wed, 10 Feb 2021 23:49:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BB1E64DE3 for ; Wed, 10 Feb 2021 23:49:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BB1E64DE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BBD266ED72; Wed, 10 Feb 2021 23:49:31 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7146F6EA6C; Wed, 10 Feb 2021 23:49:30 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 660B764E0B; Wed, 10 Feb 2021 23:49:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613000970; bh=DFd7DSXy7nWVxMi3ogNh04lyt3UKSNz0wPfFB3/Ikgk=; h=Date:From:To:Cc:Subject:From; b=RwE0EQrcXAXhRu1tEHQ5OhsgYK9JITPA5slwojL1+mXW77Z8/D7tRuDy1HrBeaNDi VSoq6CR/wVeUFMyFlVpogSpN78LwdeH5XGoLpMSHKSsAS39OBexHYcGz7nUI3cSElf pEhdAKrevf4lPyeCXeXC2xLVhsNo2ROTK8vxd6WVAJwem1bv+G36GDRLwJXdn7jQCA 6HG7oiRQ/xiXWpnelxJgLOzGhYUy0qDiZUPImb86cg+e57sZh1Z4tfOz3bTKymv2N8 Fq6+9zJNjKrznJWXV08nvgsPXEnSBZPFkS58LWHyMzO9Br/s54B6maQz3ZGArCPUPb vCxAkBdkPgidQ== Date: Wed, 10 Feb 2021 17:49:27 -0600 From: "Gustavo A. R. Silva" To: Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Daniel Vetter Subject: [PATCH][next] drm/radeon/nislands_smc.h: Replace one-element array with flexible-array member in struct NISLANDS_SMC_SWSTATE Message-ID: <20210210234927.GA68137@embeddedor> MIME-Version: 1.0 Content-Disposition: inline X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" VGhlcmUgaXMgYSByZWd1bGFyIG5lZWQgaW4gdGhlIGtlcm5lbCB0byBwcm92aWRlIGEgd2F5IHRv IGRlY2xhcmUgaGF2aW5nCmEgZHluYW1pY2FsbHkgc2l6ZWQgc2V0IG9mIHRyYWlsaW5nIGVsZW1l bnRzIGluIGEgc3RydWN0dXJlLiBLZXJuZWwgY29kZQpzaG91bGQgYWx3YXlzIHVzZSDigJxmbGV4 aWJsZSBhcnJheSBtZW1iZXJz4oCdWzFdIGZvciB0aGVzZSBjYXNlcy4gVGhlIG9sZGVyCnN0eWxl IG9mIG9uZS1lbGVtZW50IG9yIHplcm8tbGVuZ3RoIGFycmF5cyBzaG91bGQgbm8gbG9uZ2VyIGJl IHVzZWRbMl0uCgpVc2UgZmxleGlibGUtYXJyYXkgbWVtYmVyIGluIHN0cnVjdCBOSVNMQU5EU19T TUNfU1dTVEFURSwgaW5zdGVhZCBvZgpvbmUtZWxlbWVudCBhcnJheS4KCkFsc28sIHRoaXMgaGVs cHMgd2l0aCB0aGUgb25nb2luZyBlZmZvcnRzIHRvIGVuYWJsZSAtV2FycmF5LWJvdW5kcyBieQpm aXhpbmcgdGhlIGZvbGxvd2luZyB3YXJuaW5nczoKCmRyaXZlcnMvZ3B1L2RybS9yYWRlb24vbmlf ZHBtLmM6IEluIGZ1bmN0aW9uIOKAmG5pX2NvbnZlcnRfcG93ZXJfc3RhdGVfdG9fc21j4oCZOgpk cml2ZXJzL2dwdS9kcm0vcmFkZW9uL25pX2RwbS5jOjI1MjE6MjA6IHdhcm5pbmc6IGFycmF5IHN1 YnNjcmlwdCAxIGlzIGFib3ZlIGFycmF5IGJvdW5kcyBvZiDigJhOSVNMQU5EU19TTUNfSFdfUEVS Rk9STUFOQ0VfTEVWRUxbMV3igJkge2FrYSDigJhzdHJ1Y3QgTklTTEFORFNfU01DX0hXX1BFUkZP Uk1BTkNFX0xFVkVMWzFd4oCZfSBbLVdhcnJheS1ib3VuZHNdCiAyNTIxIHwgICBzbWNfc3RhdGUt PmxldmVsc1tpXS5kcG0yLk1heFBTID0KICAgICAgfCAgIH5+fn5+fn5+fn5+fn5+fn5+Xn5+CmRy aXZlcnMvZ3B1L2RybS9yYWRlb24vbmlfZHBtLmM6MjUyMzoyMDogd2FybmluZzogYXJyYXkgc3Vi c2NyaXB0IDEgaXMgYWJvdmUgYXJyYXkgYm91bmRzIG9mIOKAmE5JU0xBTkRTX1NNQ19IV19QRVJG T1JNQU5DRV9MRVZFTFsxXeKAmSB7YWthIOKAmHN0cnVjdCBOSVNMQU5EU19TTUNfSFdfUEVSRk9S TUFOQ0VfTEVWRUxbMV3igJl9IFstV2FycmF5LWJvdW5kc10KIDI1MjMgfCAgIHNtY19zdGF0ZS0+ bGV2ZWxzW2ldLmRwbTIuTmVhclREUERlYyA9IE5JU0xBTkRTX0RQTTJfTkVBUl9URFBfREVDOwog ICAgICB8ICAgfn5+fn5+fn5+fn5+fn5+fn5efn4KZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9uaV9k cG0uYzoyNTI0OjIwOiB3YXJuaW5nOiBhcnJheSBzdWJzY3JpcHQgMSBpcyBhYm92ZSBhcnJheSBi b3VuZHMgb2Yg4oCYTklTTEFORFNfU01DX0hXX1BFUkZPUk1BTkNFX0xFVkVMWzFd4oCZIHtha2Eg 4oCYc3RydWN0IE5JU0xBTkRTX1NNQ19IV19QRVJGT1JNQU5DRV9MRVZFTFsxXeKAmX0gWy1XYXJy YXktYm91bmRzXQogMjUyNCB8ICAgc21jX3N0YXRlLT5sZXZlbHNbaV0uZHBtMi5BYm92ZVNhZmVJ bmMgPSBOSVNMQU5EU19EUE0yX0FCT1ZFX1NBRkVfSU5DOwogICAgICB8ICAgfn5+fn5+fn5+fn5+ fn5+fn5efn4KZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9uaV9kcG0uYzoyNTI1OjIwOiB3YXJuaW5n OiBhcnJheSBzdWJzY3JpcHQgMSBpcyBhYm92ZSBhcnJheSBib3VuZHMgb2Yg4oCYTklTTEFORFNf U01DX0hXX1BFUkZPUk1BTkNFX0xFVkVMWzFd4oCZIHtha2Eg4oCYc3RydWN0IE5JU0xBTkRTX1NN Q19IV19QRVJGT1JNQU5DRV9MRVZFTFsxXeKAmX0gWy1XYXJyYXktYm91bmRzXQogMjUyNSB8ICAg c21jX3N0YXRlLT5sZXZlbHNbaV0uZHBtMi5CZWxvd1NhZmVJbmMgPSBOSVNMQU5EU19EUE0yX0JF TE9XX1NBRkVfSU5DOwogICAgICB8ICAgfn5+fn5+fn5+fn5+fn5+fn5efn4KZHJpdmVycy9ncHUv ZHJtL3JhZGVvbi9uaV9kcG0uYzoyNTI2OjM1OiB3YXJuaW5nOiBhcnJheSBzdWJzY3JpcHQgMSBp cyBhYm92ZSBhcnJheSBib3VuZHMgb2Yg4oCYTklTTEFORFNfU01DX0hXX1BFUkZPUk1BTkNFX0xF VkVMWzFd4oCZIHtha2Eg4oCYc3RydWN0IE5JU0xBTkRTX1NNQ19IV19QRVJGT1JNQU5DRV9MRVZF TFsxXeKAmX0gWy1XYXJyYXktYm91bmRzXQogMjUyNiB8ICAgc21jX3N0YXRlLT5sZXZlbHNbaV0u c3RhdGVGbGFncyB8PQogICAgICB8ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBe fgpkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL25pX2RwbS5jOjI1MjY6MzU6IHdhcm5pbmc6IGFycmF5 IHN1YnNjcmlwdCAxIGlzIGFib3ZlIGFycmF5IGJvdW5kcyBvZiDigJhOSVNMQU5EU19TTUNfSFdf UEVSRk9STUFOQ0VfTEVWRUxbMV3igJkge2FrYSDigJhzdHJ1Y3QgTklTTEFORFNfU01DX0hXX1BF UkZPUk1BTkNFX0xFVkVMWzFd4oCZfSBbLVdhcnJheS1ib3VuZHNdCiAyNTI2IHwgICBzbWNfc3Rh dGUtPmxldmVsc1tpXS5zdGF0ZUZsYWdzIHw9CiAgICAgIHwgICB+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fl5+CiAyNTI3IHwgICAgKChpICE9IChzdGF0ZS0+cGVyZm9ybWFuY2VfbGV2 ZWxfY291bnQgLSAxKSkgJiYgcG93ZXJfYm9vc3RfbGltaXQpID8KICAgICAgfCAgICB+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fgogMjUyOCB8ICAgIFBQU01DX1NUQVRFRkxBR19QT1dFUkJPT1NUIDogMDsKICAgICAgfCAg ICB+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn4KZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9u aV9kcG0uYzoyNDQyOjIwOiB3YXJuaW5nOiBhcnJheSBzdWJzY3JpcHQgMSBpcyBhYm92ZSBhcnJh eSBib3VuZHMgb2Yg4oCYTklTTEFORFNfU01DX0hXX1BFUkZPUk1BTkNFX0xFVkVMWzFd4oCZIHth a2Eg4oCYc3RydWN0IE5JU0xBTkRTX1NNQ19IV19QRVJGT1JNQU5DRV9MRVZFTFsxXeKAmX0gWy1X YXJyYXktYm91bmRzXQogMjQ0MiB8ICAgc21jX3N0YXRlLT5sZXZlbHNbaSArIDFdLmFUID0gY3B1 X3RvX2JlMzIoYV90KTsKClsxXSBodHRwczovL2VuLndpa2lwZWRpYS5vcmcvd2lraS9GbGV4aWJs ZV9hcnJheV9tZW1iZXIKWzJdIGh0dHBzOi8vd3d3Lmtlcm5lbC5vcmcvZG9jL2h0bWwvdjUuOS9w cm9jZXNzL2RlcHJlY2F0ZWQuaHRtbCN6ZXJvLWxlbmd0aC1hbmQtb25lLWVsZW1lbnQtYXJyYXlz CgpMaW5rOiBodHRwczovL2dpdGh1Yi5jb20vS1NQUC9saW51eC9pc3N1ZXMvNzkKTGluazogaHR0 cHM6Ly9naXRodWIuY29tL0tTUFAvbGludXgvaXNzdWVzLzEwOQpCdWlsZC10ZXN0ZWQtYnk6IGtl cm5lbCB0ZXN0IHJvYm90IDxsa3BAaW50ZWwuY29tPgpMaW5rOiBodHRwczovL2xvcmUua2VybmVs Lm9yZy9sa21sLzYwMjNlZDU0LkJmSVkrOVV6ODFJNm5xMTklMjVsa3BAaW50ZWwuY29tLwpTaWdu ZWQtb2ZmLWJ5OiBHdXN0YXZvIEEuIFIuIFNpbHZhIDxndXN0YXZvYXJzQGtlcm5lbC5vcmc+Ci0t LQogZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9uaXNsYW5kc19zbWMuaCB8IDEwICsrKysrLS0tLS0K IDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9uaXNsYW5kc19zbWMuaCBiL2RyaXZlcnMvZ3B1 L2RybS9yYWRlb24vbmlzbGFuZHNfc21jLmgKaW5kZXggM2NmOGZjMGQ4M2Y0Li43Mzk1Y2I2YjNj YWMgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vbmlzbGFuZHNfc21jLmgKKysr IGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9uaXNsYW5kc19zbWMuaApAQCAtMTM0LDExICsxMzQs MTEgQEAgdHlwZWRlZiBzdHJ1Y3QgTklTTEFORFNfU01DX0hXX1BFUkZPUk1BTkNFX0xFVkVMIE5J U0xBTkRTX1NNQ19IV19QRVJGT1JNQU5DRV9MRVYKIAogc3RydWN0IE5JU0xBTkRTX1NNQ19TV1NU QVRFCiB7Ci0gICAgdWludDhfdCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmxhZ3M7Ci0g ICAgdWludDhfdCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGV2ZWxDb3VudDsKLSAgICB1 aW50OF90ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYWRkaW5nMjsKLSAgICB1aW50OF90 ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYWRkaW5nMzsKLSAgICBOSVNMQU5EU19TTUNf SFdfUEVSRk9STUFOQ0VfTEVWRUwgICBsZXZlbHNbMV07CisJdWludDhfdCAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgZmxhZ3M7CisJdWludDhfdCAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgbGV2ZWxDb3VudDsKKwl1aW50OF90ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYWRk aW5nMjsKKwl1aW50OF90ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYWRkaW5nMzsKKwlO SVNMQU5EU19TTUNfSFdfUEVSRk9STUFOQ0VfTEVWRUwgICBsZXZlbHNbXTsKIH07CiAKIHR5cGVk ZWYgc3RydWN0IE5JU0xBTkRTX1NNQ19TV1NUQVRFIE5JU0xBTkRTX1NNQ19TV1NUQVRFOwotLSAK Mi4yNy4wCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwph bWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20442C433E0 for ; Wed, 10 Feb 2021 23:50:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EBCF964E0D for ; Wed, 10 Feb 2021 23:50:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233989AbhBJXuS (ORCPT ); Wed, 10 Feb 2021 18:50:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:33470 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233744AbhBJXuK (ORCPT ); Wed, 10 Feb 2021 18:50:10 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 660B764E0B; Wed, 10 Feb 2021 23:49:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613000970; bh=DFd7DSXy7nWVxMi3ogNh04lyt3UKSNz0wPfFB3/Ikgk=; h=Date:From:To:Cc:Subject:From; b=RwE0EQrcXAXhRu1tEHQ5OhsgYK9JITPA5slwojL1+mXW77Z8/D7tRuDy1HrBeaNDi VSoq6CR/wVeUFMyFlVpogSpN78LwdeH5XGoLpMSHKSsAS39OBexHYcGz7nUI3cSElf pEhdAKrevf4lPyeCXeXC2xLVhsNo2ROTK8vxd6WVAJwem1bv+G36GDRLwJXdn7jQCA 6HG7oiRQ/xiXWpnelxJgLOzGhYUy0qDiZUPImb86cg+e57sZh1Z4tfOz3bTKymv2N8 Fq6+9zJNjKrznJWXV08nvgsPXEnSBZPFkS58LWHyMzO9Br/s54B6maQz3ZGArCPUPb vCxAkBdkPgidQ== Date: Wed, 10 Feb 2021 17:49:27 -0600 From: "Gustavo A. R. Silva" To: Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Daniel Vetter Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org Subject: [PATCH][next] drm/radeon/nislands_smc.h: Replace one-element array with flexible-array member in struct NISLANDS_SMC_SWSTATE Message-ID: <20210210234927.GA68137@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2]. Use flexible-array member in struct NISLANDS_SMC_SWSTATE, instead of one-element array. Also, this helps with the ongoing efforts to enable -Warray-bounds by fixing the following warnings: drivers/gpu/drm/radeon/ni_dpm.c: In function ‘ni_convert_power_state_to_smc’: drivers/gpu/drm/radeon/ni_dpm.c:2521:20: warning: array subscript 1 is above array bounds of ‘NISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’ {aka ‘struct NISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’} [-Warray-bounds] 2521 | smc_state->levels[i].dpm2.MaxPS = | ~~~~~~~~~~~~~~~~~^~~ drivers/gpu/drm/radeon/ni_dpm.c:2523:20: warning: array subscript 1 is above array bounds of ‘NISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’ {aka ‘struct NISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’} [-Warray-bounds] 2523 | smc_state->levels[i].dpm2.NearTDPDec = NISLANDS_DPM2_NEAR_TDP_DEC; | ~~~~~~~~~~~~~~~~~^~~ drivers/gpu/drm/radeon/ni_dpm.c:2524:20: warning: array subscript 1 is above array bounds of ‘NISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’ {aka ‘struct NISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’} [-Warray-bounds] 2524 | smc_state->levels[i].dpm2.AboveSafeInc = NISLANDS_DPM2_ABOVE_SAFE_INC; | ~~~~~~~~~~~~~~~~~^~~ drivers/gpu/drm/radeon/ni_dpm.c:2525:20: warning: array subscript 1 is above array bounds of ‘NISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’ {aka ‘struct NISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’} [-Warray-bounds] 2525 | smc_state->levels[i].dpm2.BelowSafeInc = NISLANDS_DPM2_BELOW_SAFE_INC; | ~~~~~~~~~~~~~~~~~^~~ drivers/gpu/drm/radeon/ni_dpm.c:2526:35: warning: array subscript 1 is above array bounds of ‘NISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’ {aka ‘struct NISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’} [-Warray-bounds] 2526 | smc_state->levels[i].stateFlags |= | ^~ drivers/gpu/drm/radeon/ni_dpm.c:2526:35: warning: array subscript 1 is above array bounds of ‘NISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’ {aka ‘struct NISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’} [-Warray-bounds] 2526 | smc_state->levels[i].stateFlags |= | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ 2527 | ((i != (state->performance_level_count - 1)) && power_boost_limit) ? | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2528 | PPSMC_STATEFLAG_POWERBOOST : 0; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/radeon/ni_dpm.c:2442:20: warning: array subscript 1 is above array bounds of ‘NISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’ {aka ‘struct NISLANDS_SMC_HW_PERFORMANCE_LEVEL[1]’} [-Warray-bounds] 2442 | smc_state->levels[i + 1].aT = cpu_to_be32(a_t); [1] https://en.wikipedia.org/wiki/Flexible_array_member [2] https://www.kernel.org/doc/html/v5.9/process/deprecated.html#zero-length-and-one-element-arrays Link: https://github.com/KSPP/linux/issues/79 Link: https://github.com/KSPP/linux/issues/109 Build-tested-by: kernel test robot Link: https://lore.kernel.org/lkml/6023ed54.BfIY+9Uz81I6nq19%25lkp@intel.com/ Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/radeon/nislands_smc.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/radeon/nislands_smc.h b/drivers/gpu/drm/radeon/nislands_smc.h index 3cf8fc0d83f4..7395cb6b3cac 100644 --- a/drivers/gpu/drm/radeon/nislands_smc.h +++ b/drivers/gpu/drm/radeon/nislands_smc.h @@ -134,11 +134,11 @@ typedef struct NISLANDS_SMC_HW_PERFORMANCE_LEVEL NISLANDS_SMC_HW_PERFORMANCE_LEV struct NISLANDS_SMC_SWSTATE { - uint8_t flags; - uint8_t levelCount; - uint8_t padding2; - uint8_t padding3; - NISLANDS_SMC_HW_PERFORMANCE_LEVEL levels[1]; + uint8_t flags; + uint8_t levelCount; + uint8_t padding2; + uint8_t padding3; + NISLANDS_SMC_HW_PERFORMANCE_LEVEL levels[]; }; typedef struct NISLANDS_SMC_SWSTATE NISLANDS_SMC_SWSTATE; -- 2.27.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B61BC433E6 for ; Wed, 10 Feb 2021 23:49:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 614EE64E05 for ; Wed, 10 Feb 2021 23:49:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 614EE64E05 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 71EEB6EA6C; Wed, 10 Feb 2021 23:49:31 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7146F6EA6C; Wed, 10 Feb 2021 23:49:30 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 660B764E0B; Wed, 10 Feb 2021 23:49:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613000970; bh=DFd7DSXy7nWVxMi3ogNh04lyt3UKSNz0wPfFB3/Ikgk=; h=Date:From:To:Cc:Subject:From; b=RwE0EQrcXAXhRu1tEHQ5OhsgYK9JITPA5slwojL1+mXW77Z8/D7tRuDy1HrBeaNDi VSoq6CR/wVeUFMyFlVpogSpN78LwdeH5XGoLpMSHKSsAS39OBexHYcGz7nUI3cSElf pEhdAKrevf4lPyeCXeXC2xLVhsNo2ROTK8vxd6WVAJwem1bv+G36GDRLwJXdn7jQCA 6HG7oiRQ/xiXWpnelxJgLOzGhYUy0qDiZUPImb86cg+e57sZh1Z4tfOz3bTKymv2N8 Fq6+9zJNjKrznJWXV08nvgsPXEnSBZPFkS58LWHyMzO9Br/s54B6maQz3ZGArCPUPb vCxAkBdkPgidQ== Date: Wed, 10 Feb 2021 17:49:27 -0600 From: "Gustavo A. R. Silva" To: Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Daniel Vetter Subject: [PATCH][next] drm/radeon/nislands_smc.h: Replace one-element array with flexible-array member in struct NISLANDS_SMC_SWSTATE Message-ID: <20210210234927.GA68137@embeddedor> MIME-Version: 1.0 Content-Disposition: inline X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" VGhlcmUgaXMgYSByZWd1bGFyIG5lZWQgaW4gdGhlIGtlcm5lbCB0byBwcm92aWRlIGEgd2F5IHRv IGRlY2xhcmUgaGF2aW5nCmEgZHluYW1pY2FsbHkgc2l6ZWQgc2V0IG9mIHRyYWlsaW5nIGVsZW1l bnRzIGluIGEgc3RydWN0dXJlLiBLZXJuZWwgY29kZQpzaG91bGQgYWx3YXlzIHVzZSDigJxmbGV4 aWJsZSBhcnJheSBtZW1iZXJz4oCdWzFdIGZvciB0aGVzZSBjYXNlcy4gVGhlIG9sZGVyCnN0eWxl IG9mIG9uZS1lbGVtZW50IG9yIHplcm8tbGVuZ3RoIGFycmF5cyBzaG91bGQgbm8gbG9uZ2VyIGJl IHVzZWRbMl0uCgpVc2UgZmxleGlibGUtYXJyYXkgbWVtYmVyIGluIHN0cnVjdCBOSVNMQU5EU19T TUNfU1dTVEFURSwgaW5zdGVhZCBvZgpvbmUtZWxlbWVudCBhcnJheS4KCkFsc28sIHRoaXMgaGVs cHMgd2l0aCB0aGUgb25nb2luZyBlZmZvcnRzIHRvIGVuYWJsZSAtV2FycmF5LWJvdW5kcyBieQpm aXhpbmcgdGhlIGZvbGxvd2luZyB3YXJuaW5nczoKCmRyaXZlcnMvZ3B1L2RybS9yYWRlb24vbmlf ZHBtLmM6IEluIGZ1bmN0aW9uIOKAmG5pX2NvbnZlcnRfcG93ZXJfc3RhdGVfdG9fc21j4oCZOgpk cml2ZXJzL2dwdS9kcm0vcmFkZW9uL25pX2RwbS5jOjI1MjE6MjA6IHdhcm5pbmc6IGFycmF5IHN1 YnNjcmlwdCAxIGlzIGFib3ZlIGFycmF5IGJvdW5kcyBvZiDigJhOSVNMQU5EU19TTUNfSFdfUEVS Rk9STUFOQ0VfTEVWRUxbMV3igJkge2FrYSDigJhzdHJ1Y3QgTklTTEFORFNfU01DX0hXX1BFUkZP Uk1BTkNFX0xFVkVMWzFd4oCZfSBbLVdhcnJheS1ib3VuZHNdCiAyNTIxIHwgICBzbWNfc3RhdGUt PmxldmVsc1tpXS5kcG0yLk1heFBTID0KICAgICAgfCAgIH5+fn5+fn5+fn5+fn5+fn5+Xn5+CmRy aXZlcnMvZ3B1L2RybS9yYWRlb24vbmlfZHBtLmM6MjUyMzoyMDogd2FybmluZzogYXJyYXkgc3Vi c2NyaXB0IDEgaXMgYWJvdmUgYXJyYXkgYm91bmRzIG9mIOKAmE5JU0xBTkRTX1NNQ19IV19QRVJG T1JNQU5DRV9MRVZFTFsxXeKAmSB7YWthIOKAmHN0cnVjdCBOSVNMQU5EU19TTUNfSFdfUEVSRk9S TUFOQ0VfTEVWRUxbMV3igJl9IFstV2FycmF5LWJvdW5kc10KIDI1MjMgfCAgIHNtY19zdGF0ZS0+ bGV2ZWxzW2ldLmRwbTIuTmVhclREUERlYyA9IE5JU0xBTkRTX0RQTTJfTkVBUl9URFBfREVDOwog ICAgICB8ICAgfn5+fn5+fn5+fn5+fn5+fn5efn4KZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9uaV9k cG0uYzoyNTI0OjIwOiB3YXJuaW5nOiBhcnJheSBzdWJzY3JpcHQgMSBpcyBhYm92ZSBhcnJheSBi b3VuZHMgb2Yg4oCYTklTTEFORFNfU01DX0hXX1BFUkZPUk1BTkNFX0xFVkVMWzFd4oCZIHtha2Eg 4oCYc3RydWN0IE5JU0xBTkRTX1NNQ19IV19QRVJGT1JNQU5DRV9MRVZFTFsxXeKAmX0gWy1XYXJy YXktYm91bmRzXQogMjUyNCB8ICAgc21jX3N0YXRlLT5sZXZlbHNbaV0uZHBtMi5BYm92ZVNhZmVJ bmMgPSBOSVNMQU5EU19EUE0yX0FCT1ZFX1NBRkVfSU5DOwogICAgICB8ICAgfn5+fn5+fn5+fn5+ fn5+fn5efn4KZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9uaV9kcG0uYzoyNTI1OjIwOiB3YXJuaW5n OiBhcnJheSBzdWJzY3JpcHQgMSBpcyBhYm92ZSBhcnJheSBib3VuZHMgb2Yg4oCYTklTTEFORFNf U01DX0hXX1BFUkZPUk1BTkNFX0xFVkVMWzFd4oCZIHtha2Eg4oCYc3RydWN0IE5JU0xBTkRTX1NN Q19IV19QRVJGT1JNQU5DRV9MRVZFTFsxXeKAmX0gWy1XYXJyYXktYm91bmRzXQogMjUyNSB8ICAg c21jX3N0YXRlLT5sZXZlbHNbaV0uZHBtMi5CZWxvd1NhZmVJbmMgPSBOSVNMQU5EU19EUE0yX0JF TE9XX1NBRkVfSU5DOwogICAgICB8ICAgfn5+fn5+fn5+fn5+fn5+fn5efn4KZHJpdmVycy9ncHUv ZHJtL3JhZGVvbi9uaV9kcG0uYzoyNTI2OjM1OiB3YXJuaW5nOiBhcnJheSBzdWJzY3JpcHQgMSBp cyBhYm92ZSBhcnJheSBib3VuZHMgb2Yg4oCYTklTTEFORFNfU01DX0hXX1BFUkZPUk1BTkNFX0xF VkVMWzFd4oCZIHtha2Eg4oCYc3RydWN0IE5JU0xBTkRTX1NNQ19IV19QRVJGT1JNQU5DRV9MRVZF TFsxXeKAmX0gWy1XYXJyYXktYm91bmRzXQogMjUyNiB8ICAgc21jX3N0YXRlLT5sZXZlbHNbaV0u c3RhdGVGbGFncyB8PQogICAgICB8ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBe fgpkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL25pX2RwbS5jOjI1MjY6MzU6IHdhcm5pbmc6IGFycmF5 IHN1YnNjcmlwdCAxIGlzIGFib3ZlIGFycmF5IGJvdW5kcyBvZiDigJhOSVNMQU5EU19TTUNfSFdf UEVSRk9STUFOQ0VfTEVWRUxbMV3igJkge2FrYSDigJhzdHJ1Y3QgTklTTEFORFNfU01DX0hXX1BF UkZPUk1BTkNFX0xFVkVMWzFd4oCZfSBbLVdhcnJheS1ib3VuZHNdCiAyNTI2IHwgICBzbWNfc3Rh dGUtPmxldmVsc1tpXS5zdGF0ZUZsYWdzIHw9CiAgICAgIHwgICB+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fl5+CiAyNTI3IHwgICAgKChpICE9IChzdGF0ZS0+cGVyZm9ybWFuY2VfbGV2 ZWxfY291bnQgLSAxKSkgJiYgcG93ZXJfYm9vc3RfbGltaXQpID8KICAgICAgfCAgICB+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fgogMjUyOCB8ICAgIFBQU01DX1NUQVRFRkxBR19QT1dFUkJPT1NUIDogMDsKICAgICAgfCAg ICB+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn4KZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9u aV9kcG0uYzoyNDQyOjIwOiB3YXJuaW5nOiBhcnJheSBzdWJzY3JpcHQgMSBpcyBhYm92ZSBhcnJh eSBib3VuZHMgb2Yg4oCYTklTTEFORFNfU01DX0hXX1BFUkZPUk1BTkNFX0xFVkVMWzFd4oCZIHth a2Eg4oCYc3RydWN0IE5JU0xBTkRTX1NNQ19IV19QRVJGT1JNQU5DRV9MRVZFTFsxXeKAmX0gWy1X YXJyYXktYm91bmRzXQogMjQ0MiB8ICAgc21jX3N0YXRlLT5sZXZlbHNbaSArIDFdLmFUID0gY3B1 X3RvX2JlMzIoYV90KTsKClsxXSBodHRwczovL2VuLndpa2lwZWRpYS5vcmcvd2lraS9GbGV4aWJs ZV9hcnJheV9tZW1iZXIKWzJdIGh0dHBzOi8vd3d3Lmtlcm5lbC5vcmcvZG9jL2h0bWwvdjUuOS9w cm9jZXNzL2RlcHJlY2F0ZWQuaHRtbCN6ZXJvLWxlbmd0aC1hbmQtb25lLWVsZW1lbnQtYXJyYXlz CgpMaW5rOiBodHRwczovL2dpdGh1Yi5jb20vS1NQUC9saW51eC9pc3N1ZXMvNzkKTGluazogaHR0 cHM6Ly9naXRodWIuY29tL0tTUFAvbGludXgvaXNzdWVzLzEwOQpCdWlsZC10ZXN0ZWQtYnk6IGtl cm5lbCB0ZXN0IHJvYm90IDxsa3BAaW50ZWwuY29tPgpMaW5rOiBodHRwczovL2xvcmUua2VybmVs Lm9yZy9sa21sLzYwMjNlZDU0LkJmSVkrOVV6ODFJNm5xMTklMjVsa3BAaW50ZWwuY29tLwpTaWdu ZWQtb2ZmLWJ5OiBHdXN0YXZvIEEuIFIuIFNpbHZhIDxndXN0YXZvYXJzQGtlcm5lbC5vcmc+Ci0t LQogZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9uaXNsYW5kc19zbWMuaCB8IDEwICsrKysrLS0tLS0K IDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9uaXNsYW5kc19zbWMuaCBiL2RyaXZlcnMvZ3B1 L2RybS9yYWRlb24vbmlzbGFuZHNfc21jLmgKaW5kZXggM2NmOGZjMGQ4M2Y0Li43Mzk1Y2I2YjNj YWMgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vbmlzbGFuZHNfc21jLmgKKysr IGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9uaXNsYW5kc19zbWMuaApAQCAtMTM0LDExICsxMzQs MTEgQEAgdHlwZWRlZiBzdHJ1Y3QgTklTTEFORFNfU01DX0hXX1BFUkZPUk1BTkNFX0xFVkVMIE5J U0xBTkRTX1NNQ19IV19QRVJGT1JNQU5DRV9MRVYKIAogc3RydWN0IE5JU0xBTkRTX1NNQ19TV1NU QVRFCiB7Ci0gICAgdWludDhfdCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmxhZ3M7Ci0g ICAgdWludDhfdCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGV2ZWxDb3VudDsKLSAgICB1 aW50OF90ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYWRkaW5nMjsKLSAgICB1aW50OF90 ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYWRkaW5nMzsKLSAgICBOSVNMQU5EU19TTUNf SFdfUEVSRk9STUFOQ0VfTEVWRUwgICBsZXZlbHNbMV07CisJdWludDhfdCAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgZmxhZ3M7CisJdWludDhfdCAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgbGV2ZWxDb3VudDsKKwl1aW50OF90ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYWRk aW5nMjsKKwl1aW50OF90ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYWRkaW5nMzsKKwlO SVNMQU5EU19TTUNfSFdfUEVSRk9STUFOQ0VfTEVWRUwgICBsZXZlbHNbXTsKIH07CiAKIHR5cGVk ZWYgc3RydWN0IE5JU0xBTkRTX1NNQ19TV1NUQVRFIE5JU0xBTkRTX1NNQ19TV1NUQVRFOwotLSAK Mi4yNy4wCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK