From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v4 net-next 06/11] skbuff: remove __kfree_skb_flush()
Date: Thu, 11 Feb 2021 04:22:58 +0800 [thread overview]
Message-ID: <202102110431.DXxhZmxP-lkp@intel.com> (raw)
In-Reply-To: <20210210162732.80467-7-alobakin@pm.me>
[-- Attachment #1: Type: text/plain, Size: 3768 bytes --]
Hi Alexander,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/Alexander-Lobakin/skbuff-introduce-skbuff_heads-bulking-and-reusing/20210211-004041
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git de1db4a6ed6241e34cab0e5059d4b56f6bae39b9
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/6bb224307d9f31afa154a8825f9acbd8e9f6b490
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Alexander-Lobakin/skbuff-introduce-skbuff_heads-bulking-and-reusing/20210211-004041
git checkout 6bb224307d9f31afa154a8825f9acbd8e9f6b490
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
net/core/dev.c: In function 'napi_threaded_poll':
>> net/core/dev.c:7012:4: error: implicit declaration of function '__kfree_skb_flush'; did you mean '__kfree_skb_defer'? [-Werror=implicit-function-declaration]
7012 | __kfree_skb_flush();
| ^~~~~~~~~~~~~~~~~
| __kfree_skb_defer
cc1: some warnings being treated as errors
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
Selected by
- SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
- SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC
vim +7012 net/core/dev.c
29863d41bb6e1d Wei Wang 2021-02-08 6996
29863d41bb6e1d Wei Wang 2021-02-08 6997 static int napi_threaded_poll(void *data)
29863d41bb6e1d Wei Wang 2021-02-08 6998 {
29863d41bb6e1d Wei Wang 2021-02-08 6999 struct napi_struct *napi = data;
29863d41bb6e1d Wei Wang 2021-02-08 7000 void *have;
29863d41bb6e1d Wei Wang 2021-02-08 7001
29863d41bb6e1d Wei Wang 2021-02-08 7002 while (!napi_thread_wait(napi)) {
29863d41bb6e1d Wei Wang 2021-02-08 7003 for (;;) {
29863d41bb6e1d Wei Wang 2021-02-08 7004 bool repoll = false;
29863d41bb6e1d Wei Wang 2021-02-08 7005
29863d41bb6e1d Wei Wang 2021-02-08 7006 local_bh_disable();
29863d41bb6e1d Wei Wang 2021-02-08 7007
29863d41bb6e1d Wei Wang 2021-02-08 7008 have = netpoll_poll_lock(napi);
29863d41bb6e1d Wei Wang 2021-02-08 7009 __napi_poll(napi, &repoll);
29863d41bb6e1d Wei Wang 2021-02-08 7010 netpoll_poll_unlock(have);
29863d41bb6e1d Wei Wang 2021-02-08 7011
29863d41bb6e1d Wei Wang 2021-02-08 @7012 __kfree_skb_flush();
29863d41bb6e1d Wei Wang 2021-02-08 7013 local_bh_enable();
29863d41bb6e1d Wei Wang 2021-02-08 7014
29863d41bb6e1d Wei Wang 2021-02-08 7015 if (!repoll)
29863d41bb6e1d Wei Wang 2021-02-08 7016 break;
29863d41bb6e1d Wei Wang 2021-02-08 7017
29863d41bb6e1d Wei Wang 2021-02-08 7018 cond_resched();
29863d41bb6e1d Wei Wang 2021-02-08 7019 }
29863d41bb6e1d Wei Wang 2021-02-08 7020 }
29863d41bb6e1d Wei Wang 2021-02-08 7021 return 0;
29863d41bb6e1d Wei Wang 2021-02-08 7022 }
29863d41bb6e1d Wei Wang 2021-02-08 7023
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 54007 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Alexander Lobakin <alobakin@pm.me>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: kbuild-all@lists.01.org, netdev@vger.kernel.org,
Jonathan Lemon <jonathan.lemon@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Willem de Bruijn <willemb@google.com>,
Alexander Lobakin <alobakin@pm.me>,
Randy Dunlap <rdunlap@infradead.org>,
Kevin Hao <haokexin@gmail.com>
Subject: Re: [PATCH v4 net-next 06/11] skbuff: remove __kfree_skb_flush()
Date: Thu, 11 Feb 2021 04:22:58 +0800 [thread overview]
Message-ID: <202102110431.DXxhZmxP-lkp@intel.com> (raw)
In-Reply-To: <20210210162732.80467-7-alobakin@pm.me>
[-- Attachment #1: Type: text/plain, Size: 3692 bytes --]
Hi Alexander,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/Alexander-Lobakin/skbuff-introduce-skbuff_heads-bulking-and-reusing/20210211-004041
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git de1db4a6ed6241e34cab0e5059d4b56f6bae39b9
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/6bb224307d9f31afa154a8825f9acbd8e9f6b490
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Alexander-Lobakin/skbuff-introduce-skbuff_heads-bulking-and-reusing/20210211-004041
git checkout 6bb224307d9f31afa154a8825f9acbd8e9f6b490
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
net/core/dev.c: In function 'napi_threaded_poll':
>> net/core/dev.c:7012:4: error: implicit declaration of function '__kfree_skb_flush'; did you mean '__kfree_skb_defer'? [-Werror=implicit-function-declaration]
7012 | __kfree_skb_flush();
| ^~~~~~~~~~~~~~~~~
| __kfree_skb_defer
cc1: some warnings being treated as errors
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
Selected by
- SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
- SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC
vim +7012 net/core/dev.c
29863d41bb6e1d Wei Wang 2021-02-08 6996
29863d41bb6e1d Wei Wang 2021-02-08 6997 static int napi_threaded_poll(void *data)
29863d41bb6e1d Wei Wang 2021-02-08 6998 {
29863d41bb6e1d Wei Wang 2021-02-08 6999 struct napi_struct *napi = data;
29863d41bb6e1d Wei Wang 2021-02-08 7000 void *have;
29863d41bb6e1d Wei Wang 2021-02-08 7001
29863d41bb6e1d Wei Wang 2021-02-08 7002 while (!napi_thread_wait(napi)) {
29863d41bb6e1d Wei Wang 2021-02-08 7003 for (;;) {
29863d41bb6e1d Wei Wang 2021-02-08 7004 bool repoll = false;
29863d41bb6e1d Wei Wang 2021-02-08 7005
29863d41bb6e1d Wei Wang 2021-02-08 7006 local_bh_disable();
29863d41bb6e1d Wei Wang 2021-02-08 7007
29863d41bb6e1d Wei Wang 2021-02-08 7008 have = netpoll_poll_lock(napi);
29863d41bb6e1d Wei Wang 2021-02-08 7009 __napi_poll(napi, &repoll);
29863d41bb6e1d Wei Wang 2021-02-08 7010 netpoll_poll_unlock(have);
29863d41bb6e1d Wei Wang 2021-02-08 7011
29863d41bb6e1d Wei Wang 2021-02-08 @7012 __kfree_skb_flush();
29863d41bb6e1d Wei Wang 2021-02-08 7013 local_bh_enable();
29863d41bb6e1d Wei Wang 2021-02-08 7014
29863d41bb6e1d Wei Wang 2021-02-08 7015 if (!repoll)
29863d41bb6e1d Wei Wang 2021-02-08 7016 break;
29863d41bb6e1d Wei Wang 2021-02-08 7017
29863d41bb6e1d Wei Wang 2021-02-08 7018 cond_resched();
29863d41bb6e1d Wei Wang 2021-02-08 7019 }
29863d41bb6e1d Wei Wang 2021-02-08 7020 }
29863d41bb6e1d Wei Wang 2021-02-08 7021 return 0;
29863d41bb6e1d Wei Wang 2021-02-08 7022 }
29863d41bb6e1d Wei Wang 2021-02-08 7023
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 54007 bytes --]
next prev parent reply other threads:[~2021-02-10 20:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 16:28 [PATCH v4 net-next 00/11] skbuff: introduce skbuff_heads bulking and reusing Alexander Lobakin
2021-02-10 16:28 ` [PATCH v4 net-next 01/11] skbuff: move __alloc_skb() next to the other skb allocation functions Alexander Lobakin
2021-02-10 16:28 ` [PATCH v4 net-next 02/11] skbuff: simplify kmalloc_reserve() Alexander Lobakin
2021-02-10 16:29 ` [PATCH v4 net-next 03/11] skbuff: make __build_skb_around() return void Alexander Lobakin
2021-02-10 16:29 ` [PATCH v4 net-next 04/11] skbuff: simplify __alloc_skb() a bit Alexander Lobakin
2021-02-10 16:29 ` [PATCH v4 net-next 05/11] skbuff: use __build_skb_around() in __alloc_skb() Alexander Lobakin
2021-02-10 16:29 ` [PATCH v4 net-next 06/11] skbuff: remove __kfree_skb_flush() Alexander Lobakin
2021-02-10 20:22 ` kernel test robot [this message]
2021-02-10 20:22 ` kernel test robot
2021-02-11 0:19 ` kernel test robot
2021-02-11 0:19 ` kernel test robot
2021-02-10 16:30 ` [PATCH v4 net-next 07/11] skbuff: move NAPI cache declarations upper in the file Alexander Lobakin
2021-02-10 16:30 ` [PATCH v4 net-next 08/11] skbuff: introduce {,__}napi_build_skb() which reuses NAPI cache heads Alexander Lobakin
2021-02-11 12:54 ` Jesper Dangaard Brouer
2021-02-11 14:38 ` Alexander Lobakin
2021-02-10 16:30 ` [PATCH v4 net-next 09/11] skbuff: allow to optionally use NAPI cache from __alloc_skb() Alexander Lobakin
2021-02-11 10:16 ` Paolo Abeni
2021-02-11 14:28 ` Alexander Lobakin
2021-02-11 14:55 ` Paolo Abeni
2021-02-11 15:26 ` Alexander Lobakin
2021-02-10 16:30 ` [PATCH v4 net-next 10/11] skbuff: allow to use NAPI cache from __napi_alloc_skb() Alexander Lobakin
2021-02-10 16:31 ` [PATCH v4 net-next 11/11] skbuff: queue NAPI_MERGED_FREE skbs into NAPI cache instead of freeing Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202102110431.DXxhZmxP-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.