From: Dan Carpenter <dan.carpenter@oracle.com>
To: karthik alapati <mail@karthek.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: remove obsolete commented out code
Date: Thu, 11 Feb 2021 10:57:15 +0300 [thread overview]
Message-ID: <20210211075715.GD2696@kadam> (raw)
In-Reply-To: <YCQvsdlnbnQN4Ruf@karthik-strix-linux.karthek.com>
On Thu, Feb 11, 2021 at 12:40:41AM +0530, karthik alapati wrote:
> @@ -867,10 +845,8 @@ static void PHY_HandleSwChnlAndSetBW8723B(
> if (bSetBandWidth)
> pHalData->bSetChnlBW = true;
>
> - if (!pHalData->bSetChnlBW && !pHalData->bSwChnl) {
> - /* DBG_871X("<= PHY_HandleSwChnlAndSetBW8812: bSwChnl %d, bSetChnlBW %d\n", pHalData->bSwChnl, pHalData->bSetChnlBW); */
> + if (!pHalData->bSetChnlBW && !pHalData->bSwChnl)
> return;
> - }
In this case, the + line is correct. Good job.
>
>
> if (pHalData->bSwChnl) {
> @@ -929,9 +905,7 @@ void PHY_SetSwChnlBWMode8723B(
> u8 Offset80
> )
> {
> - /* DBG_871X("%s() ===>\n", __func__); */
>
> PHY_HandleSwChnlAndSetBW8723B(Adapter, true, true, channel, Bandwidth, Offset40, Offset80, channel);
>
> - /* DBG_871X("<==%s()\n", __func__); */
Please delete the blank lines as well.
regards,
dan carpenter
next prev parent reply other threads:[~2021-02-11 8:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 19:10 [PATCH] staging: rtl8723bs: remove obsolete commented out code karthik alapati
2021-02-10 19:19 ` karthek
2021-02-11 7:42 ` Dan Carpenter
2021-02-11 7:53 ` Dan Carpenter
2021-02-11 7:57 ` Dan Carpenter [this message]
2021-02-11 10:30 ` karthek
2021-02-11 10:46 ` Greg Kroah-Hartman
2021-02-11 10:50 ` karthek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210211075715.GD2696@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@karthek.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.