From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A4AEC433E0 for ; Thu, 11 Feb 2021 08:04:32 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B5CF64E77 for ; Thu, 11 Feb 2021 08:04:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B5CF64E77 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 184CE6F631 for ; Thu, 11 Feb 2021 08:04:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yJOyItHnrcyH for ; Thu, 11 Feb 2021 08:04:29 +0000 (UTC) Received: by smtp3.osuosl.org (Postfix, from userid 1001) id 842496F5A3; Thu, 11 Feb 2021 08:04:28 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTP id ED4306F4F8; Thu, 11 Feb 2021 08:04:24 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id BB1A3C0174; Thu, 11 Feb 2021 08:04:24 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id CD40DC013A for ; Thu, 11 Feb 2021 08:04:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id AC0336EE12 for ; Thu, 11 Feb 2021 08:04:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wJNIa3nQha1V for ; Thu, 11 Feb 2021 08:04:22 +0000 (UTC) Received: by smtp3.osuosl.org (Postfix, from userid 1001) id D2D786F4F9; Thu, 11 Feb 2021 08:04:22 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by smtp3.osuosl.org (Postfix) with ESMTPS id 6D2C86EE12 for ; Thu, 11 Feb 2021 08:04:21 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 244AE68BFE; Thu, 11 Feb 2021 09:04:17 +0100 (CET) Date: Thu, 11 Feb 2021 09:04:17 +0100 From: Christoph Hellwig To: Anshuman Khandual Subject: Re: [PATCH 3/3] dma-contiguous: Type cast MAX_ORDER as unsigned int Message-ID: <20210211080417.GC14448@lst.de> References: <1613024531-19040-1-git-send-email-anshuman.khandual@arm.com> <1613024531-19040-4-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1613024531-19040-4-git-send-email-anshuman.khandual@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Mark Rutland , David Hildenbrand , Robin Murphy , linux-kernel@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, catalin.marinas@arm.com, akpm@linux-foundation.org, will@kernel.org, Christoph Hellwig , linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" T24gVGh1LCBGZWIgMTEsIDIwMjEgYXQgMTE6NTI6MTFBTSArMDUzMCwgQW5zaHVtYW4gS2hhbmR1 YWwgd3JvdGU6Cj4gVHlwZSBjYXN0IE1BWF9PUkRFUiBhcyB1bnNpZ25lZCBpbnQgdG8gZml4IHRo ZSBmb2xsb3dpbmcgYnVpbGQgd2FybmluZy4KPiAKPiBJbiBmaWxlIGluY2x1ZGVkIGZyb20gLi9p bmNsdWRlL2xpbnV4L2tlcm5lbC5oOjE0LAo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1 ZGUvYXNtLWdlbmVyaWMvYnVnLmg6MjAsCj4gICAgICAgICAgICAgICAgICBmcm9tIC4vYXJjaC9h cm02NC9pbmNsdWRlL2FzbS9idWcuaDoyNiwKPiAgICAgICAgICAgICAgICAgIGZyb20gLi9pbmNs dWRlL2xpbnV4L2J1Zy5oOjUsCj4gICAgICAgICAgICAgICAgICBmcm9tIC4vaW5jbHVkZS9saW51 eC9tbWRlYnVnLmg6NSwKPiAgICAgICAgICAgICAgICAgIGZyb20gLi9hcmNoL2FybTY0L2luY2x1 ZGUvYXNtL21lbW9yeS5oOjE2NiwKPiAgICAgICAgICAgICAgICAgIGZyb20gLi9hcmNoL2FybTY0 L2luY2x1ZGUvYXNtL3BhZ2UuaDo0MiwKPiAgICAgICAgICAgICAgICAgIGZyb20ga2VybmVsL2Rt YS9jb250aWd1b3VzLmM6NDY6Cj4ga2VybmVsL2RtYS9jb250aWd1b3VzLmM6IEluIGZ1bmN0aW9u IOKAmHJtZW1fY21hX3NldHVw4oCZOgo+IC4vaW5jbHVkZS9saW51eC9taW5tYXguaDoxODoyODog d2FybmluZzogY29tcGFyaXNvbiBvZiBkaXN0aW5jdCBwb2ludGVyCj4gdHlwZXMgbGFja3MgYSBj YXN0Cj4gICAoISEoc2l6ZW9mKCh0eXBlb2YoeCkgKikxID09ICh0eXBlb2YoeSkgKikxKSkpCj4g ICAgICAgICAgICAgICAgICAgICAgICAgICAgIF5+Cj4gLi9pbmNsdWRlL2xpbnV4L21pbm1heC5o OjMyOjQ6IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBtYWNybyDigJhfX3R5cGVjaGVja+KAmQo+ICAg IChfX3R5cGVjaGVjayh4LCB5KSAmJiBfX25vX3NpZGVfZWZmZWN0cyh4LCB5KSkKPiAgICAgXn5+ fn5+fn5+fn4KPiAuL2luY2x1ZGUvbGludXgvbWlubWF4Lmg6NDI6MjQ6IG5vdGU6IGluIGV4cGFu c2lvbiBvZiBtYWNybyDigJhfX3NhZmVfY21w4oCZCj4gICBfX2J1aWx0aW5fY2hvb3NlX2V4cHIo X19zYWZlX2NtcCh4LCB5KSwgXAo+ICAgICAgICAgICAgICAgICAgICAgICAgIF5+fn5+fn5+fn4K PiAuL2luY2x1ZGUvbGludXgvbWlubWF4Lmg6NTg6MTk6IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBt YWNybwo+IOKAmF9fY2FyZWZ1bF9jbXDigJkKPiAgI2RlZmluZSBtYXgoeCwgeSkgX19jYXJlZnVs X2NtcCh4LCB5LCA+KQo+ICAgICAgICAgICAgICAgICAgICBefn5+fn5+fn5+fn5+Cj4ga2VybmVs L2RtYS9jb250aWd1b3VzLmM6NDAyOjM1OiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFjcm8g4oCY bWF44oCZCj4gICBwaHlzX2FkZHJfdCBhbGlnbiA9IFBBR0VfU0laRSA8PCBtYXgoTUFYX09SREVS IC0gMSwgcGFnZWJsb2NrX29yZGVyKTsKPiAKPiBDYzogQ2hyaXN0b3BoIEhlbGx3aWcgPGhjaEBs c3QuZGU+Cj4gQ2M6IE1hcmVrIFN6eXByb3dza2kgPG0uc3p5cHJvd3NraUBzYW1zdW5nLmNvbT4K PiBDYzogUm9iaW4gTXVycGh5IDxyb2Jpbi5tdXJwaHlAYXJtLmNvbT4KPiBDYzogaW9tbXVAbGlz dHMubGludXgtZm91bmRhdGlvbi5vcmcKPiBDYzogbGludXgta2VybmVsQHZnZXIua2VybmVsLm9y Zwo+IFNpZ25lZC1vZmYtYnk6IEFuc2h1bWFuIEtoYW5kdWFsIDxhbnNodW1hbi5raGFuZHVhbEBh cm0uY29tPgo+IC0tLQo+ICBrZXJuZWwvZG1hL2NvbnRpZ3VvdXMuYyB8IDIgKy0KPiAgMSBmaWxl IGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBh L2tlcm5lbC9kbWEvY29udGlndW91cy5jIGIva2VybmVsL2RtYS9jb250aWd1b3VzLmMKPiBpbmRl eCAzZDYzZDkxY2JhNWMuLjFjMjc4MjM0OWQ3MSAxMDA2NDQKPiAtLS0gYS9rZXJuZWwvZG1hL2Nv bnRpZ3VvdXMuYwo+ICsrKyBiL2tlcm5lbC9kbWEvY29udGlndW91cy5jCj4gQEAgLTM5OSw3ICsz OTksNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHJlc2VydmVkX21lbV9vcHMgcm1lbV9jbWFfb3Bz ID0gewo+ICAKPiAgc3RhdGljIGludCBfX2luaXQgcm1lbV9jbWFfc2V0dXAoc3RydWN0IHJlc2Vy dmVkX21lbSAqcm1lbSkKPiAgewo+IC0JcGh5c19hZGRyX3QgYWxpZ24gPSBQQUdFX1NJWkUgPDwg bWF4KE1BWF9PUkRFUiAtIDEsIHBhZ2VibG9ja19vcmRlcik7Cj4gKwlwaHlzX2FkZHJfdCBhbGln biA9IFBBR0VfU0laRSA8PCBtYXgoKHVuc2lnbmVkIGludClNQVhfT1JERVIgLSAxLCBwYWdlYmxv Y2tfb3JkZXIpOwoKTUFYX09SREVSIGFuZCBwYWdlYmxvY2tfb3JkZXIgc2hvdWxkIGJlIHRoZSBz YW1lIHR5cGUuICBTbyBlaXRoZXIgZml4Ck1BWF9PUkRFUiB0byBiZSBhbiB1bnNpZ25lZCBjb25z dGFudCwgd2hpY2ggd291bGQgYmUgZnVuZGFtZW50YWxseQp0aGUgcmlnaHQgdGhpbmcgdG8gZG8g YnV0IG1pZ2h0IGNhdXNlIHNvbWUgZmFsbG91dCwgb3IgdHVybgpwYWdlYmxvY2tfb3JkZXIgaW50 byBhbiBpbnQsIHdoaWNoIGlzIHByb2JhYmx5IG11Y2ggZWl0aGVyIGFzIHRoZSBzdHViCmRlZmlu ZSBvZiBpdCBhbHJlYWR5IGhhcyBhbiBpbnRlZ2VyIHR5cGUgZGVyaXZlZCBmcm9tIE1BWF9PUkRF UiBhcyB3ZWxsLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Xwppb21tdSBtYWlsaW5nIGxpc3QKaW9tbXVAbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0 cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vaW9tbXU= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02F96C433E0 for ; Thu, 11 Feb 2021 08:05:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA67964E7D for ; Thu, 11 Feb 2021 08:05:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA67964E7D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=a/UqbXFAMNsSoYKC3IK86QJf+Fq2mI7WE6pSxFUIP+M=; b=bsVvZn35+CSXNxZ6h32VFb4Jj 0FNWYuPa+s5H4T6DSpPR42TfpAqn07TseJC1CkyIqnwzmCgrPVejB4OwJKGKXmTCbEOVNmaYDUPg1 1IcuSUGSRQK020cCAIHCQ/KX5OVOO4DcjYA0sXsM92roUCKB3qmksrbL3UjMcAtIycfKV2GVAYgRh 5+KWsZMIOxc9wpZ6j1T+Que9nUuZjugATuHfXG5cZCn4F2eMfncfGIs2Xq/RC4X6Uam2MHTbO3kiD cN3xhGtIDu2cYQBiE8Z+MftI5NLByIbyf9y5wVdDtSSPIbDga+o+caUDBzxtKBU6G6l6gKxG2GeiI /IP3wIP0g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lA6xc-0007Ip-Rs; Thu, 11 Feb 2021 08:04:24 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lA6xZ-0007Hr-Iw for linux-arm-kernel@lists.infradead.org; Thu, 11 Feb 2021 08:04:22 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 244AE68BFE; Thu, 11 Feb 2021 09:04:17 +0100 (CET) Date: Thu, 11 Feb 2021 09:04:17 +0100 From: Christoph Hellwig To: Anshuman Khandual Subject: Re: [PATCH 3/3] dma-contiguous: Type cast MAX_ORDER as unsigned int Message-ID: <20210211080417.GC14448@lst.de> References: <1613024531-19040-1-git-send-email-anshuman.khandual@arm.com> <1613024531-19040-4-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1613024531-19040-4-git-send-email-anshuman.khandual@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210211_030421_841537_75E645DA X-CRM114-Status: GOOD ( 20.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , David Hildenbrand , Robin Murphy , linux-kernel@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, catalin.marinas@arm.com, akpm@linux-foundation.org, will@kernel.org, Christoph Hellwig , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBGZWIgMTEsIDIwMjEgYXQgMTE6NTI6MTFBTSArMDUzMCwgQW5zaHVtYW4gS2hhbmR1 YWwgd3JvdGU6Cj4gVHlwZSBjYXN0IE1BWF9PUkRFUiBhcyB1bnNpZ25lZCBpbnQgdG8gZml4IHRo ZSBmb2xsb3dpbmcgYnVpbGQgd2FybmluZy4KPiAKPiBJbiBmaWxlIGluY2x1ZGVkIGZyb20gLi9p bmNsdWRlL2xpbnV4L2tlcm5lbC5oOjE0LAo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1 ZGUvYXNtLWdlbmVyaWMvYnVnLmg6MjAsCj4gICAgICAgICAgICAgICAgICBmcm9tIC4vYXJjaC9h cm02NC9pbmNsdWRlL2FzbS9idWcuaDoyNiwKPiAgICAgICAgICAgICAgICAgIGZyb20gLi9pbmNs dWRlL2xpbnV4L2J1Zy5oOjUsCj4gICAgICAgICAgICAgICAgICBmcm9tIC4vaW5jbHVkZS9saW51 eC9tbWRlYnVnLmg6NSwKPiAgICAgICAgICAgICAgICAgIGZyb20gLi9hcmNoL2FybTY0L2luY2x1 ZGUvYXNtL21lbW9yeS5oOjE2NiwKPiAgICAgICAgICAgICAgICAgIGZyb20gLi9hcmNoL2FybTY0 L2luY2x1ZGUvYXNtL3BhZ2UuaDo0MiwKPiAgICAgICAgICAgICAgICAgIGZyb20ga2VybmVsL2Rt YS9jb250aWd1b3VzLmM6NDY6Cj4ga2VybmVsL2RtYS9jb250aWd1b3VzLmM6IEluIGZ1bmN0aW9u IOKAmHJtZW1fY21hX3NldHVw4oCZOgo+IC4vaW5jbHVkZS9saW51eC9taW5tYXguaDoxODoyODog d2FybmluZzogY29tcGFyaXNvbiBvZiBkaXN0aW5jdCBwb2ludGVyCj4gdHlwZXMgbGFja3MgYSBj YXN0Cj4gICAoISEoc2l6ZW9mKCh0eXBlb2YoeCkgKikxID09ICh0eXBlb2YoeSkgKikxKSkpCj4g ICAgICAgICAgICAgICAgICAgICAgICAgICAgIF5+Cj4gLi9pbmNsdWRlL2xpbnV4L21pbm1heC5o OjMyOjQ6IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBtYWNybyDigJhfX3R5cGVjaGVja+KAmQo+ICAg IChfX3R5cGVjaGVjayh4LCB5KSAmJiBfX25vX3NpZGVfZWZmZWN0cyh4LCB5KSkKPiAgICAgXn5+ fn5+fn5+fn4KPiAuL2luY2x1ZGUvbGludXgvbWlubWF4Lmg6NDI6MjQ6IG5vdGU6IGluIGV4cGFu c2lvbiBvZiBtYWNybyDigJhfX3NhZmVfY21w4oCZCj4gICBfX2J1aWx0aW5fY2hvb3NlX2V4cHIo X19zYWZlX2NtcCh4LCB5KSwgXAo+ICAgICAgICAgICAgICAgICAgICAgICAgIF5+fn5+fn5+fn4K PiAuL2luY2x1ZGUvbGludXgvbWlubWF4Lmg6NTg6MTk6IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBt YWNybwo+IOKAmF9fY2FyZWZ1bF9jbXDigJkKPiAgI2RlZmluZSBtYXgoeCwgeSkgX19jYXJlZnVs X2NtcCh4LCB5LCA+KQo+ICAgICAgICAgICAgICAgICAgICBefn5+fn5+fn5+fn5+Cj4ga2VybmVs L2RtYS9jb250aWd1b3VzLmM6NDAyOjM1OiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFjcm8g4oCY bWF44oCZCj4gICBwaHlzX2FkZHJfdCBhbGlnbiA9IFBBR0VfU0laRSA8PCBtYXgoTUFYX09SREVS IC0gMSwgcGFnZWJsb2NrX29yZGVyKTsKPiAKPiBDYzogQ2hyaXN0b3BoIEhlbGx3aWcgPGhjaEBs c3QuZGU+Cj4gQ2M6IE1hcmVrIFN6eXByb3dza2kgPG0uc3p5cHJvd3NraUBzYW1zdW5nLmNvbT4K PiBDYzogUm9iaW4gTXVycGh5IDxyb2Jpbi5tdXJwaHlAYXJtLmNvbT4KPiBDYzogaW9tbXVAbGlz dHMubGludXgtZm91bmRhdGlvbi5vcmcKPiBDYzogbGludXgta2VybmVsQHZnZXIua2VybmVsLm9y Zwo+IFNpZ25lZC1vZmYtYnk6IEFuc2h1bWFuIEtoYW5kdWFsIDxhbnNodW1hbi5raGFuZHVhbEBh cm0uY29tPgo+IC0tLQo+ICBrZXJuZWwvZG1hL2NvbnRpZ3VvdXMuYyB8IDIgKy0KPiAgMSBmaWxl IGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBh L2tlcm5lbC9kbWEvY29udGlndW91cy5jIGIva2VybmVsL2RtYS9jb250aWd1b3VzLmMKPiBpbmRl eCAzZDYzZDkxY2JhNWMuLjFjMjc4MjM0OWQ3MSAxMDA2NDQKPiAtLS0gYS9rZXJuZWwvZG1hL2Nv bnRpZ3VvdXMuYwo+ICsrKyBiL2tlcm5lbC9kbWEvY29udGlndW91cy5jCj4gQEAgLTM5OSw3ICsz OTksNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHJlc2VydmVkX21lbV9vcHMgcm1lbV9jbWFfb3Bz ID0gewo+ICAKPiAgc3RhdGljIGludCBfX2luaXQgcm1lbV9jbWFfc2V0dXAoc3RydWN0IHJlc2Vy dmVkX21lbSAqcm1lbSkKPiAgewo+IC0JcGh5c19hZGRyX3QgYWxpZ24gPSBQQUdFX1NJWkUgPDwg bWF4KE1BWF9PUkRFUiAtIDEsIHBhZ2VibG9ja19vcmRlcik7Cj4gKwlwaHlzX2FkZHJfdCBhbGln biA9IFBBR0VfU0laRSA8PCBtYXgoKHVuc2lnbmVkIGludClNQVhfT1JERVIgLSAxLCBwYWdlYmxv Y2tfb3JkZXIpOwoKTUFYX09SREVSIGFuZCBwYWdlYmxvY2tfb3JkZXIgc2hvdWxkIGJlIHRoZSBz YW1lIHR5cGUuICBTbyBlaXRoZXIgZml4Ck1BWF9PUkRFUiB0byBiZSBhbiB1bnNpZ25lZCBjb25z dGFudCwgd2hpY2ggd291bGQgYmUgZnVuZGFtZW50YWxseQp0aGUgcmlnaHQgdGhpbmcgdG8gZG8g YnV0IG1pZ2h0IGNhdXNlIHNvbWUgZmFsbG91dCwgb3IgdHVybgpwYWdlYmxvY2tfb3JkZXIgaW50 byBhbiBpbnQsIHdoaWNoIGlzIHByb2JhYmx5IG11Y2ggZWl0aGVyIGFzIHRoZSBzdHViCmRlZmlu ZSBvZiBpdCBhbHJlYWR5IGhhcyBhbiBpbnRlZ2VyIHR5cGUgZGVyaXZlZCBmcm9tIE1BWF9PUkRF UiBhcyB3ZWxsLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14557C433E0 for ; Thu, 11 Feb 2021 08:04:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 889E564E7C for ; Thu, 11 Feb 2021 08:04:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 889E564E7C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E41846B0092; Thu, 11 Feb 2021 03:04:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DF0AF6B0093; Thu, 11 Feb 2021 03:04:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2D656B0095; Thu, 11 Feb 2021 03:04:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0090.hostedemail.com [216.40.44.90]) by kanga.kvack.org (Postfix) with ESMTP id BE40E6B0092 for ; Thu, 11 Feb 2021 03:04:21 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 85AC7180AD807 for ; Thu, 11 Feb 2021 08:04:21 +0000 (UTC) X-FDA: 77805249522.28.CAA361F Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf18.hostedemail.com (Postfix) with ESMTP id 5437F20001EA for ; Thu, 11 Feb 2021 08:04:20 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 244AE68BFE; Thu, 11 Feb 2021 09:04:17 +0100 (CET) Date: Thu, 11 Feb 2021 09:04:17 +0100 From: Christoph Hellwig To: Anshuman Khandual Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, akpm@linux-foundation.org, will@kernel.org, Robin Murphy , Marek Szyprowski , Christoph Hellwig , David Hildenbrand , Mark Rutland , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] dma-contiguous: Type cast MAX_ORDER as unsigned int Message-ID: <20210211080417.GC14448@lst.de> References: <1613024531-19040-1-git-send-email-anshuman.khandual@arm.com> <1613024531-19040-4-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1613024531-19040-4-git-send-email-anshuman.khandual@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Stat-Signature: xqufhxjxzerixdmudwb58h9p9j43q55e X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5437F20001EA Received-SPF: none (lst.de>: No applicable sender policy available) receiver=imf18; identity=mailfrom; envelope-from=""; helo=verein.lst.de; client-ip=213.95.11.211 X-HE-DKIM-Result: none/none X-HE-Tag: 1613030660-104571 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 11, 2021 at 11:52:11AM +0530, Anshuman Khandual wrote: > Type cast MAX_ORDER as unsigned int to fix the following build warning. >=20 > In file included from ./include/linux/kernel.h:14, > from ./include/asm-generic/bug.h:20, > from ./arch/arm64/include/asm/bug.h:26, > from ./include/linux/bug.h:5, > from ./include/linux/mmdebug.h:5, > from ./arch/arm64/include/asm/memory.h:166, > from ./arch/arm64/include/asm/page.h:42, > from kernel/dma/contiguous.c:46: > kernel/dma/contiguous.c: In function =E2=80=98rmem_cma_setup=E2=80=99: > ./include/linux/minmax.h:18:28: warning: comparison of distinct pointer > types lacks a cast > (!!(sizeof((typeof(x) *)1 =3D=3D (typeof(y) *)1))) > ^~ > ./include/linux/minmax.h:32:4: note: in expansion of macro =E2=80=98__t= ypecheck=E2=80=99 > (__typecheck(x, y) && __no_side_effects(x, y)) > ^~~~~~~~~~~ > ./include/linux/minmax.h:42:24: note: in expansion of macro =E2=80=98__= safe_cmp=E2=80=99 > __builtin_choose_expr(__safe_cmp(x, y), \ > ^~~~~~~~~~ > ./include/linux/minmax.h:58:19: note: in expansion of macro > =E2=80=98__careful_cmp=E2=80=99 > #define max(x, y) __careful_cmp(x, y, >) > ^~~~~~~~~~~~~ > kernel/dma/contiguous.c:402:35: note: in expansion of macro =E2=80=98ma= x=E2=80=99 > phys_addr_t align =3D PAGE_SIZE << max(MAX_ORDER - 1, pageblock_order= ); >=20 > Cc: Christoph Hellwig > Cc: Marek Szyprowski > Cc: Robin Murphy > Cc: iommu@lists.linux-foundation.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > kernel/dma/contiguous.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/kernel/dma/contiguous.c b/kernel/dma/contiguous.c > index 3d63d91cba5c..1c2782349d71 100644 > --- a/kernel/dma/contiguous.c > +++ b/kernel/dma/contiguous.c > @@ -399,7 +399,7 @@ static const struct reserved_mem_ops rmem_cma_ops =3D= { > =20 > static int __init rmem_cma_setup(struct reserved_mem *rmem) > { > - phys_addr_t align =3D PAGE_SIZE << max(MAX_ORDER - 1, pageblock_order= ); > + phys_addr_t align =3D PAGE_SIZE << max((unsigned int)MAX_ORDER - 1, p= ageblock_order); MAX_ORDER and pageblock_order should be the same type. So either fix MAX_ORDER to be an unsigned constant, which would be fundamentally the right thing to do but might cause some fallout, or turn pageblock_order into an int, which is probably much either as the stub define of it already has an integer type derived from MAX_ORDER as well.