From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Igor Russkikh <irusskikh@marvell.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
brouer@redhat.com, "Daniel T. Lee" <danieltimlee@gmail.com>
Subject: Re: [EXT] Re: [PATCH v2 net-next 1/2] samples: pktgen: allow to specify delay parameter via new opt
Date: Fri, 12 Feb 2021 08:09:27 +0100 [thread overview]
Message-ID: <20210212080927.008fd4c8@carbon> (raw)
In-Reply-To: <CY4PR1801MB1816E10B20760B287BF27DC8B78C9@CY4PR1801MB1816.namprd18.prod.outlook.com>
On Thu, 11 Feb 2021 17:39:35 +0000
Igor Russkikh <irusskikh@marvell.com> wrote:
> >> + echo " -w : (\$DELAY) Tx Delay value (us)"
> >This is not in "us" it is in "ns" (nanosec). (Like I pointed out last time...)
>
> Ah, sorry lost that. Will fix.
Also remember that you made similar mistake in next patch.
When adding documentation in samples/pktgen/README.rst.
Strictly speaking, the doc update for DELAY belongs in patch-1.
> One extra thing I wanted to raise is "set -o errexit" in functions.sh.
> It basically contradicts with the usecase I'm using (doing source ./functions.sh).
> After that, any error in current shell makes it to quit.
Cc. Daniel T. Lee, can you remember why this 'errexit' was added?
> Honestly, for my tests, I do always disable that line.
In your shell script, using "append", you can disable that shell
feature in your script (instead of removing the line from functions.sh).
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2021-02-12 7:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 15:56 [PATCH v2 net-next 0/2] pktgen: scripts improvements Igor Russkikh
2021-02-11 15:56 ` [PATCH v2 net-next 1/2] samples: pktgen: allow to specify delay parameter via new opt Igor Russkikh
2021-02-11 17:12 ` Jesper Dangaard Brouer
2021-02-11 17:39 ` [EXT] " Igor Russkikh
2021-02-12 7:09 ` Jesper Dangaard Brouer [this message]
2021-02-11 15:56 ` [PATCH v2 net-next 2/2] samples: pktgen: new append mode Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210212080927.008fd4c8@carbon \
--to=brouer@redhat.com \
--cc=danieltimlee@gmail.com \
--cc=davem@davemloft.net \
--cc=irusskikh@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.