All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yorick de Wid <ydewid@gmail.com>
To: linux-usb@vger.kernel.org, Oliver Neukum <oneukum@suse.com>
Cc: Yorick de Wid <ydewid@gmail.com>
Subject: [PATCH v4] Goodix Fingerprint device is not a modem
Date: Fri, 12 Feb 2021 15:08:39 +0100	[thread overview]
Message-ID: <20210212140838.196763-1-ydewid@gmail.com> (raw)
In-Reply-To: <6da4b774afccbd0ad2f9727800164728130a67f6.camel@suse.com>

The CDC ACM driver is false matching the Goodix Fingerprint device against the USB_CDC_ACM_PROTO_AT_V25TER.

The Goodix Fingerprint device is a biometrics sensor that should be handled in user-space.
libfprint has some support for Goodix fingerprint sensors, although not for this particular one.
It is possible that the vendor allocates a PID per OEM (Lenovo, Dell etc).
If this happens to be the case then more devices from the same vendor could potentially match the ACM modem module table.

Signed-off-by: Yorick de Wid <ydewid@gmail.com>
---
v1 -> v3:
Moved the entry down to keep the VID/PID order.
v3 -> v4:
Patch description of device in question

 drivers/usb/class/cdc-acm.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 78190574581..2f4e5174e78 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -1929,6 +1929,11 @@ static const struct usb_device_id acm_ids[] = {
 	.driver_info = SEND_ZERO_PACKET,
 	},
 
+	/* Exclude Goodix Fingerprint Reader */
+	{ USB_DEVICE(0x27c6, 0x5395),
+	.driver_info = IGNORE_DEVICE,
+	},
+
 	/* control interfaces without any protocol set */
 	{ USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_ACM,
 		USB_CDC_PROTO_NONE) },
-- 
2.30.0


  reply	other threads:[~2021-02-12 14:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-12 10:44 [PATCH] USB: quirks: Goodix Fingerprint device is not a modem Yorick de Wid
2021-02-12 11:07 ` [PATCH v2] " Yorick de Wid
2021-02-12 11:10   ` [PATCH v3] " Yorick de Wid
2021-02-12 11:17     ` Greg KH
2021-02-12 11:43     ` Oliver Neukum
2021-02-12 11:59       ` Yorick de Wid
2021-02-12 14:00         ` Oliver Neukum
2021-02-12 14:08           ` Yorick de Wid [this message]
2021-02-12 15:34             ` [PATCH v4] " Greg KH
2021-02-13 14:49               ` Yorick de Wid

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210212140838.196763-1-ydewid@gmail.com \
    --to=ydewid@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.