From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Ahern <dsahern@gmail.com>,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
bpf@vger.kernel.org, Daniel Borkmann <borkmann@iogearbox.net>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
brouer@redhat.com
Subject: Re: [PATCH net-next V1] net: adjust net_device layout for cacheline usage
Date: Fri, 12 Feb 2021 16:49:00 +0100 [thread overview]
Message-ID: <20210212164900.53a9a452@carbon> (raw)
In-Reply-To: <20210129150058.34e3a855@carbon>
On Fri, 29 Jan 2021 15:00:58 +0100
Jesper Dangaard Brouer <brouer@redhat.com> wrote:
> On Fri, 29 Jan 2021 14:33:02 +0100
> Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
> > On 1/26/21 6:39 PM, Jesper Dangaard Brouer wrote:
> > > The current layout of net_device is not optimal for cacheline usage.
> > >
[...]
> > > @@ -1877,6 +1876,23 @@ struct net_device {
[...]
> > > +
> > > netdev_features_t features;
> > > netdev_features_t hw_features;
> > > netdev_features_t wanted_features;
> >
> > Probably wanted_features, hw_features are not used in fast path, only
> > in control path ?
>
> Yes, that was also my analysis. I did consider moving those down, but
> I wanted to keep the first iteration simple ;-)
I've send a followup[1] to address this, thanks for pointing it out.
[1] https://patchwork.kernel.org/project/netdevbpf/patch/161313782625.1008639.6000589679659428869.stgit@firesoul/
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
prev parent reply other threads:[~2021-02-12 15:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 17:39 [PATCH net-next V1] net: adjust net_device layout for cacheline usage Jesper Dangaard Brouer
2021-01-29 3:51 ` David Ahern
2021-01-29 7:58 ` Jesper Dangaard Brouer
[not found] ` <20210129114642.139cb7dc@carbon>
2021-01-29 19:35 ` Jakub Kicinski
2021-01-29 19:47 ` Eric Dumazet
2021-01-29 20:07 ` Jakub Kicinski
2021-02-12 15:57 ` Jesper Dangaard Brouer
2021-01-29 4:50 ` patchwork-bot+netdevbpf
[not found] ` <52835f1f-96e1-b36e-2631-1182649ac3a8@gmail.com>
[not found] ` <20210129150058.34e3a855@carbon>
2021-02-12 15:49 ` Jesper Dangaard Brouer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210212164900.53a9a452@carbon \
--to=brouer@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=borkmann@iogearbox.net \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.