All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: Sunil Goutham <sgoutham@marvell.com>,
	Linu Cherian <lcherian@marvell.com>,
	Geetha sowjanya <gakula@marvell.com>,
	Jerin Jacob <jerinj@marvell.com>, hariprasad <hkelam@marvell.com>,
	Subbaraya Sundeep <sbhatta@marvell.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>
Subject: [bug report] octeontx2-af: cn10k: Identical code for different branches
Date: Fri, 12 Feb 2021 14:01:29 -0600	[thread overview]
Message-ID: <20210212200129.GA281901@embeddedor> (raw)

Hi,

In file drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c, function rvu_dbg_init()
the same code is executed for both branches:

2431         if (is_rvu_otx2(rvu))
2432                 debugfs_create_file("rvu_pf_cgx_map", 0444, rvu->rvu_dbg.root,
2433                                     rvu, &rvu_dbg_rvu_pf_cgx_map_fops);
2434         else
2435                 debugfs_create_file("rvu_pf_cgx_map", 0444, rvu->rvu_dbg.root,
2436                                     rvu, &rvu_dbg_rvu_pf_cgx_map_fops);

This issue was introduced by commit 91c6945ea1f9 ("octeontx2-af: cn10k: Add RPM MAC support")

What's the right solution for this?

Thanks
---
Gustavo

             reply	other threads:[~2021-02-12 20:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-12 20:01 Gustavo A. R. Silva [this message]
2021-02-14  2:46 ` [EXT] [bug report] octeontx2-af: cn10k: Identical code for different branches Geethasowjanya Akula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210212200129.GA281901@embeddedor \
    --to=gustavoars@kernel.org \
    --cc=davem@davemloft.net \
    --cc=gakula@marvell.com \
    --cc=hkelam@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=kuba@kernel.org \
    --cc=lcherian@marvell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sbhatta@marvell.com \
    --cc=sgoutham@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.