From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25613C433E6 for ; Fri, 12 Feb 2021 21:27:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF32A64E99 for ; Fri, 12 Feb 2021 21:27:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231720AbhBLV1U (ORCPT ); Fri, 12 Feb 2021 16:27:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229796AbhBLV1P (ORCPT ); Fri, 12 Feb 2021 16:27:15 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21146C061788 for ; Fri, 12 Feb 2021 13:26:35 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id u14so914797wri.3 for ; Fri, 12 Feb 2021 13:26:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=HkqR5YSUfK4R7W+GTGeLr6TmDe+FVUBEEGrvMyCm10g=; b=wCztQqZUFSS/X/WEM0InWCZNFakC6lQFsTg6aJtdu88LFShwneNNLtMRalXdQJvUs6 5evSk694b24/YVfDEEc/B1iu9d/+VjeWtfSZWgjthK1okpOejm5J+I4lPkbLlvJrgK+K FFpx44bpkZVEmaDzXQxQv6LKAubgLEU23K+ttitzUnGsnanYpQOFLlokkEPeNzRGjc+G H2ErjCRpx01qGB+SS35MeyN1Pofa0/lVPlXPeZo8VMsEIXYMXdfT7PJWFXY1vfjV4fD6 R5h+Ye3mdrVZSDoH8UWfbMONpTSeR2vXQf5lWCdMYzDrVbZ6WYjGANmbNJiz3Q1jE7JU wSqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=HkqR5YSUfK4R7W+GTGeLr6TmDe+FVUBEEGrvMyCm10g=; b=TM5ku/rlQQCl3YBKXulxJZi4cAHGUa8hdZZ3fjEtzEuQvr5YbSNUIa2BcRoL3wSJcj 9kaZariz505zI+lTIAYSUmsnAh36G+l71D32HT/CwMiHW16SWXnD4X1t7FvqkU2JWzXi tmKVIIHGUmPIlsfIlvJgp/uX5H01j2yOqcTlqIerCzTExerxEdaOgMFzgSzZofFt3ylk II30H/zpK1BgWXAR1nJ3vXSuNZA8QHzPeDCrGe7WnDYTj5fT3F0gcwuiVr4vLJbbWU6l g/G56XCgn7/pxUQjrqETOWgZfrBZbEdk/1/2mXoM3ogCzzcLFIoWCOK2yi9CQv5BdKIU GUuA== X-Gm-Message-State: AOAM531oK9/EVoZwAY8xW0THSUHkmlG8+k5xY2z3r7sAOZfC+sMFukQi CXaE+A3VUisTOvBCvdPlLW5z1g== X-Google-Smtp-Source: ABdhPJwhZlIwuGtUdrvybHR0t9H1gY+kEia4csmuMdVzYVfLGSB/ifG8SIgmz4d3vm5lOLrt5ugZdA== X-Received: by 2002:a5d:4206:: with SMTP id n6mr5508432wrq.213.1613165193851; Fri, 12 Feb 2021 13:26:33 -0800 (PST) Received: from dell ([91.110.221.187]) by smtp.gmail.com with ESMTPSA id t17sm15384396wmi.20.2021.02.12.13.26.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Feb 2021 13:26:33 -0800 (PST) Date: Fri, 12 Feb 2021 21:26:30 +0000 From: Lee Jones To: Stephen Boyd Cc: linux-kernel@vger.kernel.org, Ahmad Fatoum , Andy Gross , Avi Fishman , Benjamin Fair , Bjorn Andersson , Boris BREZILLON , Chen-Yu Tsai , Emilio =?iso-8859-1?Q?L=F3pez?= , Fabio Estevam , Geert Uytterhoeven , Jan Kotas , Jernej Skrabec , Jonathan Hunter , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org, Loc Ho , Maxime Ripard , Michael Turquette , Michal Simek , Nancy Yuen , Nuvoton Technologies , NXP Linux Team , openbmc@lists.ozlabs.org, Patrick Venture , Pengutronix Kernel Team , Peter De Schrijver , Philipp Zabel , Prashant Gaikwad , Rajan Vaja , Rajeev Kumar , Richard Woodruff , Russell King , Sascha Hauer , Shawn Guo , Shiraz Hashim , =?iso-8859-1?Q?S=F6ren?= Brinkmann , Tali Perry , Tero Kristo , Thierry Reding , Tomer Maimon , Viresh Kumar Subject: Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock Message-ID: <20210212212630.GD179940@dell> References: <20210126124540.3320214-1-lee.jones@linaro.org> <161307643148.1254594.6590013599999468609@swboyd.mtv.corp.google.com> <20210211211054.GD4572@dell> <161309925025.1254594.6210738031889810500@swboyd.mtv.corp.google.com> <20210212092016.GF4572@dell> <161316374113.1254594.14156657225822268891@swboyd.mtv.corp.google.com> <20210212212503.GC179940@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210212212503.GC179940@dell> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, 12 Feb 2021, Lee Jones wrote: > On Fri, 12 Feb 2021, Stephen Boyd wrote: > > > Quoting Lee Jones (2021-02-12 01:20:16) > > > On Thu, 11 Feb 2021, Stephen Boyd wrote: > > > > > > > Quoting Lee Jones (2021-02-11 13:10:54) > > > > > On Thu, 11 Feb 2021, Stephen Boyd wrote: > > > > > > > > > > > Quoting Lee Jones (2021-01-26 04:45:19) > > > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > > > > kernel builds, which are currently overwhelmingly riddled with > > > > > > > niggly little warnings. > > > > > > > > > > > > > > This is the last set. Clock is clean after this. > > > > > > > > > > > > Is it possible to slam in some patch that makes W=1 the default for the > > > > > > clk directory? I'm trying to avoid seeing this patch series again. > > > > > > > > > > One of my main goals of this project is that everyone (contributors, > > > > > maintainers auto-builder robots etc) will be enabling W=1 builds > > > > > *locally*. > > > > > > > > > > This isn't something you'll want to do at a global (i.e. in Mainline) > > > > > level. That's kinda the point of W=1. > > > > > > > > > > > > > Agreed, but is it possible to pass W=1 in the drivers/clk/Makefile? > > > > > > That would circumvent the point of W=1. Level-1 warnings are deemed, > > > and I'm paraphrasing/making this up "not worth rejecting pull-requests > > > over". In contrast, if Linus catches any W=0 warnings at pull-time, > > > he will reject the pull-request as 'untested'. > > > > > > W=1 is defiantly something you'll want to enable locally though, and > > > subsequently push back on contributors submitting code adding new > > > ones. > > > > > > > Why should I install a land mine for others to trip over? Won't that > > just take them more time because they won't know to compile with W=1 and > > then will have to go for another round of review while I push back on > > them submitting new warnings? > > The alternative is to not worry about it and review the slow drip of > fixes that will occur as a result. The issues I just fixed were built > up over years. They won't get to that level again. > > In my mind contributors should be compiling their submissions with W=1 > enabled by default. I'm fairly sure the auto-builders do this now. > > Once W=1 warnings are down to an acceptable level in the kernel as a > whole, we can provide some guidance in SubmittingPatches (or similar) > on how to enable them (hint: you add "W=1" on the compile line). > > Enabling W=1 in the default build will only serve to annoy Linus IMHO. > If he wants them to be enabled by default, they wouldn't be W=1 in the > first place, they'd be W=0 which *is* the default build. Just to add real quick - my advice is to enable them for yourself and send back any issues along with your normal review. A W=1 issue is no different to a semantic or coding style one. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF193C433E0 for ; Sun, 14 Feb 2021 23:27:11 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3ABAD64DEC for ; Sun, 14 Feb 2021 23:27:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3ABAD64DEC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Df3Kn6TqBz30L4 for ; Mon, 15 Feb 2021 10:27:09 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=wCztQqZU; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2a00:1450:4864:20::430; helo=mail-wr1-x430.google.com; envelope-from=lee.jones@linaro.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=wCztQqZU; dkim-atps=neutral Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Dcmlf2ZB3zDskY for ; Sat, 13 Feb 2021 08:26:38 +1100 (AEDT) Received: by mail-wr1-x430.google.com with SMTP id v14so869326wro.7 for ; Fri, 12 Feb 2021 13:26:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=HkqR5YSUfK4R7W+GTGeLr6TmDe+FVUBEEGrvMyCm10g=; b=wCztQqZUFSS/X/WEM0InWCZNFakC6lQFsTg6aJtdu88LFShwneNNLtMRalXdQJvUs6 5evSk694b24/YVfDEEc/B1iu9d/+VjeWtfSZWgjthK1okpOejm5J+I4lPkbLlvJrgK+K FFpx44bpkZVEmaDzXQxQv6LKAubgLEU23K+ttitzUnGsnanYpQOFLlokkEPeNzRGjc+G H2ErjCRpx01qGB+SS35MeyN1Pofa0/lVPlXPeZo8VMsEIXYMXdfT7PJWFXY1vfjV4fD6 R5h+Ye3mdrVZSDoH8UWfbMONpTSeR2vXQf5lWCdMYzDrVbZ6WYjGANmbNJiz3Q1jE7JU wSqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=HkqR5YSUfK4R7W+GTGeLr6TmDe+FVUBEEGrvMyCm10g=; b=H3NMfnsjynHZUsXB1NBlm1Uo7NV9dPIlg9JMSbfZRWgXOve4WHoaq4GC0CDuT3lpve LcVTrlS2fHxVZ9dG/BtwtvapUEmYqczswSNF0xsAdJbapmwfDBURAqaqlgAePV1/HNh8 VmhTNs1xn3IvbiGEOZ9jY3aMy9Pg60M1E6LKJcYBS5P8C0TPwt9az/6onZQrI5Ianxny VHTsz5sXRAvwIEPqNQQpjBLVfgvfbCuBVQZmT8teLoUI2XmH7ahkLXOuZ7wyn0tzjQdH NklKaYeX0x0AS1G66CCAwACLsCEDULrO1l4MIWqT1Om2Ko5sN0Ql1bwDKNLXdSMNc5RA IhEg== X-Gm-Message-State: AOAM530r84Fd16fdszRVQU2u8cUHfCrjz/JiVlvNeYNNY8EFtTY8ur17 j9oInD3CfZlfmQzeEUrLEUWIkw== X-Google-Smtp-Source: ABdhPJwhZlIwuGtUdrvybHR0t9H1gY+kEia4csmuMdVzYVfLGSB/ifG8SIgmz4d3vm5lOLrt5ugZdA== X-Received: by 2002:a5d:4206:: with SMTP id n6mr5508432wrq.213.1613165193851; Fri, 12 Feb 2021 13:26:33 -0800 (PST) Received: from dell ([91.110.221.187]) by smtp.gmail.com with ESMTPSA id t17sm15384396wmi.20.2021.02.12.13.26.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Feb 2021 13:26:33 -0800 (PST) Date: Fri, 12 Feb 2021 21:26:30 +0000 From: Lee Jones To: Stephen Boyd Subject: Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock Message-ID: <20210212212630.GD179940@dell> References: <20210126124540.3320214-1-lee.jones@linaro.org> <161307643148.1254594.6590013599999468609@swboyd.mtv.corp.google.com> <20210211211054.GD4572@dell> <161309925025.1254594.6210738031889810500@swboyd.mtv.corp.google.com> <20210212092016.GF4572@dell> <161316374113.1254594.14156657225822268891@swboyd.mtv.corp.google.com> <20210212212503.GC179940@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210212212503.GC179940@dell> X-Mailman-Approved-At: Mon, 15 Feb 2021 10:22:39 +1100 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Prashant Gaikwad , Tomer Maimon , Geert Uytterhoeven , Michael Turquette , Bjorn Andersson , Rajeev Kumar , Jan Kotas , Russell King , Fabio Estevam , linux-clk@vger.kernel.org, Boris BREZILLON , Ahmad Fatoum , Benjamin Fair , Emilio =?iso-8859-1?Q?L=F3pez?= , Viresh Kumar , openbmc@lists.ozlabs.org, Michal Simek , Jonathan Hunter , Chen-Yu Tsai , Andy Gross , Loc Ho , NXP Linux Team , Richard Woodruff , Tali Perry , Philipp Zabel , linux-arm-msm@vger.kernel.org, Sascha Hauer , Maxime Ripard , linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, Shiraz Hashim , linux-arm-kernel@lists.infradead.org, =?iso-8859-1?Q?S=F6ren?= Brinkmann , Jernej Skrabec , Tero Kristo , Rajan Vaja , Avi Fishman , Patrick Venture , Peter De Schrijver , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Nuvoton Technologies , Thierry Reding , Pengutronix Kernel Team , Shawn Guo Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Fri, 12 Feb 2021, Lee Jones wrote: > On Fri, 12 Feb 2021, Stephen Boyd wrote: > > > Quoting Lee Jones (2021-02-12 01:20:16) > > > On Thu, 11 Feb 2021, Stephen Boyd wrote: > > > > > > > Quoting Lee Jones (2021-02-11 13:10:54) > > > > > On Thu, 11 Feb 2021, Stephen Boyd wrote: > > > > > > > > > > > Quoting Lee Jones (2021-01-26 04:45:19) > > > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > > > > kernel builds, which are currently overwhelmingly riddled with > > > > > > > niggly little warnings. > > > > > > > > > > > > > > This is the last set. Clock is clean after this. > > > > > > > > > > > > Is it possible to slam in some patch that makes W=1 the default for the > > > > > > clk directory? I'm trying to avoid seeing this patch series again. > > > > > > > > > > One of my main goals of this project is that everyone (contributors, > > > > > maintainers auto-builder robots etc) will be enabling W=1 builds > > > > > *locally*. > > > > > > > > > > This isn't something you'll want to do at a global (i.e. in Mainline) > > > > > level. That's kinda the point of W=1. > > > > > > > > > > > > > Agreed, but is it possible to pass W=1 in the drivers/clk/Makefile? > > > > > > That would circumvent the point of W=1. Level-1 warnings are deemed, > > > and I'm paraphrasing/making this up "not worth rejecting pull-requests > > > over". In contrast, if Linus catches any W=0 warnings at pull-time, > > > he will reject the pull-request as 'untested'. > > > > > > W=1 is defiantly something you'll want to enable locally though, and > > > subsequently push back on contributors submitting code adding new > > > ones. > > > > > > > Why should I install a land mine for others to trip over? Won't that > > just take them more time because they won't know to compile with W=1 and > > then will have to go for another round of review while I push back on > > them submitting new warnings? > > The alternative is to not worry about it and review the slow drip of > fixes that will occur as a result. The issues I just fixed were built > up over years. They won't get to that level again. > > In my mind contributors should be compiling their submissions with W=1 > enabled by default. I'm fairly sure the auto-builders do this now. > > Once W=1 warnings are down to an acceptable level in the kernel as a > whole, we can provide some guidance in SubmittingPatches (or similar) > on how to enable them (hint: you add "W=1" on the compile line). > > Enabling W=1 in the default build will only serve to annoy Linus IMHO. > If he wants them to be enabled by default, they wouldn't be W=1 in the > first place, they'd be W=0 which *is* the default build. Just to add real quick - my advice is to enable them for yourself and send back any issues along with your normal review. A W=1 issue is no different to a semantic or coding style one. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE594C433E0 for ; Fri, 12 Feb 2021 21:27:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90C3B64E05 for ; Fri, 12 Feb 2021 21:27:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90C3B64E05 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aYtFzONuprWumolEWBYZagqM8TX3Mj9y04oV1Gjzm+Q=; b=S2MeuaPfOv7zrhAkROQLTIrVE XDVNtyagc7hs/r+4unwFk+VJMR+GMQ8uEKxnreBusCVF4PSZWdD+UBMnd9gtor7arnwdSsZur8BJD /7kFcRKtHqr7f2KxUYUCUpFp9++qEE1nbkVLuGNV1fJcCC6ytfwjTUev10oEbDrI3k/55ErR9UX+L mBNfZ8a2wRj2at+tIyLxrGvEBVSqLFaCQFns5pZ10moqHVC6tBOTBmMghH+FsGGMMJ1y3AeV8nH4F vXpXtxZEJxydQmfIhO59ifEkOmn7jozAB92o3QdrjuQaDQiJx5sy/ObVqX2CCVBJX1iLQXIc+W2LO de9Sf9jpw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAfxX-0004AO-Aa; Fri, 12 Feb 2021 21:26:39 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAfxT-00049Y-C3 for linux-arm-kernel@lists.infradead.org; Fri, 12 Feb 2021 21:26:36 +0000 Received: by mail-wr1-x42c.google.com with SMTP id g10so925864wrx.1 for ; Fri, 12 Feb 2021 13:26:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=HkqR5YSUfK4R7W+GTGeLr6TmDe+FVUBEEGrvMyCm10g=; b=wCztQqZUFSS/X/WEM0InWCZNFakC6lQFsTg6aJtdu88LFShwneNNLtMRalXdQJvUs6 5evSk694b24/YVfDEEc/B1iu9d/+VjeWtfSZWgjthK1okpOejm5J+I4lPkbLlvJrgK+K FFpx44bpkZVEmaDzXQxQv6LKAubgLEU23K+ttitzUnGsnanYpQOFLlokkEPeNzRGjc+G H2ErjCRpx01qGB+SS35MeyN1Pofa0/lVPlXPeZo8VMsEIXYMXdfT7PJWFXY1vfjV4fD6 R5h+Ye3mdrVZSDoH8UWfbMONpTSeR2vXQf5lWCdMYzDrVbZ6WYjGANmbNJiz3Q1jE7JU wSqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=HkqR5YSUfK4R7W+GTGeLr6TmDe+FVUBEEGrvMyCm10g=; b=jov50Ivr8OOFFCQuYtd1n04dPuI58PLWyuPvz2Uj7pYBpYgjgbq4aL2oMJwMfH8GhK YRo7K1ELslAFISKXtXD6llLT//lsjR3bdz/AQ0EhwQikH+m+T5DISNIW//t0i6ED0Mmb t0UwxhkESX18dbXZFTvFHAVVkQWAJt/3iLWLXbrd/8bOKIluSE3mqNPDPIfPZAsz3GzS cNmT8SxwINX7pm1z5hBoYWgkVV4KVYPOU9kh50KZgb9P+oT8+yuahIlQssKV0WbFuhKm +oG6bt23ufye2cHw+fGJ51CciH//MIYYaGELMHXaT20F6w+wGNdIOGqcPf4bjIDBrS39 ugoA== X-Gm-Message-State: AOAM530ZZNe3jLogbZZnW5/oy5TrdV28rj0EggUria681wGAvaJYfpJG o5KLhphkZ/UU3ndCM+3HaCj27Q== X-Google-Smtp-Source: ABdhPJwhZlIwuGtUdrvybHR0t9H1gY+kEia4csmuMdVzYVfLGSB/ifG8SIgmz4d3vm5lOLrt5ugZdA== X-Received: by 2002:a5d:4206:: with SMTP id n6mr5508432wrq.213.1613165193851; Fri, 12 Feb 2021 13:26:33 -0800 (PST) Received: from dell ([91.110.221.187]) by smtp.gmail.com with ESMTPSA id t17sm15384396wmi.20.2021.02.12.13.26.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Feb 2021 13:26:33 -0800 (PST) Date: Fri, 12 Feb 2021 21:26:30 +0000 From: Lee Jones To: Stephen Boyd Subject: Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock Message-ID: <20210212212630.GD179940@dell> References: <20210126124540.3320214-1-lee.jones@linaro.org> <161307643148.1254594.6590013599999468609@swboyd.mtv.corp.google.com> <20210211211054.GD4572@dell> <161309925025.1254594.6210738031889810500@swboyd.mtv.corp.google.com> <20210212092016.GF4572@dell> <161316374113.1254594.14156657225822268891@swboyd.mtv.corp.google.com> <20210212212503.GC179940@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210212212503.GC179940@dell> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210212_162635_744887_53F20DE3 X-CRM114-Status: GOOD ( 30.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Prashant Gaikwad , Tomer Maimon , Geert Uytterhoeven , Michael Turquette , Bjorn Andersson , Rajeev Kumar , Jan Kotas , Russell King , Fabio Estevam , linux-clk@vger.kernel.org, Boris BREZILLON , Ahmad Fatoum , Benjamin Fair , Emilio =?iso-8859-1?Q?L=F3pez?= , Viresh Kumar , openbmc@lists.ozlabs.org, Michal Simek , Jonathan Hunter , Nancy Yuen , Chen-Yu Tsai , Andy Gross , Loc Ho , NXP Linux Team , Richard Woodruff , Tali Perry , Philipp Zabel , linux-arm-msm@vger.kernel.org, Sascha Hauer , Maxime Ripard , linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, Shiraz Hashim , linux-arm-kernel@lists.infradead.org, =?iso-8859-1?Q?S=F6ren?= Brinkmann , Jernej Skrabec , Tero Kristo , Rajan Vaja , Avi Fishman , Patrick Venture , Peter De Schrijver , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Nuvoton Technologies , Thierry Reding , Pengutronix Kernel Team , Shawn Guo Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAxMiBGZWIgMjAyMSwgTGVlIEpvbmVzIHdyb3RlOgoKPiBPbiBGcmksIDEyIEZlYiAy MDIxLCBTdGVwaGVuIEJveWQgd3JvdGU6Cj4gCj4gPiBRdW90aW5nIExlZSBKb25lcyAoMjAyMS0w Mi0xMiAwMToyMDoxNikKPiA+ID4gT24gVGh1LCAxMSBGZWIgMjAyMSwgU3RlcGhlbiBCb3lkIHdy b3RlOgo+ID4gPiAKPiA+ID4gPiBRdW90aW5nIExlZSBKb25lcyAoMjAyMS0wMi0xMSAxMzoxMDo1 NCkKPiA+ID4gPiA+IE9uIFRodSwgMTEgRmViIDIwMjEsIFN0ZXBoZW4gQm95ZCB3cm90ZToKPiA+ ID4gPiA+IAo+ID4gPiA+ID4gPiBRdW90aW5nIExlZSBKb25lcyAoMjAyMS0wMS0yNiAwNDo0NTox OSkKPiA+ID4gPiA+ID4gPiBUaGlzIHNldCBpcyBwYXJ0IG9mIGEgbGFyZ2VyIGVmZm9ydCBhdHRl bXB0aW5nIHRvIGNsZWFuLXVwIFc9MQo+ID4gPiA+ID4gPiA+IGtlcm5lbCBidWlsZHMsIHdoaWNo IGFyZSBjdXJyZW50bHkgb3ZlcndoZWxtaW5nbHkgcmlkZGxlZCB3aXRoCj4gPiA+ID4gPiA+ID4g bmlnZ2x5IGxpdHRsZSB3YXJuaW5ncy4KPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBUaGlz IGlzIHRoZSBsYXN0IHNldC4gIENsb2NrIGlzIGNsZWFuIGFmdGVyIHRoaXMuCj4gPiA+ID4gPiA+ IAo+ID4gPiA+ID4gPiBJcyBpdCBwb3NzaWJsZSB0byBzbGFtIGluIHNvbWUgcGF0Y2ggdGhhdCBt YWtlcyBXPTEgdGhlIGRlZmF1bHQgZm9yIHRoZQo+ID4gPiA+ID4gPiBjbGsgZGlyZWN0b3J5PyBJ J20gdHJ5aW5nIHRvIGF2b2lkIHNlZWluZyB0aGlzIHBhdGNoIHNlcmllcyBhZ2Fpbi4KPiA+ID4g PiA+IAo+ID4gPiA+ID4gT25lIG9mIG15IG1haW4gZ29hbHMgb2YgdGhpcyBwcm9qZWN0IGlzIHRo YXQgZXZlcnlvbmUgKGNvbnRyaWJ1dG9ycywKPiA+ID4gPiA+IG1haW50YWluZXJzIGF1dG8tYnVp bGRlciByb2JvdHMgZXRjKSB3aWxsIGJlIGVuYWJsaW5nIFc9MSBidWlsZHMKPiA+ID4gPiA+ICps b2NhbGx5Ki4KPiA+ID4gPiA+IAo+ID4gPiA+ID4gVGhpcyBpc24ndCBzb21ldGhpbmcgeW91J2xs IHdhbnQgdG8gZG8gYXQgYSBnbG9iYWwgKGkuZS4gaW4gTWFpbmxpbmUpCj4gPiA+ID4gPiBsZXZl bC4gIFRoYXQncyBraW5kYSB0aGUgcG9pbnQgb2YgVz0xLgo+ID4gPiA+ID4gCj4gPiA+ID4gCj4g PiA+ID4gQWdyZWVkLCBidXQgaXMgaXQgcG9zc2libGUgdG8gcGFzcyBXPTEgaW4gdGhlIGRyaXZl cnMvY2xrL01ha2VmaWxlPwo+ID4gPiAKPiA+ID4gVGhhdCB3b3VsZCBjaXJjdW12ZW50IHRoZSBw b2ludCBvZiBXPTEuICBMZXZlbC0xIHdhcm5pbmdzIGFyZSBkZWVtZWQsCj4gPiA+IGFuZCBJJ20g cGFyYXBocmFzaW5nL21ha2luZyB0aGlzIHVwICJub3Qgd29ydGggcmVqZWN0aW5nIHB1bGwtcmVx dWVzdHMKPiA+ID4gb3ZlciIuICBJbiBjb250cmFzdCwgaWYgTGludXMgY2F0Y2hlcyBhbnkgVz0w IHdhcm5pbmdzIGF0IHB1bGwtdGltZSwKPiA+ID4gaGUgd2lsbCByZWplY3QgdGhlIHB1bGwtcmVx dWVzdCBhcyAndW50ZXN0ZWQnLgo+ID4gPiAKPiA+ID4gVz0xIGlzIGRlZmlhbnRseSBzb21ldGhp bmcgeW91J2xsIHdhbnQgdG8gZW5hYmxlIGxvY2FsbHkgdGhvdWdoLCBhbmQKPiA+ID4gc3Vic2Vx dWVudGx5IHB1c2ggYmFjayBvbiBjb250cmlidXRvcnMgc3VibWl0dGluZyBjb2RlIGFkZGluZyBu ZXcKPiA+ID4gb25lcy4KPiA+ID4gCj4gPiAKPiA+IFdoeSBzaG91bGQgSSBpbnN0YWxsIGEgbGFu ZCBtaW5lIGZvciBvdGhlcnMgdG8gdHJpcCBvdmVyPyBXb24ndCB0aGF0Cj4gPiBqdXN0IHRha2Ug dGhlbSBtb3JlIHRpbWUgYmVjYXVzZSB0aGV5IHdvbid0IGtub3cgdG8gY29tcGlsZSB3aXRoIFc9 MSBhbmQKPiA+IHRoZW4gd2lsbCBoYXZlIHRvIGdvIGZvciBhbm90aGVyIHJvdW5kIG9mIHJldmll dyB3aGlsZSBJIHB1c2ggYmFjayBvbgo+ID4gdGhlbSBzdWJtaXR0aW5nIG5ldyB3YXJuaW5ncz8K PiAKPiBUaGUgYWx0ZXJuYXRpdmUgaXMgdG8gbm90IHdvcnJ5IGFib3V0IGl0IGFuZCByZXZpZXcg dGhlIHNsb3cgZHJpcCBvZgo+IGZpeGVzIHRoYXQgd2lsbCBvY2N1ciBhcyBhIHJlc3VsdC4gIFRo ZSBpc3N1ZXMgSSBqdXN0IGZpeGVkIHdlcmUgYnVpbHQKPiB1cCBvdmVyIHllYXJzLiAgVGhleSB3 b24ndCBnZXQgdG8gdGhhdCBsZXZlbCBhZ2Fpbi4KPiAKPiBJbiBteSBtaW5kIGNvbnRyaWJ1dG9y cyBzaG91bGQgYmUgY29tcGlsaW5nIHRoZWlyIHN1Ym1pc3Npb25zIHdpdGggVz0xCj4gZW5hYmxl ZCBieSBkZWZhdWx0LiAgSSdtIGZhaXJseSBzdXJlIHRoZSBhdXRvLWJ1aWxkZXJzIGRvIHRoaXMg bm93Lgo+IAo+IE9uY2UgVz0xIHdhcm5pbmdzIGFyZSBkb3duIHRvIGFuIGFjY2VwdGFibGUgbGV2 ZWwgaW4gdGhlIGtlcm5lbCBhcyBhCj4gd2hvbGUsIHdlIGNhbiBwcm92aWRlIHNvbWUgZ3VpZGFu Y2UgaW4gU3VibWl0dGluZ1BhdGNoZXMgKG9yIHNpbWlsYXIpCj4gb24gaG93IHRvIGVuYWJsZSB0 aGVtIChoaW50OiB5b3UgYWRkICJXPTEiIG9uIHRoZSBjb21waWxlIGxpbmUpLgo+IAo+IEVuYWJs aW5nIFc9MSBpbiB0aGUgZGVmYXVsdCBidWlsZCB3aWxsIG9ubHkgc2VydmUgdG8gYW5ub3kgTGlu dXMgSU1ITy4KPiBJZiBoZSB3YW50cyB0aGVtIHRvIGJlIGVuYWJsZWQgYnkgZGVmYXVsdCwgdGhl eSB3b3VsZG4ndCBiZSBXPTEgaW4gdGhlCj4gZmlyc3QgcGxhY2UsIHRoZXknZCBiZSBXPTAgd2hp Y2ggKmlzKiB0aGUgZGVmYXVsdCBidWlsZC4KCkp1c3QgdG8gYWRkIHJlYWwgcXVpY2sgLSBteSBh ZHZpY2UgaXMgdG8gZW5hYmxlIHRoZW0gZm9yIHlvdXJzZWxmIGFuZApzZW5kIGJhY2sgYW55IGlz c3VlcyBhbG9uZyB3aXRoIHlvdXIgbm9ybWFsIHJldmlldy4gIEEgVz0xIGlzc3VlIGlzIG5vCmRp ZmZlcmVudCB0byBhIHNlbWFudGljIG9yIGNvZGluZyBzdHlsZSBvbmUuCgotLSAKTGVlIEpvbmVz IFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVhZCAtIERldmVsb3BlciBTZXJ2aWNlcwpM aW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9sbG93IExp bmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=