Re: [PATCH] acpi: Remove duplicated code handling OEM ID and OEM table ID fields

[Igor Mammedov <imammedo@redhat.com>]

On Sat, 13 Feb 2021 12:22:33 +0200
Marian Postevca <posteuca@mutex.one> wrote:

> The code handling OEM ID and OEM table ID fields had some duplicated
> code and was using unnecessary dynamically allocated memory.
> This change fixes that.
> 
> Signed-off-by: Marian Postevca <posteuca@mutex.one>
[...]
>  24 files changed, 190 insertions(+), 159 deletions(-)
hmm, looks like adding instead of removing

[...]
> --- a/include/hw/i386/microvm.h
> +++ b/include/hw/i386/microvm.h
> @@ -25,6 +25,7 @@
>  #include "hw/boards.h"
>  #include "hw/i386/x86.h"
>  #include "hw/acpi/acpi_dev_interface.h"
> +#include "hw/acpi/acpi-build-oem.h"
>  #include "hw/pci-host/gpex.h"
>  #include "qom/object.h"
>  
> @@ -106,8 +107,7 @@ struct MicrovmMachineState {
>      Notifier machine_done;
>      Notifier powerdown_req;
>      struct GPEXConfig gpex;
> -    char *oem_id;
> -    char *oem_table_id;
> +    struct AcpiBuildOem bld_oem;
have you considered, putting this field into X86MachineState?
(that way you will be able to handle both PC and microvm in one place,
without duplication io init/property setters)

>  };
>  
>  #define TYPE_MICROVM_MACHINE   MACHINE_TYPE_NAME("microvm")