From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFE71C433E6 for ; Wed, 17 Feb 2021 22:04:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EB7B64E76 for ; Wed, 17 Feb 2021 22:04:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232295AbhBQWEE (ORCPT ); Wed, 17 Feb 2021 17:04:04 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:41148 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231483AbhBQWED (ORCPT ); Wed, 17 Feb 2021 17:04:03 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 88A821C0B8E; Wed, 17 Feb 2021 23:02:59 +0100 (CET) Date: Wed, 17 Feb 2021 23:02:58 +0100 From: Pavel Machek To: Chaitanya Kulkarni Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com, xen-devel@lists.xenproject.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fscrypt@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-pm@vger.kernel.org, linux-mm@kvack.org, axboe@kernel.dk, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, konrad.wilk@oracle.com, roger.pau@citrix.com, minchan@kernel.org, ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, agk@redhat.com, snitzer@redhat.com, hch@lst.de, sagi@grimberg.me, martin.petersen@oracle.com, viro@zeniv.linux.org.uk, tytso@mit.edu, jaegeuk@kernel.org, ebiggers@kernel.org, djwong@kernel.org, shaggy@kernel.org, konishi.ryusuke@gmail.com, mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, damien.lemoal@wdc.com, naohiro.aota@wdc.com, jth@kernel.org, rjw@rjwysocki.net, len.brown@intel.com, akpm@linux-foundation.org, hare@suse.de, gustavoars@kernel.org, tiwai@suse.de, alex.shi@linux.alibaba.com, asml.silence@gmail.com, ming.lei@redhat.com, tj@kernel.org, osandov@fb.com, bvanassche@acm.org, jefflexu@linux.alibaba.com Subject: Re: [RFC PATCH 29/34] power/swap: use bio_new in hib_submit_io Message-ID: <20210217220257.GA10791@amd> References: <20210128071133.60335-1-chaitanya.kulkarni@wdc.com> <20210128071133.60335-30-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LQksG6bCIzRHxTLp" Content-Disposition: inline In-Reply-To: <20210128071133.60335-30-chaitanya.kulkarni@wdc.com> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org --LQksG6bCIzRHxTLp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! >=20 > diff --git a/kernel/power/swap.c b/kernel/power/swap.c > index c73f2e295167..e92e36c053a6 100644 > --- a/kernel/power/swap.c > +++ b/kernel/power/swap.c > @@ -271,13 +271,12 @@ static int hib_submit_io(int op, int op_flags, pgof= f_t page_off, void *addr, > struct hib_bio_batch *hb) > { > struct page *page =3D virt_to_page(addr); > + sector_t sect =3D page_off * (PAGE_SIZE >> 9); > struct bio *bio; > int error =3D 0; > =20 > - bio =3D bio_alloc(GFP_NOIO | __GFP_HIGH, 1); > - bio->bi_iter.bi_sector =3D page_off * (PAGE_SIZE >> 9); > - bio_set_dev(bio, hib_resume_bdev); > - bio_set_op_attrs(bio, op, op_flags); > + bio =3D bio_new(hib_resume_bdev, sect, op, op_flags, 1, > + GFP_NOIO | __GFP_HIGH); > =20 C function with 6 arguments... dunno. Old version looks comparable or even more readable... Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --LQksG6bCIzRHxTLp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmAtkpEACgkQMOfwapXb+vL5ywCguk9XRtMJ4/rJgwKlR42qzH7B ww4AoK8H3c5uHgpu/eHAUqpvoYMrxHuL =Rk1V -----END PGP SIGNATURE----- --LQksG6bCIzRHxTLp-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [RFC PATCH 29/34] power/swap: use bio_new in hib_submit_io Date: Wed, 17 Feb 2021 23:02:58 +0100 Message-ID: <20210217220257.GA10791@amd> References: <20210128071133.60335-1-chaitanya.kulkarni@wdc.com> <20210128071133.60335-30-chaitanya.kulkarni@wdc.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LQksG6bCIzRHxTLp" Return-path: List-Id: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Content-Disposition: inline In-Reply-To: <20210128071133.60335-30-chaitanya.kulkarni@wdc.com> To: Chaitanya Kulkarni Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com, xen-devel@lists.xenproject.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fscrypt@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-pm@vger.kernel.org, linux-mm@kvack.org, axboe@kernel.dk, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, konrad.wilk@oracle.com, roger.pau@citrix.com, minchan@kernel.org, ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, agk@redhat.com, snitzer@redhat.com, hch@lst.de, sagi@grimberg.me, martin.petersen@oracle.com, viro@zeniv.linux.org.uk, tytso@mit.edu, jaegeuk@kernel.org, ebiggers@kernel.org, djwong@kernel.org, shaggy@kernel.org, konishi.ryusuke@gm --LQksG6bCIzRHxTLp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! >=20 > diff --git a/kernel/power/swap.c b/kernel/power/swap.c > index c73f2e295167..e92e36c053a6 100644 > --- a/kernel/power/swap.c > +++ b/kernel/power/swap.c > @@ -271,13 +271,12 @@ static int hib_submit_io(int op, int op_flags, pgof= f_t page_off, void *addr, > struct hib_bio_batch *hb) > { > struct page *page =3D virt_to_page(addr); > + sector_t sect =3D page_off * (PAGE_SIZE >> 9); > struct bio *bio; > int error =3D 0; > =20 > - bio =3D bio_alloc(GFP_NOIO | __GFP_HIGH, 1); > - bio->bi_iter.bi_sector =3D page_off * (PAGE_SIZE >> 9); > - bio_set_dev(bio, hib_resume_bdev); > - bio_set_op_attrs(bio, op, op_flags); > + bio =3D bio_new(hib_resume_bdev, sect, op, op_flags, 1, > + GFP_NOIO | __GFP_HIGH); > =20 C function with 6 arguments... dunno. Old version looks comparable or even more readable... Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --LQksG6bCIzRHxTLp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmAtkpEACgkQMOfwapXb+vL5ywCguk9XRtMJ4/rJgwKlR42qzH7B ww4AoK8H3c5uHgpu/eHAUqpvoYMrxHuL =Rk1V -----END PGP SIGNATURE----- --LQksG6bCIzRHxTLp-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5A2BC433DB for ; Fri, 26 Feb 2021 16:55:35 +0000 (UTC) Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 205C664E85 for ; Fri, 26 Feb 2021 16:55:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 205C664E85 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=ocfs2-devel-bounces@oss.oracle.com Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11QGtQg4085561; Fri, 26 Feb 2021 16:55:34 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 36tsuranuv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 Feb 2021 16:55:34 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11QGoIjx004688; Fri, 26 Feb 2021 16:55:33 GMT Received: from oss.oracle.com (oss-old-reserved.oracle.com [137.254.22.2]) by userp3020.oracle.com with ESMTP id 36uc6w48sb-1 (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO); Fri, 26 Feb 2021 16:55:33 +0000 Received: from localhost ([127.0.0.1] helo=lb-oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1lFgOq-0000Xv-NJ; Fri, 26 Feb 2021 08:55:32 -0800 Received: from userp3020.oracle.com ([156.151.31.79]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1lCUug-0008PZ-7F for ocfs2-devel@oss.oracle.com; Wed, 17 Feb 2021 14:03:14 -0800 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11HLxcaF120835 for ; Wed, 17 Feb 2021 22:03:13 GMT Received: from userp2030.oracle.com (userp2030.oracle.com [156.151.31.89]) by userp3020.oracle.com with ESMTP id 36prhte2r3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 17 Feb 2021 22:03:13 +0000 Received: from pps.filterd (userp2030.oracle.com [127.0.0.1]) by userp2030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11HLiHA2033030 for ; Wed, 17 Feb 2021 22:03:13 GMT Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by userp2030.oracle.com with ESMTP id 36p4tj73hj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Wed, 17 Feb 2021 22:03:06 +0000 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 88A821C0B8E; Wed, 17 Feb 2021 23:02:59 +0100 (CET) Date: Wed, 17 Feb 2021 23:02:58 +0100 From: Pavel Machek To: Chaitanya Kulkarni Message-ID: <20210217220257.GA10791@amd> References: <20210128071133.60335-1-chaitanya.kulkarni@wdc.com> <20210128071133.60335-30-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 In-Reply-To: <20210128071133.60335-30-chaitanya.kulkarni@wdc.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-PDR: PASS X-Source-IP: 46.255.230.98 X-ServerName: jabberwock.ucw.cz X-Proofpoint-SPF-Result: None X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9898 signatures=668683 X-Proofpoint-Spam-Details: rule=tap_notspam policy=tap score=0 lowpriorityscore=0 adultscore=0 mlxlogscore=772 mlxscore=0 bulkscore=0 spamscore=0 phishscore=0 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102170161 X-Spam: Clean X-Mailman-Approved-At: Fri, 26 Feb 2021 08:55:31 -0800 Cc: shaggy@kernel.org, jfs-discussion@lists.sourceforge.net, gustavoars@kernel.org, sergey.senozhatsky.work@gmail.com, snitzer@redhat.com, tiwai@suse.de, linux-nvme@lists.infradead.org, philipp.reisner@linbit.com, linux-mm@kvack.org, dm-devel@redhat.com, target-devel@vger.kernel.org, alex.shi@linux.alibaba.com, agk@redhat.com, drbd-dev@lists.linbit.com, naohiro.aota@wdc.com, linux-nilfs@vger.kernel.org, sagi@grimberg.me, linux-scsi@vger.kernel.org, konrad.wilk@oracle.com, osandov@fb.com, ebiggers@kernel.org, xen-devel@lists.xenproject.org, ngupta@vflare.org, len.brown@intel.com, linux-pm@vger.kernel.org, hare@suse.de, ming.lei@redhat.com, linux-block@vger.kernel.org, tj@kernel.org, linux-fscrypt@vger.kernel.org, viro@zeniv.linux.org.uk, jefflexu@linux.alibaba.com, jaegeuk@kernel.org, konishi.ryusuke@gmail.com, bvanassche@acm.org, axboe@kernel.dk, damien.lemoal@wdc.com, tytso@mit.edu, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, minchan@kernel.org, linux-fsdevel@vger.kernel.org, lars.ellenberg@linbit.com, jth@kernel.org, asml.silence@gmail.com, ocfs2-devel@oss.oracle.com, roger.pau@citrix.com Subject: Re: [Ocfs2-devel] [RFC PATCH 29/34] power/swap: use bio_new in hib_submit_io X-BeenThere: ocfs2-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0970792594194068013==" Sender: ocfs2-devel-bounces@oss.oracle.com Errors-To: ocfs2-devel-bounces@oss.oracle.com X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9907 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 adultscore=0 bulkscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102260124 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9907 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 mlxscore=0 malwarescore=0 clxscore=1034 phishscore=0 mlxlogscore=999 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102260125 --===============0970792594194068013== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LQksG6bCIzRHxTLp" Content-Disposition: inline --LQksG6bCIzRHxTLp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! >=20 > diff --git a/kernel/power/swap.c b/kernel/power/swap.c > index c73f2e295167..e92e36c053a6 100644 > --- a/kernel/power/swap.c > +++ b/kernel/power/swap.c > @@ -271,13 +271,12 @@ static int hib_submit_io(int op, int op_flags, pgof= f_t page_off, void *addr, > struct hib_bio_batch *hb) > { > struct page *page =3D virt_to_page(addr); > + sector_t sect =3D page_off * (PAGE_SIZE >> 9); > struct bio *bio; > int error =3D 0; > =20 > - bio =3D bio_alloc(GFP_NOIO | __GFP_HIGH, 1); > - bio->bi_iter.bi_sector =3D page_off * (PAGE_SIZE >> 9); > - bio_set_dev(bio, hib_resume_bdev); > - bio_set_op_attrs(bio, op, op_flags); > + bio =3D bio_new(hib_resume_bdev, sect, op, op_flags, 1, > + GFP_NOIO | __GFP_HIGH); > =20 C function with 6 arguments... dunno. Old version looks comparable or even more readable... Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --LQksG6bCIzRHxTLp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmAtkpEACgkQMOfwapXb+vL5ywCguk9XRtMJ4/rJgwKlR42qzH7B ww4AoK8H3c5uHgpu/eHAUqpvoYMrxHuL =Rk1V -----END PGP SIGNATURE----- --LQksG6bCIzRHxTLp-- --===============0970792594194068013== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel --===============0970792594194068013==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 54ED642011A for ; Wed, 17 Feb 2021 23:13:39 +0100 (CET) Date: Wed, 17 Feb 2021 23:02:58 +0100 From: Pavel Machek To: Chaitanya Kulkarni Message-ID: <20210217220257.GA10791@amd> References: <20210128071133.60335-1-chaitanya.kulkarni@wdc.com> <20210128071133.60335-30-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LQksG6bCIzRHxTLp" Content-Disposition: inline In-Reply-To: <20210128071133.60335-30-chaitanya.kulkarni@wdc.com> Cc: shaggy@kernel.org, jfs-discussion@lists.sourceforge.net, gustavoars@kernel.org, sergey.senozhatsky.work@gmail.com, snitzer@redhat.com, tiwai@suse.de, djwong@kernel.org, linux-nvme@lists.infradead.org, philipp.reisner@linbit.com, linux-mm@kvack.org, dm-devel@redhat.com, target-devel@vger.kernel.org, alex.shi@linux.alibaba.com, hch@lst.de, agk@redhat.com, drbd-dev@lists.linbit.com, naohiro.aota@wdc.com, linux-nilfs@vger.kernel.org, sagi@grimberg.me, linux-scsi@vger.kernel.org, mark@fasheh.com, konrad.wilk@oracle.com, osandov@fb.com, ebiggers@kernel.org, xen-devel@lists.xenproject.org, ngupta@vflare.org, len.brown@intel.com, linux-pm@vger.kernel.org, hare@suse.de, ming.lei@redhat.com, linux-block@vger.kernel.org, tj@kernel.org, linux-fscrypt@vger.kernel.org, viro@zeniv.linux.org.uk, jefflexu@linux.alibaba.com, jaegeuk@kernel.org, jlbec@evilplan.org, konishi.ryusuke@gmail.com, bvanassche@acm.org, axboe@kernel.dk, damien.lemoal@wdc.com, tytso@mit.edu, akpm@linux-foundation.org, martin.petersen@oracle.com, joseph.qi@linux.alibaba.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, minchan@kernel.org, linux-fsdevel@vger.kernel.org, lars.ellenberg@linbit.com, jth@kernel.org, asml.silence@gmail.com, ocfs2-devel@oss.oracle.com, roger.pau@citrix.com Subject: Re: [Drbd-dev] [RFC PATCH 29/34] power/swap: use bio_new in hib_submit_io List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --LQksG6bCIzRHxTLp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! >=20 > diff --git a/kernel/power/swap.c b/kernel/power/swap.c > index c73f2e295167..e92e36c053a6 100644 > --- a/kernel/power/swap.c > +++ b/kernel/power/swap.c > @@ -271,13 +271,12 @@ static int hib_submit_io(int op, int op_flags, pgof= f_t page_off, void *addr, > struct hib_bio_batch *hb) > { > struct page *page =3D virt_to_page(addr); > + sector_t sect =3D page_off * (PAGE_SIZE >> 9); > struct bio *bio; > int error =3D 0; > =20 > - bio =3D bio_alloc(GFP_NOIO | __GFP_HIGH, 1); > - bio->bi_iter.bi_sector =3D page_off * (PAGE_SIZE >> 9); > - bio_set_dev(bio, hib_resume_bdev); > - bio_set_op_attrs(bio, op, op_flags); > + bio =3D bio_new(hib_resume_bdev, sect, op, op_flags, 1, > + GFP_NOIO | __GFP_HIGH); > =20 C function with 6 arguments... dunno. Old version looks comparable or even more readable... Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --LQksG6bCIzRHxTLp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmAtkpEACgkQMOfwapXb+vL5ywCguk9XRtMJ4/rJgwKlR42qzH7B ww4AoK8H3c5uHgpu/eHAUqpvoYMrxHuL =Rk1V -----END PGP SIGNATURE----- --LQksG6bCIzRHxTLp--