From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE343C433E6 for ; Thu, 18 Feb 2021 18:17:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9772B64EB7 for ; Thu, 18 Feb 2021 18:17:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231731AbhBRSQ4 (ORCPT ); Thu, 18 Feb 2021 13:16:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:55984 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232893AbhBRQVA (ORCPT ); Thu, 18 Feb 2021 11:21:00 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 51A6C61606; Thu, 18 Feb 2021 16:20:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613665218; bh=GHp96I/gVd4EmUFAptDHDpHWkNykmmfyndnECL0NAbA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Eyayc5+YfPPtm0uaK+Eoc1D452WYMv+Gsf/tSxdxcgIBxZ47Sz4L0Yy8hVK/SLqx6 XO/kXCl8dDL5C/rADkEKSc8s4mF1h1M9xk6GJieFChIq611ekNwu520by4ngKi9Uby 5Jkkh9IZ/FM3Dq6PiiUBUQDvkRQFGFJxeYPu2GzlIm2GGGkbYOaTBSbmp/Zu7sH8M+ 5zJuAWQtKw0mt4Qm5XdwLhrzBFUZmIYmx0gUxsOEJi3AAUQYJnPjqP3SmvfrudqHl3 DcnpOpt/ULK5VHeAqy8g9d6NbAjYHgry/RNbogkUYu6b26kGS+4zN6U7HzRiK/aCtQ vcPx7EI2hpCkA== Date: Thu, 18 Feb 2021 08:20:18 -0800 From: "Darrick J. Wong" To: Ruan Shiyang Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org, darrick.wong@oracle.com, dan.j.williams@intel.com, willy@infradead.org, jack@suse.cz, viro@zeniv.linux.org.uk, linux-btrfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, david@fromorbit.com, rgoldwyn@suse.de, Goldwyn Rodrigues Subject: Re: [PATCH 5/7] fsdax: Dedup file range to use a compare function Message-ID: <20210218162018.GT7193@magnolia> References: <20210207170924.2933035-1-ruansy.fnst@cn.fujitsu.com> <20210207170924.2933035-6-ruansy.fnst@cn.fujitsu.com> <20210208151920.GE12872@lst.de> <9193e305-22a1-3928-0675-af1cecd28942@cn.fujitsu.com> <20210209093438.GA630@lst.de> <79b0d65c-95dd-4821-e412-ab27c8cb6942@cn.fujitsu.com> <20210210131928.GA30109@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Wed, Feb 17, 2021 at 11:24:18AM +0800, Ruan Shiyang wrote: > > > On 2021/2/10 下午9:19, Christoph Hellwig wrote: > > On Tue, Feb 09, 2021 at 05:46:13PM +0800, Ruan Shiyang wrote: > > > > > > > > > On 2021/2/9 下午5:34, Christoph Hellwig wrote: > > > > On Tue, Feb 09, 2021 at 05:15:13PM +0800, Ruan Shiyang wrote: > > > > > The dax dedupe comparison need the iomap_ops pointer as argument, so my > > > > > understanding is that we don't modify the argument list of > > > > > generic_remap_file_range_prep(), but move its code into > > > > > __generic_remap_file_range_prep() whose argument list can be modified to > > > > > accepts the iomap_ops pointer. Then it looks like this: > > > > > > > > I'd say just add the iomap_ops pointer to > > > > generic_remap_file_range_prep and do away with the extra wrappers. We > > > > only have three callers anyway. > > > > > > OK. > > > > So looking at this again I think your proposal actaully is better, > > given that the iomap variant is still DAX specific. Sorry for > > the noise. > > > > Also I think dax_file_range_compare should use iomap_apply instead > > of open coding it. > > > > There are two files, which are not reflinked, need to be direct_access() > here. The iomap_apply() can handle one file each time. So, it seems that > iomap_apply() is not suitable for this case... > > > The pseudo code of this process is as follows: > > srclen = ops->begin(&srcmap) > destlen = ops->begin(&destmap) > > direct_access(&srcmap, &saddr) > direct_access(&destmap, &daddr) > > same = memcpy(saddr, daddr, min(srclen,destlen)) > > ops->end(&destmap) > ops->end(&srcmap) > > I think a nested call like this is necessary. That's why I use the open > code way. This might be a good place to implement an iomap_apply2() loop that actually /does/ walk all the extents of file1 and file2. There's now two users of this idiom. (Possibly structured as a "get next mappings from both" generator function like Matthew Wilcox keeps asking for. :)) --D > > -- > Thanks, > Ruan Shiyang. > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=BAYES_05,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29C0CC433E0 for ; Thu, 18 Feb 2021 16:20:24 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 436DF64E6F for ; Thu, 18 Feb 2021 16:20:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 436DF64E6F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id E7284100EBB9D; Thu, 18 Feb 2021 08:20:20 -0800 (PST) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=djwong@kernel.org; receiver= Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 07692100EBB96 for ; Thu, 18 Feb 2021 08:20:19 -0800 (PST) Received: by mail.kernel.org (Postfix) with ESMTPSA id 51A6C61606; Thu, 18 Feb 2021 16:20:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613665218; bh=GHp96I/gVd4EmUFAptDHDpHWkNykmmfyndnECL0NAbA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Eyayc5+YfPPtm0uaK+Eoc1D452WYMv+Gsf/tSxdxcgIBxZ47Sz4L0Yy8hVK/SLqx6 XO/kXCl8dDL5C/rADkEKSc8s4mF1h1M9xk6GJieFChIq611ekNwu520by4ngKi9Uby 5Jkkh9IZ/FM3Dq6PiiUBUQDvkRQFGFJxeYPu2GzlIm2GGGkbYOaTBSbmp/Zu7sH8M+ 5zJuAWQtKw0mt4Qm5XdwLhrzBFUZmIYmx0gUxsOEJi3AAUQYJnPjqP3SmvfrudqHl3 DcnpOpt/ULK5VHeAqy8g9d6NbAjYHgry/RNbogkUYu6b26kGS+4zN6U7HzRiK/aCtQ vcPx7EI2hpCkA== Date: Thu, 18 Feb 2021 08:20:18 -0800 From: "Darrick J. Wong" To: Ruan Shiyang Subject: Re: [PATCH 5/7] fsdax: Dedup file range to use a compare function Message-ID: <20210218162018.GT7193@magnolia> References: <20210207170924.2933035-1-ruansy.fnst@cn.fujitsu.com> <20210207170924.2933035-6-ruansy.fnst@cn.fujitsu.com> <20210208151920.GE12872@lst.de> <9193e305-22a1-3928-0675-af1cecd28942@cn.fujitsu.com> <20210209093438.GA630@lst.de> <79b0d65c-95dd-4821-e412-ab27c8cb6942@cn.fujitsu.com> <20210210131928.GA30109@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Message-ID-Hash: 7PF3FIYWPNDS7VEDHC5NL52YLNZC7SIQ X-Message-ID-Hash: 7PF3FIYWPNDS7VEDHC5NL52YLNZC7SIQ X-MailFrom: djwong@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org, darrick.wong@oracle.com, willy@infradead.org, jack@suse.cz, viro@zeniv.linux.org.uk, linux-btrfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, david@fromorbit.com, rgoldwyn@suse.de, Goldwyn Rodrigues X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 T24gV2VkLCBGZWIgMTcsIDIwMjEgYXQgMTE6MjQ6MThBTSArMDgwMCwgUnVhbiBTaGl5YW5nIHdy b3RlOg0KPiANCj4gDQo+IE9uIDIwMjEvMi8xMCDkuIvljYg5OjE5LCBDaHJpc3RvcGggSGVsbHdp ZyB3cm90ZToNCj4gPiBPbiBUdWUsIEZlYiAwOSwgMjAyMSBhdCAwNTo0NjoxM1BNICswODAwLCBS dWFuIFNoaXlhbmcgd3JvdGU6DQo+ID4gPiANCj4gPiA+IA0KPiA+ID4gT24gMjAyMS8yLzkg5LiL 5Y2INTozNCwgQ2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6DQo+ID4gPiA+IE9uIFR1ZSwgRmViIDA5 LCAyMDIxIGF0IDA1OjE1OjEzUE0gKzA4MDAsIFJ1YW4gU2hpeWFuZyB3cm90ZToNCj4gPiA+ID4g PiBUaGUgZGF4IGRlZHVwZSBjb21wYXJpc29uIG5lZWQgdGhlIGlvbWFwX29wcyBwb2ludGVyIGFz IGFyZ3VtZW50LCBzbyBteQ0KPiA+ID4gPiA+IHVuZGVyc3RhbmRpbmcgaXMgdGhhdCB3ZSBkb24n dCBtb2RpZnkgdGhlIGFyZ3VtZW50IGxpc3Qgb2YNCj4gPiA+ID4gPiBnZW5lcmljX3JlbWFwX2Zp bGVfcmFuZ2VfcHJlcCgpLCBidXQgbW92ZSBpdHMgY29kZSBpbnRvDQo+ID4gPiA+ID4gX19nZW5l cmljX3JlbWFwX2ZpbGVfcmFuZ2VfcHJlcCgpIHdob3NlIGFyZ3VtZW50IGxpc3QgY2FuIGJlIG1v ZGlmaWVkIHRvDQo+ID4gPiA+ID4gYWNjZXB0cyB0aGUgaW9tYXBfb3BzIHBvaW50ZXIuICBUaGVu IGl0IGxvb2tzIGxpa2UgdGhpczoNCj4gPiA+ID4gDQo+ID4gPiA+IEknZCBzYXkganVzdCBhZGQg dGhlIGlvbWFwX29wcyBwb2ludGVyIHRvDQo+ID4gPiA+IGdlbmVyaWNfcmVtYXBfZmlsZV9yYW5n ZV9wcmVwIGFuZCBkbyBhd2F5IHdpdGggdGhlIGV4dHJhIHdyYXBwZXJzLiAgV2UNCj4gPiA+ID4g b25seSBoYXZlIHRocmVlIGNhbGxlcnMgYW55d2F5Lg0KPiA+ID4gDQo+ID4gPiBPSy4NCj4gPiAN Cj4gPiBTbyBsb29raW5nIGF0IHRoaXMgYWdhaW4gSSB0aGluayB5b3VyIHByb3Bvc2FsIGFjdGF1 bGx5IGlzIGJldHRlciwNCj4gPiBnaXZlbiB0aGF0IHRoZSBpb21hcCB2YXJpYW50IGlzIHN0aWxs IERBWCBzcGVjaWZpYy4gIFNvcnJ5IGZvcg0KPiA+IHRoZSBub2lzZS4NCj4gPiANCj4gPiBBbHNv IEkgdGhpbmsgZGF4X2ZpbGVfcmFuZ2VfY29tcGFyZSBzaG91bGQgdXNlIGlvbWFwX2FwcGx5IGlu c3RlYWQNCj4gPiBvZiBvcGVuIGNvZGluZyBpdC4NCj4gPiANCj4gDQo+IFRoZXJlIGFyZSB0d28g ZmlsZXMsIHdoaWNoIGFyZSBub3QgcmVmbGlua2VkLCBuZWVkIHRvIGJlIGRpcmVjdF9hY2Nlc3Mo KQ0KPiBoZXJlLiAgVGhlIGlvbWFwX2FwcGx5KCkgY2FuIGhhbmRsZSBvbmUgZmlsZSBlYWNoIHRp bWUuICBTbywgaXQgc2VlbXMgdGhhdA0KPiBpb21hcF9hcHBseSgpIGlzIG5vdCBzdWl0YWJsZSBm b3IgdGhpcyBjYXNlLi4uDQo+IA0KPiANCj4gVGhlIHBzZXVkbyBjb2RlIG9mIHRoaXMgcHJvY2Vz cyBpcyBhcyBmb2xsb3dzOg0KPiANCj4gICBzcmNsZW4gPSBvcHMtPmJlZ2luKCZzcmNtYXApDQo+ ICAgZGVzdGxlbiA9IG9wcy0+YmVnaW4oJmRlc3RtYXApDQo+IA0KPiAgIGRpcmVjdF9hY2Nlc3Mo JnNyY21hcCwgJnNhZGRyKQ0KPiAgIGRpcmVjdF9hY2Nlc3MoJmRlc3RtYXAsICZkYWRkcikNCj4g DQo+ICAgc2FtZSA9IG1lbWNweShzYWRkciwgZGFkZHIsIG1pbihzcmNsZW4sZGVzdGxlbikpDQo+ IA0KPiAgIG9wcy0+ZW5kKCZkZXN0bWFwKQ0KPiAgIG9wcy0+ZW5kKCZzcmNtYXApDQo+IA0KPiBJ IHRoaW5rIGEgbmVzdGVkIGNhbGwgbGlrZSB0aGlzIGlzIG5lY2Vzc2FyeS4gIFRoYXQncyB3aHkg SSB1c2UgdGhlIG9wZW4NCj4gY29kZSB3YXkuDQoNClRoaXMgbWlnaHQgYmUgYSBnb29kIHBsYWNl IHRvIGltcGxlbWVudCBhbiBpb21hcF9hcHBseTIoKSBsb29wIHRoYXQNCmFjdHVhbGx5IC9kb2Vz LyB3YWxrIGFsbCB0aGUgZXh0ZW50cyBvZiBmaWxlMSBhbmQgZmlsZTIuICBUaGVyZSdzIG5vdw0K dHdvIHVzZXJzIG9mIHRoaXMgaWRpb20uDQoNCihQb3NzaWJseSBzdHJ1Y3R1cmVkIGFzIGEgImdl dCBuZXh0IG1hcHBpbmdzIGZyb20gYm90aCIgZ2VuZXJhdG9yDQpmdW5jdGlvbiBsaWtlIE1hdHRo ZXcgV2lsY294IGtlZXBzIGFza2luZyBmb3IuIDopKQ0KDQotLUQNCg0KPiANCj4gLS0NCj4gVGhh bmtzLA0KPiBSdWFuIFNoaXlhbmcuDQo+ID4gDQo+IA0KPiAKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtbnZkaW1tIG1haWxpbmcgbGlzdCAtLSBs aW51eC1udmRpbW1AbGlzdHMuMDEub3JnClRvIHVuc3Vic2NyaWJlIHNlbmQgYW4gZW1haWwgdG8g bGludXgtbnZkaW1tLWxlYXZlQGxpc3RzLjAxLm9yZwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 645B1C433E0 for ; Fri, 26 Feb 2021 16:55:36 +0000 (UTC) Received: from aserp2130.oracle.com (aserp2130.oracle.com [141.146.126.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00B7F64E85 for ; Fri, 26 Feb 2021 16:55:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00B7F64E85 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=ocfs2-devel-bounces@oss.oracle.com Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11QGsp07097339; Fri, 26 Feb 2021 16:55:35 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2130.oracle.com with ESMTP id 36vr62d0wm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 Feb 2021 16:55:34 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11QGoJi2004875; Fri, 26 Feb 2021 16:55:34 GMT Received: from oss.oracle.com (oss-old-reserved.oracle.com [137.254.22.2]) by userp3020.oracle.com with ESMTP id 36uc6w48se-1 (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO); Fri, 26 Feb 2021 16:55:33 +0000 Received: from localhost ([127.0.0.1] helo=lb-oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1lFgOq-0000YO-PJ; Fri, 26 Feb 2021 08:55:32 -0800 Received: from userp3030.oracle.com ([156.151.31.80]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1lCm2P-00019h-Sw for ocfs2-devel@oss.oracle.com; Thu, 18 Feb 2021 08:20:21 -0800 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11IGA8ac127324 for ; Thu, 18 Feb 2021 16:20:21 GMT Received: from userp2040.oracle.com (userp2040.oracle.com [156.151.31.90]) by userp3030.oracle.com with ESMTP id 36prq0p86a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 18 Feb 2021 16:20:21 +0000 Received: from pps.filterd (userp2040.oracle.com [127.0.0.1]) by userp2040.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11IGE8xq028676 for ; Thu, 18 Feb 2021 16:20:20 GMT Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by userp2040.oracle.com with ESMTP id 36qrn26nn0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Thu, 18 Feb 2021 16:20:20 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 51A6C61606; Thu, 18 Feb 2021 16:20:18 +0000 (UTC) Date: Thu, 18 Feb 2021 08:20:18 -0800 From: "Darrick J. Wong" To: Ruan Shiyang Message-ID: <20210218162018.GT7193@magnolia> References: <20210207170924.2933035-1-ruansy.fnst@cn.fujitsu.com> <20210207170924.2933035-6-ruansy.fnst@cn.fujitsu.com> <20210208151920.GE12872@lst.de> <9193e305-22a1-3928-0675-af1cecd28942@cn.fujitsu.com> <20210209093438.GA630@lst.de> <79b0d65c-95dd-4821-e412-ab27c8cb6942@cn.fujitsu.com> <20210210131928.GA30109@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-PDR: PASS X-Source-IP: 198.145.29.99 X-ServerName: mail.kernel.org X-Proofpoint-SPF-Result: pass X-Proofpoint-SPF-Record: v=spf1 mx a:vger.kernel.org a:mail.wl.linuxfoundation.org ~all X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9898 signatures=668683 X-Proofpoint-Spam-Details: rule=tap_safe policy=tap score=0 classifier= adjust=0 reason=safe scancount=1 engine=8.12.0-2009150000 definitions=main-2102180140 X-Spam: OrgSafeList X-SpamRule: orgsafelist X-MIME-Autoconverted: from 8bit to quoted-printable by userp3030.oracle.com id 11IGA8ac127324 X-Mailman-Approved-At: Fri, 26 Feb 2021 08:55:31 -0800 Cc: jack@suse.cz, linux-nvdimm@lists.01.org, darrick.wong@oracle.com, david@fromorbit.com, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, viro@zeniv.linux.org.uk, Goldwyn Rodrigues , linux-fsdevel@vger.kernel.org, dan.j.williams@intel.com, linux-btrfs@vger.kernel.org Subject: Re: [Ocfs2-devel] [PATCH 5/7] fsdax: Dedup file range to use a compare function X-BeenThere: ocfs2-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: ocfs2-devel-bounces@oss.oracle.com Errors-To: ocfs2-devel-bounces@oss.oracle.com X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9907 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 adultscore=0 bulkscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102260124 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9907 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0 clxscore=1011 mlxlogscore=999 lowpriorityscore=0 phishscore=0 impostorscore=0 adultscore=0 mlxscore=0 priorityscore=1501 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102260125 T24gV2VkLCBGZWIgMTcsIDIwMjEgYXQgMTE6MjQ6MThBTSArMDgwMCwgUnVhbiBTaGl5YW5nIHdy b3RlOgo+IAo+IAo+IE9uIDIwMjEvMi8xMCDkuIvljYg5OjE5LCBDaHJpc3RvcGggSGVsbHdpZyB3 cm90ZToKPiA+IE9uIFR1ZSwgRmViIDA5LCAyMDIxIGF0IDA1OjQ2OjEzUE0gKzA4MDAsIFJ1YW4g U2hpeWFuZyB3cm90ZToKPiA+ID4gCj4gPiA+IAo+ID4gPiBPbiAyMDIxLzIvOSDkuIvljYg1OjM0 LCBDaHJpc3RvcGggSGVsbHdpZyB3cm90ZToKPiA+ID4gPiBPbiBUdWUsIEZlYiAwOSwgMjAyMSBh dCAwNToxNToxM1BNICswODAwLCBSdWFuIFNoaXlhbmcgd3JvdGU6Cj4gPiA+ID4gPiBUaGUgZGF4 IGRlZHVwZSBjb21wYXJpc29uIG5lZWQgdGhlIGlvbWFwX29wcyBwb2ludGVyIGFzIGFyZ3VtZW50 LCBzbyBteQo+ID4gPiA+ID4gdW5kZXJzdGFuZGluZyBpcyB0aGF0IHdlIGRvbid0IG1vZGlmeSB0 aGUgYXJndW1lbnQgbGlzdCBvZgo+ID4gPiA+ID4gZ2VuZXJpY19yZW1hcF9maWxlX3JhbmdlX3By ZXAoKSwgYnV0IG1vdmUgaXRzIGNvZGUgaW50bwo+ID4gPiA+ID4gX19nZW5lcmljX3JlbWFwX2Zp bGVfcmFuZ2VfcHJlcCgpIHdob3NlIGFyZ3VtZW50IGxpc3QgY2FuIGJlIG1vZGlmaWVkIHRvCj4g PiA+ID4gPiBhY2NlcHRzIHRoZSBpb21hcF9vcHMgcG9pbnRlci4gIFRoZW4gaXQgbG9va3MgbGlr ZSB0aGlzOgo+ID4gPiA+IAo+ID4gPiA+IEknZCBzYXkganVzdCBhZGQgdGhlIGlvbWFwX29wcyBw b2ludGVyIHRvCj4gPiA+ID4gZ2VuZXJpY19yZW1hcF9maWxlX3JhbmdlX3ByZXAgYW5kIGRvIGF3 YXkgd2l0aCB0aGUgZXh0cmEgd3JhcHBlcnMuICBXZQo+ID4gPiA+IG9ubHkgaGF2ZSB0aHJlZSBj YWxsZXJzIGFueXdheS4KPiA+ID4gCj4gPiA+IE9LLgo+ID4gCj4gPiBTbyBsb29raW5nIGF0IHRo aXMgYWdhaW4gSSB0aGluayB5b3VyIHByb3Bvc2FsIGFjdGF1bGx5IGlzIGJldHRlciwKPiA+IGdp dmVuIHRoYXQgdGhlIGlvbWFwIHZhcmlhbnQgaXMgc3RpbGwgREFYIHNwZWNpZmljLiAgU29ycnkg Zm9yCj4gPiB0aGUgbm9pc2UuCj4gPiAKPiA+IEFsc28gSSB0aGluayBkYXhfZmlsZV9yYW5nZV9j b21wYXJlIHNob3VsZCB1c2UgaW9tYXBfYXBwbHkgaW5zdGVhZAo+ID4gb2Ygb3BlbiBjb2Rpbmcg aXQuCj4gPiAKPiAKPiBUaGVyZSBhcmUgdHdvIGZpbGVzLCB3aGljaCBhcmUgbm90IHJlZmxpbmtl ZCwgbmVlZCB0byBiZSBkaXJlY3RfYWNjZXNzKCkKPiBoZXJlLiAgVGhlIGlvbWFwX2FwcGx5KCkg Y2FuIGhhbmRsZSBvbmUgZmlsZSBlYWNoIHRpbWUuICBTbywgaXQgc2VlbXMgdGhhdAo+IGlvbWFw X2FwcGx5KCkgaXMgbm90IHN1aXRhYmxlIGZvciB0aGlzIGNhc2UuLi4KPiAKPiAKPiBUaGUgcHNl dWRvIGNvZGUgb2YgdGhpcyBwcm9jZXNzIGlzIGFzIGZvbGxvd3M6Cj4gCj4gICBzcmNsZW4gPSBv cHMtPmJlZ2luKCZzcmNtYXApCj4gICBkZXN0bGVuID0gb3BzLT5iZWdpbigmZGVzdG1hcCkKPiAK PiAgIGRpcmVjdF9hY2Nlc3MoJnNyY21hcCwgJnNhZGRyKQo+ICAgZGlyZWN0X2FjY2VzcygmZGVz dG1hcCwgJmRhZGRyKQo+IAo+ICAgc2FtZSA9IG1lbWNweShzYWRkciwgZGFkZHIsIG1pbihzcmNs ZW4sZGVzdGxlbikpCj4gCj4gICBvcHMtPmVuZCgmZGVzdG1hcCkKPiAgIG9wcy0+ZW5kKCZzcmNt YXApCj4gCj4gSSB0aGluayBhIG5lc3RlZCBjYWxsIGxpa2UgdGhpcyBpcyBuZWNlc3NhcnkuICBU aGF0J3Mgd2h5IEkgdXNlIHRoZSBvcGVuCj4gY29kZSB3YXkuCgpUaGlzIG1pZ2h0IGJlIGEgZ29v ZCBwbGFjZSB0byBpbXBsZW1lbnQgYW4gaW9tYXBfYXBwbHkyKCkgbG9vcCB0aGF0CmFjdHVhbGx5 IC9kb2VzLyB3YWxrIGFsbCB0aGUgZXh0ZW50cyBvZiBmaWxlMSBhbmQgZmlsZTIuICBUaGVyZSdz IG5vdwp0d28gdXNlcnMgb2YgdGhpcyBpZGlvbS4KCihQb3NzaWJseSBzdHJ1Y3R1cmVkIGFzIGEg ImdldCBuZXh0IG1hcHBpbmdzIGZyb20gYm90aCIgZ2VuZXJhdG9yCmZ1bmN0aW9uIGxpa2UgTWF0 dGhldyBXaWxjb3gga2VlcHMgYXNraW5nIGZvci4gOikpCgotLUQKCj4gCj4gLS0KPiBUaGFua3Ms Cj4gUnVhbiBTaGl5YW5nLgo+ID4gCj4gCj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpPY2ZzMi1kZXZlbCBtYWlsaW5nIGxpc3QKT2NmczItZGV2ZWxA b3NzLm9yYWNsZS5jb20KaHR0cHM6Ly9vc3Mub3JhY2xlLmNvbS9tYWlsbWFuL2xpc3RpbmZvL29j ZnMyLWRldmVs