[MPTCP] Re: [PATCH] mptcp: reset 'first' and ack_hint on subflow close

[Florian Westphal <fw at strlen.de>]

[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]

Paolo Abeni <pabeni(a)redhat.com> wrote:
> On Thu, 2021-02-18 at 16:59 +0100, Florian Westphal wrote:
> > Just like with last_snd, we have to NULL 'first' on subflow close.
> > 
> > ack_hint isn't strictly required (its never dereferenced), but better to
> > clear this as well.
> > 
> > msk->first is dereferenced unconditionally at accept time, but
> > at that point the ssk is not on the conn_list yet -- this means
> > worker can't see it when iterating the conn_list.
> 
> There is a __mptcp_flush_join_list() before __mptcp_close_subflow(),
> could that matter? IIRC even the PM can move the subflow from join_list
> to conn_list to take some actions.
> 
> not 110% related, we have a couple of !msk->first in 
> mptcp_update_rcv_data_fin() and mptcp_check_data_fin() which are likely
> obsoleted/to be removed.

Hmm, if those are redunant, what exactly do we need msk->first for?
Fallback mode could just fetch the subflow off conn_list.

Matthieu, please ignore this patch for now, I'd prefer to remove
msk->first completely if possible.