From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Date: Fri, 19 Feb 2021 14:01:05 +0000 Subject: Re: [PATCH v2 1/4] hmm: Device exclusive memory access Message-Id: <20210219140105.GE2643399@ziepe.ca> List-Id: References: <20210219020750.16444-1-apopple@nvidia.com> <20210219020750.16444-2-apopple@nvidia.com> <20210219094741.GA641389@infradead.org> In-Reply-To: <20210219094741.GA641389@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Hellwig Cc: Alistair Popple , linux-mm@kvack.org, nouveau@lists.freedesktop.org, bskeggs@redhat.com, akpm@linux-foundation.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org, dri-devel@lists.freedesktop.org, jhubbard@nvidia.com, rcampbell@nvidia.com, jglisse@redhat.com, daniel@ffwll.ch On Fri, Feb 19, 2021 at 09:47:41AM +0000, Christoph Hellwig wrote: > > diff --git a/include/linux/hmm.h b/include/linux/hmm.h > > index 866a0fa104c4..5d28ff6d4d80 100644 > > +++ b/include/linux/hmm.h > > @@ -109,6 +109,10 @@ struct hmm_range { > > */ > > int hmm_range_fault(struct hmm_range *range); > > > > +int hmm_exclusive_range(struct mm_struct *mm, unsigned long start, > > + unsigned long end, struct page **pages); > > +vm_fault_t hmm_remove_exclusive_entry(struct vm_fault *vmf); > > Can we avoid the hmm naming for new code (we should probably also kill > it off for the existing code)? Yes please, I'd prefer it if hmm.c was just the special page walker and not a grab bag of unrelated things Is there is a more natural place to put this in the mm for this idea? Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D77D7C433E6 for ; Fri, 19 Feb 2021 14:01:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DB5E64EB7 for ; Fri, 19 Feb 2021 14:01:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229998AbhBSOBu (ORCPT ); Fri, 19 Feb 2021 09:01:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229636AbhBSOBt (ORCPT ); Fri, 19 Feb 2021 09:01:49 -0500 Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71D3EC061756 for ; Fri, 19 Feb 2021 06:01:09 -0800 (PST) Received: by mail-qt1-x834.google.com with SMTP id f17so3932744qth.7 for ; Fri, 19 Feb 2021 06:01:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Uy9+p8EYLZ+2upxXdnXYCqgGljKcN5wTbKwGZwnqinY=; b=I5flSyH/gLTP7kfpLHlSgh5tXtA+Jh1EsK+6uIgyy09vUXp0IZUoyofNXle2UG8+9x 6bQcZMjTHGSnCjsIADBeVZNPoafr3TSU4gbVUKm8tx7gxct5TAh1oqibAjgx2ny24Qlv nA8b7dO5wJoNvKGJUaq5YdpKB1knNz20AuCjHXqPKjX/HXDnk9GUA8KprUxsiW5TqfOU 9o+5AHrQgpJl5wOCAeVJMcNlnBgpfbhD2hv2/vQ80bpHkUbm4gdpFUasgTAZI9JejzbF hWMAig8ep9wZI5JeASo7p/0n5GOB7qV6LVTspTVmRmVoA3TvIzBilhfwzcUDD73XF8lP SRsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Uy9+p8EYLZ+2upxXdnXYCqgGljKcN5wTbKwGZwnqinY=; b=K2C/c6XInpiOPHtl4CjqXFhjEIj9LpJr7wailnlLjgE5ovSTi1vKcHxD1ESCY20eVB K6O6hSF6e8Zq9TK73RDPr5+wMTmSVGN8ZoN65CZGVSEzNuY4a6a3BIrvWqbYDstWECEK Y8rWeMnHM94ftZDSSjnqVuysEsOuge3cqHGWkGaq9SDasjSZK4ris3HwBHwU3dX4bbCJ 6hQuHJomKTBPzQHRLe+6mdvcx68ixy0mUoFjGjbAewvOu3aao5R5XwdjWpA8wHNV2rXU KvteForW+7+TAKOT0FcUK+1O9j0M2Y8VoRK+7REIB9SXh+FM4dI4aztao2jXSGqmq3qL jzhA== X-Gm-Message-State: AOAM531nYK+I8NXftFpUjW4ws/EQ36rf5fgpD7wU2cu4ZbcfeeOOi/UR PMbVas5Gp4tr3md4SFJYKksi0Q== X-Google-Smtp-Source: ABdhPJwvDnWgEME/UBp5mpDqS0tmSE99XXBjYe+mDgcmjGaB5orYQxdcs7Ze95f3nVqD5XVW9Zc5qg== X-Received: by 2002:a05:622a:306:: with SMTP id q6mr8969998qtw.15.1613743266418; Fri, 19 Feb 2021 06:01:06 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-115-133.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.115.133]) by smtp.gmail.com with ESMTPSA id 14sm5338161qtx.84.2021.02.19.06.01.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Feb 2021 06:01:05 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1lD6LB-00CPnQ-2t; Fri, 19 Feb 2021 10:01:05 -0400 Date: Fri, 19 Feb 2021 10:01:05 -0400 From: Jason Gunthorpe To: Christoph Hellwig Cc: Alistair Popple , linux-mm@kvack.org, nouveau@lists.freedesktop.org, bskeggs@redhat.com, akpm@linux-foundation.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org, dri-devel@lists.freedesktop.org, jhubbard@nvidia.com, rcampbell@nvidia.com, jglisse@redhat.com, daniel@ffwll.ch Subject: Re: [PATCH v2 1/4] hmm: Device exclusive memory access Message-ID: <20210219140105.GE2643399@ziepe.ca> References: <20210219020750.16444-1-apopple@nvidia.com> <20210219020750.16444-2-apopple@nvidia.com> <20210219094741.GA641389@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210219094741.GA641389@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Fri, Feb 19, 2021 at 09:47:41AM +0000, Christoph Hellwig wrote: > > diff --git a/include/linux/hmm.h b/include/linux/hmm.h > > index 866a0fa104c4..5d28ff6d4d80 100644 > > +++ b/include/linux/hmm.h > > @@ -109,6 +109,10 @@ struct hmm_range { > > */ > > int hmm_range_fault(struct hmm_range *range); > > > > +int hmm_exclusive_range(struct mm_struct *mm, unsigned long start, > > + unsigned long end, struct page **pages); > > +vm_fault_t hmm_remove_exclusive_entry(struct vm_fault *vmf); > > Can we avoid the hmm naming for new code (we should probably also kill > it off for the existing code)? Yes please, I'd prefer it if hmm.c was just the special page walker and not a grab bag of unrelated things Is there is a more natural place to put this in the mm for this idea? Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A542C433E0 for ; Fri, 19 Feb 2021 14:01:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7CEA64EC0 for ; Fri, 19 Feb 2021 14:01:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7CEA64EC0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=nouveau-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E74BF6EB3D; Fri, 19 Feb 2021 14:01:10 +0000 (UTC) Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by gabe.freedesktop.org (Postfix) with ESMTPS id C426F6EB3B for ; Fri, 19 Feb 2021 14:01:09 +0000 (UTC) Received: by mail-qt1-x836.google.com with SMTP id v3so3937739qtw.4 for ; Fri, 19 Feb 2021 06:01:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Uy9+p8EYLZ+2upxXdnXYCqgGljKcN5wTbKwGZwnqinY=; b=I5flSyH/gLTP7kfpLHlSgh5tXtA+Jh1EsK+6uIgyy09vUXp0IZUoyofNXle2UG8+9x 6bQcZMjTHGSnCjsIADBeVZNPoafr3TSU4gbVUKm8tx7gxct5TAh1oqibAjgx2ny24Qlv nA8b7dO5wJoNvKGJUaq5YdpKB1knNz20AuCjHXqPKjX/HXDnk9GUA8KprUxsiW5TqfOU 9o+5AHrQgpJl5wOCAeVJMcNlnBgpfbhD2hv2/vQ80bpHkUbm4gdpFUasgTAZI9JejzbF hWMAig8ep9wZI5JeASo7p/0n5GOB7qV6LVTspTVmRmVoA3TvIzBilhfwzcUDD73XF8lP SRsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Uy9+p8EYLZ+2upxXdnXYCqgGljKcN5wTbKwGZwnqinY=; b=RJzEno2C1Vx14iFqPJhvnmVnYPt/5WJi6C6ikxxC9fLnuuAvAvvM3VXhcZdlJbdogH Pmg+i9y+azt7E9BZUTEADTDZBAKoaxPuTcextcqEKkIT/EASoS44gZ+9sk0UL6l5A7Q2 Pl+coOdFZRqJ4bhxCQ0k9Yf3BEcYNOqkpLzMYaxfCSqy6wt7JYcO4ihcEA2nP3adsU15 UuuESBr/aHXIe6xbyVROpEb23Z+Y6M1sHddwzN4eyg9kx//ChaeZMMV+eamjJA3I6xir G085VFPEJyICgkF+BHmGpD1qVNdbED4VM3kCfs21gm+aMZiFc3RFMMgXIoJ0qqWqW+6E jVbQ== X-Gm-Message-State: AOAM532+wE7KM7SiX0k6LCjMnZ3nTSuTLr4MIkx4wxGxzZB5D5GmkpuM 2xigheXuVYDLoH02mIffBRjOWg== X-Google-Smtp-Source: ABdhPJwvDnWgEME/UBp5mpDqS0tmSE99XXBjYe+mDgcmjGaB5orYQxdcs7Ze95f3nVqD5XVW9Zc5qg== X-Received: by 2002:a05:622a:306:: with SMTP id q6mr8969998qtw.15.1613743266418; Fri, 19 Feb 2021 06:01:06 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-115-133.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.115.133]) by smtp.gmail.com with ESMTPSA id 14sm5338161qtx.84.2021.02.19.06.01.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Feb 2021 06:01:05 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1lD6LB-00CPnQ-2t; Fri, 19 Feb 2021 10:01:05 -0400 Date: Fri, 19 Feb 2021 10:01:05 -0400 From: Jason Gunthorpe To: Christoph Hellwig Message-ID: <20210219140105.GE2643399@ziepe.ca> References: <20210219020750.16444-1-apopple@nvidia.com> <20210219020750.16444-2-apopple@nvidia.com> <20210219094741.GA641389@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210219094741.GA641389@infradead.org> Subject: Re: [Nouveau] [PATCH v2 1/4] hmm: Device exclusive memory access X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: rcampbell@nvidia.com, linux-doc@vger.kernel.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alistair Popple , linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-mm@kvack.org, bskeggs@redhat.com, daniel@ffwll.ch, akpm@linux-foundation.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Fri, Feb 19, 2021 at 09:47:41AM +0000, Christoph Hellwig wrote: > > diff --git a/include/linux/hmm.h b/include/linux/hmm.h > > index 866a0fa104c4..5d28ff6d4d80 100644 > > +++ b/include/linux/hmm.h > > @@ -109,6 +109,10 @@ struct hmm_range { > > */ > > int hmm_range_fault(struct hmm_range *range); > > > > +int hmm_exclusive_range(struct mm_struct *mm, unsigned long start, > > + unsigned long end, struct page **pages); > > +vm_fault_t hmm_remove_exclusive_entry(struct vm_fault *vmf); > > Can we avoid the hmm naming for new code (we should probably also kill > it off for the existing code)? Yes please, I'd prefer it if hmm.c was just the special page walker and not a grab bag of unrelated things Is there is a more natural place to put this in the mm for this idea? Jason _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF1A8C433DB for ; Fri, 19 Feb 2021 14:01:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19F8A64EB7 for ; Fri, 19 Feb 2021 14:01:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19F8A64EB7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B5B36EB3B; Fri, 19 Feb 2021 14:01:10 +0000 (UTC) Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) by gabe.freedesktop.org (Postfix) with ESMTPS id C48126EB3C for ; Fri, 19 Feb 2021 14:01:09 +0000 (UTC) Received: by mail-qt1-x82b.google.com with SMTP id o21so3944101qtr.3 for ; Fri, 19 Feb 2021 06:01:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Uy9+p8EYLZ+2upxXdnXYCqgGljKcN5wTbKwGZwnqinY=; b=I5flSyH/gLTP7kfpLHlSgh5tXtA+Jh1EsK+6uIgyy09vUXp0IZUoyofNXle2UG8+9x 6bQcZMjTHGSnCjsIADBeVZNPoafr3TSU4gbVUKm8tx7gxct5TAh1oqibAjgx2ny24Qlv nA8b7dO5wJoNvKGJUaq5YdpKB1knNz20AuCjHXqPKjX/HXDnk9GUA8KprUxsiW5TqfOU 9o+5AHrQgpJl5wOCAeVJMcNlnBgpfbhD2hv2/vQ80bpHkUbm4gdpFUasgTAZI9JejzbF hWMAig8ep9wZI5JeASo7p/0n5GOB7qV6LVTspTVmRmVoA3TvIzBilhfwzcUDD73XF8lP SRsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Uy9+p8EYLZ+2upxXdnXYCqgGljKcN5wTbKwGZwnqinY=; b=M0/lj+yihSwrgMHDAH0S7sNQsG7jcI9T3KN+Wx68UREKN/WfwT61GwaahS4Iv4VloO J3Jq9UlEvIr/TVdSnnyOB4ehDIFrzwKEoVYFDNheDyy6BFPn4/ALthhPTBMls+zlw8uM PVZ6n7a4+uqcHofjCFXEXCYiZ6MhhXg3vQ0PO8X3Z7mF9iTuCP/PKn495/xtJGR2KQ7m MiAx/UDqDk7q9Bxtt6jRkYpWFebgaUCuDeWkjQ4xwDRTaKNvSStzIMAJ8Pd3GlVj/MV+ HIi+jGCb/7txCVxRtlb7A/5ZCHO0nFStltG+U0Guxsdas+hSoq4ZvDGP2gkAtmESy5CX ilZg== X-Gm-Message-State: AOAM53218c/Q75cMBWHairn4W3UAfMKorPpHn2FzaeSq5x2CW1qaLRb9 j7eCei4LXYjDAjrIi7upD6HJUg== X-Google-Smtp-Source: ABdhPJwvDnWgEME/UBp5mpDqS0tmSE99XXBjYe+mDgcmjGaB5orYQxdcs7Ze95f3nVqD5XVW9Zc5qg== X-Received: by 2002:a05:622a:306:: with SMTP id q6mr8969998qtw.15.1613743266418; Fri, 19 Feb 2021 06:01:06 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-115-133.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.115.133]) by smtp.gmail.com with ESMTPSA id 14sm5338161qtx.84.2021.02.19.06.01.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Feb 2021 06:01:05 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1lD6LB-00CPnQ-2t; Fri, 19 Feb 2021 10:01:05 -0400 Date: Fri, 19 Feb 2021 10:01:05 -0400 From: Jason Gunthorpe To: Christoph Hellwig Subject: Re: [PATCH v2 1/4] hmm: Device exclusive memory access Message-ID: <20210219140105.GE2643399@ziepe.ca> References: <20210219020750.16444-1-apopple@nvidia.com> <20210219020750.16444-2-apopple@nvidia.com> <20210219094741.GA641389@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210219094741.GA641389@infradead.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: rcampbell@nvidia.com, linux-doc@vger.kernel.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alistair Popple , linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-mm@kvack.org, jglisse@redhat.com, bskeggs@redhat.com, jhubbard@nvidia.com, akpm@linux-foundation.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Feb 19, 2021 at 09:47:41AM +0000, Christoph Hellwig wrote: > > diff --git a/include/linux/hmm.h b/include/linux/hmm.h > > index 866a0fa104c4..5d28ff6d4d80 100644 > > +++ b/include/linux/hmm.h > > @@ -109,6 +109,10 @@ struct hmm_range { > > */ > > int hmm_range_fault(struct hmm_range *range); > > > > +int hmm_exclusive_range(struct mm_struct *mm, unsigned long start, > > + unsigned long end, struct page **pages); > > +vm_fault_t hmm_remove_exclusive_entry(struct vm_fault *vmf); > > Can we avoid the hmm naming for new code (we should probably also kill > it off for the existing code)? Yes please, I'd prefer it if hmm.c was just the special page walker and not a grab bag of unrelated things Is there is a more natural place to put this in the mm for this idea? Jason _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel