From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kurt Manucredo <fuzzybritches@protonmail.com>
Cc: gregkh@linuxfoundation.org, ross.schm.dev@gmail.com,
straube.linux@gmail.com, d.straghkov@ispras.ru, tiwai@suse.de,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: fix code style comparison warning
Date: Fri, 19 Feb 2021 20:14:32 +0300 [thread overview]
Message-ID: <20210219171432.GA2087@kadam> (raw)
In-Reply-To: <20210219144928.8-1-fuzzybritches@protonmail.com>
On Fri, Feb 19, 2021 at 02:50:53PM +0000, Kurt Manucredo wrote:
>
>
> changes since previous version:
> - change Subject line
> - change commit message
> - change commit message position to above signed-off-by
>
These comments need to go below the --- cut off line.
> checkpatch gives the following WARNING:
> WARNING: Comparisons should place the constant on the right side of the test
> this patch fixes the coding style warning.
>
> Signed-off-by: Kurt Manucredo <fuzzybritches@protonmail.com>
> ---
^^^
This one here.
> drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
regards,
dan carpenter
prev parent reply other threads:[~2021-02-19 17:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 14:50 [PATCH v2] staging: rtl8723bs: fix code style comparison warning Kurt Manucredo
2021-02-19 16:25 ` Greg KH
2021-02-19 17:14 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219171432.GA2087@kadam \
--to=dan.carpenter@oracle.com \
--cc=d.straghkov@ispras.ru \
--cc=devel@driverdev.osuosl.org \
--cc=fuzzybritches@protonmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ross.schm.dev@gmail.com \
--cc=straube.linux@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.