From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [bcache:for-next 17/24] drivers/md/bcache/journal.c:802 __journal_nvdimm_write_unlocked() warn: should 'sectors << 9' be a 64 bit
Date: Fri, 19 Feb 2021 20:06:29 +0800 [thread overview]
Message-ID: <202102192017.mPyRi4Tl-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2522 bytes --]
CC: kbuild-all(a)lists.01.org
TO: Coly Li <colyli@suse.de>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/colyli/linux-bcache.git for-next
head: 4abec8296a44a76ba4c59ed09d37a1f13604e57f
commit: 8e7f175298f3f054202b7ce5deaf716072e6d71f [17/24] bcache: support storing bcache journal into NVDIMM meta device
:::::: branch date: 9 days ago
:::::: commit date: 10 days ago
config: x86_64-randconfig-m001-20210219 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/md/bcache/journal.c:802 __journal_nvdimm_write_unlocked() warn: should 'sectors << 9' be a 64 bit type?
vim +802 drivers/md/bcache/journal.c
8e7f175298f3f0 Coly Li 2021-02-07 789
8e7f175298f3f0 Coly Li 2021-02-07 790 static void __journal_nvdimm_write_unlocked(struct cache_set *c)
8e7f175298f3f0 Coly Li 2021-02-07 791 __releases(c->journal.lock)
8e7f175298f3f0 Coly Li 2021-02-07 792 {
8e7f175298f3f0 Coly Li 2021-02-07 793 struct journal_write *w = c->journal.cur;
8e7f175298f3f0 Coly Li 2021-02-07 794 struct cache *ca = c->cache;
8e7f175298f3f0 Coly Li 2021-02-07 795 unsigned int sectors;
8e7f175298f3f0 Coly Li 2021-02-07 796
8e7f175298f3f0 Coly Li 2021-02-07 797 sectors = set_blocks(w->data, block_bytes(ca)) * ca->sb.block_size;
8e7f175298f3f0 Coly Li 2021-02-07 798 atomic_long_add(sectors, &ca->meta_sectors_written);
8e7f175298f3f0 Coly Li 2021-02-07 799
8e7f175298f3f0 Coly Li 2021-02-07 800 memcpy_flushcache((void *)c->journal.key.ptr[0], w->data, sectors << 9);
8e7f175298f3f0 Coly Li 2021-02-07 801
8e7f175298f3f0 Coly Li 2021-02-07 @802 c->journal.key.ptr[0] += sectors << 9;
8e7f175298f3f0 Coly Li 2021-02-07 803 ca->journal.seq[ca->journal.cur_idx] = w->data->seq;
8e7f175298f3f0 Coly Li 2021-02-07 804
8e7f175298f3f0 Coly Li 2021-02-07 805 atomic_dec_bug(&fifo_back(&c->journal.pin));
8e7f175298f3f0 Coly Li 2021-02-07 806 bch_journal_next(&c->journal);
8e7f175298f3f0 Coly Li 2021-02-07 807 journal_reclaim(c);
8e7f175298f3f0 Coly Li 2021-02-07 808
8e7f175298f3f0 Coly Li 2021-02-07 809 spin_unlock(&c->journal.lock);
8e7f175298f3f0 Coly Li 2021-02-07 810 }
8e7f175298f3f0 Coly Li 2021-02-07 811
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38290 bytes --]
reply other threads:[~2021-02-19 12:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202102192017.mPyRi4Tl-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.